Changeset 251744 in webkit

Timestamp:

Oct 29, 2019 5:10:28 PM (4 years ago)

Author:

Nikita Vasilyev

Message:

Web Inspector: Opacity slider background doesn't update when when hue slider moves
​https://bugs.webkit.org/show_bug.cgi?id=203593
<rdar://problem/56723629>

Reviewed by Matt Baker.

• UserInterface/Views/ColorPicker.js:

(WI.ColorPicker.prototype.set color):
(WI.ColorPicker.prototype.colorSquareColorDidChange):
Remove unused function arguments.

(WI.ColorPicker.prototype.sliderValueDidChange):
Update the background of the opacity slider when the hue slider changes.

(WI.ColorPicker.prototype._updateOpacitySlider): Renamed from _updateSliders.
Drive-by: replace var with let.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/ColorPicker.js (modified) (4 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2019-10-29  Nikita Vasilyev  <nvasilyev@apple.com>
+
+        Web Inspector: Opacity slider background doesn't update when when hue slider moves
+        https://bugs.webkit.org/show_bug.cgi?id=203593
+        <rdar://problem/56723629>
+
+        Reviewed by Matt Baker.
+
+        * UserInterface/Views/ColorPicker.js:
+        (WI.ColorPicker.prototype.set color):
+        (WI.ColorPicker.prototype.colorSquareColorDidChange):
+        Remove unused function arguments.
+
+        (WI.ColorPicker.prototype.sliderValueDidChange):
+        Update the background of the opacity slider when the hue slider changes.
+
+        (WI.ColorPicker.prototype._updateOpacitySlider): Renamed from _updateSliders.
+        Drive-by: replace `var` with `let`.
+
 2019-10-28  Nikita Vasilyev  <nvasilyev@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/ColorPicker.js

@@ -124 +124 @@
 
         this._opacitySlider.value = this._color.alpha;
-        this._updateSliders(this._colorSquare.rawColor, this._color);
+        this._updateOpacitySlider();
 
         this._showColorComponentInputs();
@@ -144 +144 @@
     {
         this._updateColor();
-        this._updateSliders(this._colorSquare.rawColor, this._colorSquare.tintedColor);
+        this._updateOpacitySlider();
     }
 
@@ -154 +154 @@
             this._colorSquare.hue = value * 360;
             this._updateColor();
+            this._updateOpacitySlider();
         }
     }
@@ -190 +191 @@
     }
 
-    _updateSliders(rawColor, tintedColor)
-    {
-        var rgb = this._colorSquare.tintedColor.rgb;
-        var opaque = new WI.Color(WI.Color.Format.RGBA, rgb.concat(1)).toString();
-        var transparent = new WI.Color(WI.Color.Format.RGBA, rgb.concat(0)).toString();
+    _updateOpacitySlider()
+    {
+        let rgb = this._colorSquare.tintedColor.rgb;
+        let opaque = new WI.Color(WI.Color.Format.RGBA, rgb.concat(1)).toString();
+        let transparent = new WI.Color(WI.Color.Format.RGBA, rgb.concat(0)).toString();
         this._opacitySlider.element.style.setProperty("background-image", "linear-gradient(90deg, " + transparent + ", " + opaque + "), " + this._opacityPattern);
     }