Changeset 251764 in webkit


Ignore:
Timestamp:
Oct 29, 2019 8:14:51 PM (4 years ago)
Author:
commit-queue@webkit.org
Message:

[SVG2] SVGSymbolElement should inherits SVGGraphicsElement
​https://bugs.webkit.org/show_bug.cgi?id=203573

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2019-10-29
Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

  • web-platform-tests/svg/idlharness.window-expected.txt:

Source/WebCore:

The spec link is:

​https://www.w3.org/TR/SVG2/struct.html#InterfaceSVGSymbolElement

  • svg/SVGSymbolElement.cpp:

(WebCore::SVGSymbolElement::SVGSymbolElement):
(WebCore::SVGSymbolElement::parseAttribute):

  • svg/SVGSymbolElement.h:
  • svg/SVGSymbolElement.idl:

LayoutTests:

  • svg/dom/svg2-inheritance-expected.txt:
  • svg/dom/svg2-inheritance.html:
Location:
trunk
Files:
9 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r251761 r251764  
     12019-10-29  Said Abou-Hallawa  <sabouhallawa@apple.com>
     2
     3        [SVG2] SVGSymbolElement should inherits SVGGraphicsElement
     4        https://bugs.webkit.org/show_bug.cgi?id=203573
     5
     6        Reviewed by Simon Fraser.
     7
     8        * svg/dom/svg2-inheritance-expected.txt:
     9        * svg/dom/svg2-inheritance.html:
     10
    1112019-10-29  Wenson Hsieh  <wenson_hsieh@apple.com>
    212

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r251750 r251764  
     12019-10-29  Said Abou-Hallawa  <sabouhallawa@apple.com>
     2
     3        [SVG2] SVGSymbolElement should inherits SVGGraphicsElement
     4        https://bugs.webkit.org/show_bug.cgi?id=203573
     5
     6        Reviewed by Simon Fraser.
     7
     8        * web-platform-tests/svg/idlharness.window-expected.txt:
     9
    1102019-10-29  Simon Fraser  <simon.fraser@apple.com>
    211

  • trunk/LayoutTests/imported/w3c/web-platform-tests/svg/idlharness.window-expected.txt

    r251527 r251764  
    512512FAIL SVGElement interface: objects.title must inherit property "correspondingElement" with the proper type assert_inherits: property "correspondingElement" not found in prototype chain
    513513FAIL SVGElement interface: objects.title must inherit property "correspondingUseElement" with the proper type assert_inherits: property "correspondingUseElement" not found in prototype chain
    514 FAIL SVGSymbolElement interface: existence and properties of interface object assert_equals: prototype of SVGSymbolElement is not SVGGraphicsElement expected function "function SVGGraphicsElement() {
    515     [native code]
    516 }" but got function "function SVGElement() {
    517     [native code]
    518 }"
     514PASS SVGSymbolElement interface: existence and properties of interface object
    519515PASS SVGSymbolElement interface object length
    520516PASS SVGSymbolElement interface object name
    521 FAIL SVGSymbolElement interface: existence and properties of interface prototype object assert_equals: prototype of SVGSymbolElement.prototype is not SVGGraphicsElement.prototype expected object "[object SVGGraphicsElementPrototype]" but got object "[object SVGElementPrototype]"
     517PASS SVGSymbolElement interface: existence and properties of interface prototype object
    522518PASS SVGSymbolElement interface: existence and properties of interface prototype object's "constructor" property
    523519PASS SVGSymbolElement interface: existence and properties of interface prototype object's @@unscopables property
    … …  
    528524PASS SVGSymbolElement interface: objects.symbol must inherit property "viewBox" with the proper type
    529525PASS SVGSymbolElement interface: objects.symbol must inherit property "preserveAspectRatio" with the proper type
    530 FAIL SVGGraphicsElement interface: objects.symbol must inherit property "transform" with the proper type assert_inherits: property "transform" not found in prototype chain
    531 FAIL SVGGraphicsElement interface: objects.symbol must inherit property "getBBox(SVGBoundingBoxOptions)" with the proper type assert_inherits: property "getBBox" not found in prototype chain
    532 FAIL SVGGraphicsElement interface: calling getBBox(SVGBoundingBoxOptions) on objects.symbol with too few arguments must throw TypeError assert_inherits: property "getBBox" not found in prototype chain
    533 FAIL SVGGraphicsElement interface: objects.symbol must inherit property "getCTM()" with the proper type assert_inherits: property "getCTM" not found in prototype chain
    534 FAIL SVGGraphicsElement interface: objects.symbol must inherit property "getScreenCTM()" with the proper type assert_inherits: property "getScreenCTM" not found in prototype chain
    535 FAIL SVGGraphicsElement interface: objects.symbol must inherit property "requiredExtensions" with the proper type assert_inherits: property "requiredExtensions" not found in prototype chain
    536 FAIL SVGGraphicsElement interface: objects.symbol must inherit property "systemLanguage" with the proper type assert_inherits: property "systemLanguage" not found in prototype chain
     526PASS SVGGraphicsElement interface: objects.symbol must inherit property "transform" with the proper type
     527PASS SVGGraphicsElement interface: objects.symbol must inherit property "getBBox(SVGBoundingBoxOptions)" with the proper type
     528PASS SVGGraphicsElement interface: calling getBBox(SVGBoundingBoxOptions) on objects.symbol with too few arguments must throw TypeError
     529PASS SVGGraphicsElement interface: objects.symbol must inherit property "getCTM()" with the proper type
     530PASS SVGGraphicsElement interface: objects.symbol must inherit property "getScreenCTM()" with the proper type
     531PASS SVGGraphicsElement interface: objects.symbol must inherit property "requiredExtensions" with the proper type
     532PASS SVGGraphicsElement interface: objects.symbol must inherit property "systemLanguage" with the proper type
    537533PASS SVGElement interface: objects.symbol must inherit property "className" with the proper type
    538534PASS SVGElement interface: objects.symbol must inherit property "ownerSVGElement" with the proper type

  • trunk/LayoutTests/svg/dom/svg2-inheritance-expected.txt

    r231955 r251764  
    107107PASS SVGStyleElement inherits SVGElement
    108108PASS SVGSwitchElement inherits SVGGraphicsElement
    109 PASS SVGSymbolElement inherits SVGElement
     109PASS SVGSymbolElement inherits SVGGraphicsElement
    110110PASS SVGTRefElement inherits SVGTextPositioningElement
    111111PASS SVGTSpanElement inherits SVGTextPositioningElement

  • trunk/LayoutTests/svg/dom/svg2-inheritance.html

    r179810 r251764  
    135135checkParent("SVGStyleElement", "SVGElement");
    136136checkParent("SVGSwitchElement", "SVGGraphicsElement");
    137 checkParent("SVGSymbolElement", "SVGElement");
     137checkParent("SVGSymbolElement", "SVGGraphicsElement");
    138138checkParent("SVGTRefElement", "SVGTextPositioningElement");
    139139checkParent("SVGTSpanElement", "SVGTextPositioningElement");

  • trunk/Source/WebCore/ChangeLog

    r251762 r251764  
     12019-10-29  Said Abou-Hallawa  <sabouhallawa@apple.com>
     2
     3        [SVG2] SVGSymbolElement should inherits SVGGraphicsElement
     4        https://bugs.webkit.org/show_bug.cgi?id=203573
     5
     6        Reviewed by Simon Fraser.
     7
     8        The spec link is:
     9            https://www.w3.org/TR/SVG2/struct.html#InterfaceSVGSymbolElement
     10
     11        * svg/SVGSymbolElement.cpp:
     12        (WebCore::SVGSymbolElement::SVGSymbolElement):
     13        (WebCore::SVGSymbolElement::parseAttribute):
     14        * svg/SVGSymbolElement.h:
     15        * svg/SVGSymbolElement.idl:
     16
    1172019-10-29  Jiewen Tan  <jiewen_tan@apple.com>
    218

  • trunk/Source/WebCore/svg/SVGSymbolElement.cpp

    r251318 r251764  
    3333
    3434inline SVGSymbolElement::SVGSymbolElement(const QualifiedName& tagName, Document& document)
    35     : SVGElement(tagName, document)
     35    : SVGGraphicsElement(tagName, document)
    3636    , SVGFitToViewBox(this)
    3737{
    … …  
    4646void SVGSymbolElement::parseAttribute(const QualifiedName& name, const AtomString& value)
    4747{
    48     SVGElement::parseAttribute(name, value);
     48    SVGGraphicsElement::parseAttribute(name, value);
    4949    SVGFitToViewBox::parseAttribute(name, value);
    5050}

  • trunk/Source/WebCore/svg/SVGSymbolElement.h

    r251318 r251764  
    2222#pragma once
    2323
    24 #include "SVGElement.h"
    2524#include "SVGFitToViewBox.h"
     25#include "SVGGraphicsElement.h"
    2626
    2727namespace WebCore {
    2828
    29 class SVGSymbolElement final : public SVGElement, public SVGFitToViewBox {
     29class SVGSymbolElement final : public SVGGraphicsElement, public SVGFitToViewBox {
    3030    WTF_MAKE_ISO_ALLOCATED(SVGSymbolElement);
    3131public:
    … …  
    3535    SVGSymbolElement(const QualifiedName&, Document&);
    3636
    37     using PropertyRegistry = SVGPropertyOwnerRegistry<SVGSymbolElement, SVGElement, SVGFitToViewBox>;
     37    using PropertyRegistry = SVGPropertyOwnerRegistry<SVGSymbolElement, SVGGraphicsElement, SVGFitToViewBox>;
    3838    const SVGPropertyRegistry& propertyRegistry() const final { return m_propertyRegistry; }
    3939

  • trunk/Source/WebCore/svg/SVGSymbolElement.idl

    r251318 r251764  
    2424 */
    2525
    26 interface SVGSymbolElement : SVGElement {
     26interface SVGSymbolElement : SVGGraphicsElement {
    2727};
    2828
Note: See TracChangeset for help on using the changeset viewer.