Changeset 251773 in webkit


Ignore:
Timestamp:
Oct 30, 2019 7:18:07 AM (4 years ago)
Author:
Megan Gardner
Message:

Fix autoscroll test to work on iPad.
https://bugs.webkit.org/show_bug.cgi?id=203598
<rdar://problem/51863703>

Reviewed by Wenson Hsieh.

iPads are much taller than iPhones, so to test autoscrolling under a
software keyboard, we need to return several more times.
Also take the opportunity to make the test more robust to races.

  • fast/events/autoscroll-with-software-keyboard.html:
  • platform/ipad/TestExpectations:
Location:
trunk/LayoutTests
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r251770 r251773  
     12019-10-30  Megan Gardner  <megan_gardner@apple.com>
     2
     3        Fix autoscroll test to work on iPad.
     4        https://bugs.webkit.org/show_bug.cgi?id=203598
     5        <rdar://problem/51863703>
     6
     7        Reviewed by Wenson Hsieh.
     8
     9        iPads are much taller than iPhones, so to test autoscrolling under a
     10        software keyboard, we need to return several more times.
     11        Also take the opportunity to make the test more robust to races.
     12
     13        * fast/events/autoscroll-with-software-keyboard.html:
     14        * platform/ipad/TestExpectations:
     15
    1162019-10-30  Frederic Wang  <fwang@igalia.com>
    217
  • trunk/LayoutTests/fast/events/autoscroll-with-software-keyboard.html

    r244141 r251773  
    1616   
    1717        var output = '';
    18         var firstTargetRect = document.getElementById('editable').getBoundingClientRect();
    19    
    20         var pressPointX = firstTargetRect.x;
    21         var pressPointY = firstTargetRect.y;
    2218
    23    
    24         await tapAtPoint(pressPointX,pressPointY);
    25         await UIHelper.enterText("\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\nTest");
     19        await UIHelper.activateElementAndWaitForInputSession(document.getElementById('editable'));
     20        await UIHelper.enterText("\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\nTest");
    2621
    2722        var firstPageOffset = window.pageYOffset;
     
    3227        output += '<br>';
    3328
    34         await UIHelper.enterText("\n\n\n\n\n\n\n\n\n\n\n\n\n\nTest");
     29        await UIHelper.enterText("\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\nTest");
    3530        if (window.pageYOffset > 0 && window.pageYOffset > firstPageOffset)
    3631            output += 'PASS: page has continuted to scroll when caret is beyond the edge of the screen.';
  • trunk/LayoutTests/platform/ipad/TestExpectations

    r251449 r251773  
    4141webkit.org/b/194259 fast/events/ios/viewport-no-width-value-allows-double-tap.html [ Skip ]
    4242
    43 # <rdar://problem/51863703> [ iPad Sim ] New Layout test fast/events/autoscroll-with-software-keyboard.html is failing on iOS 13 iPad Simulator testers
    44 fast/events/autoscroll-with-software-keyboard.html [ Failure ]
    45 
    4643# This tests an iphone-specific behavior so is expected to fail on iPad.
    4744fast/scrolling/ios/overflow-scrolling-touch-enabled-stacking.html [ ImageOnlyFailure ]
Note: See TracChangeset for help on using the changeset viewer.