Changeset 251820 in webkit

Timestamp:

Oct 30, 2019 4:29:22 PM (4 years ago)

Author:

Chris Dumez

Message:

GPUCanvasContext should not prevent entering the back/forward cache
​https://bugs.webkit.org/show_bug.cgi?id=203104
<rdar://problem/56748066>

Reviewed by Tim Horton.

Source/WebCore:

Let pages with a GPUCanvasContext into the back/forward cache. The current implementation
does not run any script.

Test: fast/history/page-cache-gpu-canvas-context.html

• Modules/webgpu/GPUCanvasContext.h:

LayoutTests:

Add layout test coverage.

• fast/history/page-cache-gpu-canvas-context-expected.txt: Added.
• fast/history/page-cache-gpu-canvas-context.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/history/page-cache-gpu-canvas-context-expected.txt (added)
• LayoutTests/fast/history/page-cache-gpu-canvas-context.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/Modules/webgpu/GPUCanvasContext.h (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-10-30  Chris Dumez  <cdumez@apple.com>
+
+        GPUCanvasContext should not prevent entering the back/forward cache
+        https://bugs.webkit.org/show_bug.cgi?id=203104
+        <rdar://problem/56748066>
+
+        Reviewed by Tim Horton.
+
+        Add layout test coverage.
+
+        * fast/history/page-cache-gpu-canvas-context-expected.txt: Added.
+        * fast/history/page-cache-gpu-canvas-context.html: Added.
+
 2019-10-30  Yury Semikhatsky  <yurys@chromium.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-10-30  Chris Dumez  <cdumez@apple.com>
+
+        GPUCanvasContext should not prevent entering the back/forward cache
+        https://bugs.webkit.org/show_bug.cgi?id=203104
+        <rdar://problem/56748066>
+
+        Reviewed by Tim Horton.
+
+        Let pages with a GPUCanvasContext into the back/forward cache. The current implementation
+        does not run any script.
+
+        Test: fast/history/page-cache-gpu-canvas-context.html
+
+        * Modules/webgpu/GPUCanvasContext.h:
+
 2019-10-30  Daniel Bates  <dabates@apple.com>
 

trunk/Source/WebCore/Modules/webgpu/GPUCanvasContext.h

@@ -47 +47 @@
     Ref<WebGPUSwapChain> configureSwapChain(const WebGPUSwapChainDescriptor&);
 
-    // FIXME: Stubs.
-    bool hasPendingActivity() const final { return false; }
-
 private:
     GPUCanvasContext(CanvasBase&);
@@ -58 +55 @@
     void reshape(int width, int height) final;
     void markLayerComposited() final;
+
+    // ActiveDOMObject.
     const char* activeDOMObjectName() const final { return "GPUCanvasContext"; }
     // FIXME: Stubs.
     void stop() final { }
-    bool shouldPreventEnteringBackForwardCache_DEPRECATED() const final { return true; } // FIXME: This should never prevent entering the back/forward cache.
 
     RefPtr<WebGPUSwapChain> m_swapChain;