Changeset 251827 in webkit

Timestamp:

Oct 30, 2019 6:41:11 PM (4 years ago)

Author:

jer.noble@apple.com

Message:

Add fullscreen style quirk for reddit.com
​https://bugs.webkit.org/show_bug.cgi?id=203635
<rdar://problem/55813774>

Reviewed by Eric Carlson.

Reddit.com expects the UA stylesheet to give the fullscreen element
a "width:100%; height:100%;" style.

• css/CSSDefaultStyleSheets.cpp:

(WebCore::CSSDefaultStyleSheets::ensureDefaultStyleSheetsForElement):

• page/Quirks.cpp:

(WebCore::Quirks::needsFullWidthHeightFullscreenStyleQuirk const):

• page/Quirks.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• css/CSSDefaultStyleSheets.cpp (modified) (2 diffs)
• page/Quirks.cpp (modified) (1 diff)
• page/Quirks.h (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-10-30  Jer Noble  <jer.noble@apple.com>
+
+        Add fullscreen style quirk for reddit.com
+        https://bugs.webkit.org/show_bug.cgi?id=203635
+        <rdar://problem/55813774>
+
+        Reviewed by Eric Carlson.
+
+        Reddit.com expects the UA stylesheet to give the fullscreen element
+        a "width:100%; height:100%;" style.
+
+        * css/CSSDefaultStyleSheets.cpp:
+        (WebCore::CSSDefaultStyleSheets::ensureDefaultStyleSheetsForElement):
+        * page/Quirks.cpp:
+        (WebCore::Quirks::needsFullWidthHeightFullscreenStyleQuirk const):
+        * page/Quirks.h:
+
 2019-10-30  Yusuke Suzuki  <ysuzuki@apple.com>
 

trunk/Source/WebCore/css/CSSDefaultStyleSheets.cpp

@@ -48 +48 @@
 #include "MediaQueryEvaluator.h"
 #include "Page.h"
+#include "Quirks.h"
 #include "RenderTheme.h"
 #include "RuleSet.h"
@@ -278 +279 @@
 #if ENABLE(FULLSCREEN_API)
     if (!fullscreenStyleSheet && element.document().fullscreenManager().isFullscreen()) {
-        String fullscreenRules = String(fullscreenUserAgentStyleSheet, sizeof(fullscreenUserAgentStyleSheet)) + RenderTheme::singleton().extraFullScreenStyleSheet();
-        fullscreenStyleSheet = parseUASheet(fullscreenRules);
+        StringBuilder fullscreenRules;
+        fullscreenRules.appendCharacters(fullscreenUserAgentStyleSheet, sizeof(fullscreenUserAgentStyleSheet));
+        fullscreenRules.append(RenderTheme::singleton().extraFullScreenStyleSheet());
+        if (element.document().quirks().needsFullWidthHeightFullscreenStyleQuirk())
+            fullscreenRules.append(":-webkit-full-screen { width:100%; height:100%; }");
+        fullscreenStyleSheet = parseUASheet(fullscreenRules.toString());
         addToDefaultStyle(*fullscreenStyleSheet);
     }

trunk/Source/WebCore/page/Quirks.cpp

@@ -595 +595 @@
 }
 
-}
+bool Quirks::needsFullWidthHeightFullscreenStyleQuirk() const
+{
+    if (!needsQuirks())
+        return false;
+
+    if (m_needsFullWidthHeightFullscreenStyleQuirk)
+        return m_needsFullWidthHeightFullscreenStyleQuirk.value();
+
+    auto domain = m_document->securityOrigin().domain().convertToASCIILowercase();
+
+    m_needsFullWidthHeightFullscreenStyleQuirk = domain == "reddit.com" || domain.endsWith(".reddit.com");
+
+    return m_needsFullWidthHeightFullscreenStyleQuirk.value();
+}
+
+}

trunk/Source/WebCore/page/Quirks.h

@@ -81 +81 @@
 
     bool needsPreloadAutoQuirk() const;
+    bool needsFullWidthHeightFullscreenStyleQuirk() const;
 
 private:
@@ -93 +94 @@
 
     mutable Optional<bool> m_hasBrokenEncryptedMediaAPISupportQuirk;
+    mutable Optional<bool> m_needsFullWidthHeightFullscreenStyleQuirk;
 #if PLATFORM(IOS_FAMILY)
     mutable Optional<bool> m_needsGMailOverflowScrollQuirk;