Changeset 251832 in webkit


Ignore:
Timestamp:
Oct 30, 2019 8:47:34 PM (4 years ago)
Author:
Devin Rousso
Message:

Web Inspector: Timelines: ResizeObserver callbacks are not labeled in the Events timeline
https://bugs.webkit.org/show_bug.cgi?id=203634
<rdar://problem/56760736>

Reviewed by Simon Fraser.

Wrap the ResizeObserver event handler in two InspectorInstrumentation calls so the
frontend knows how to properly label the callbacks.

  • page/ResizeObserver.cpp:

(WebCore::ResizeObserver::deliverObservations):

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r251831 r251832  
     12019-10-30  Devin Rousso  <drousso@apple.com>
     2
     3        Web Inspector: Timelines: ResizeObserver callbacks are not labeled in the Events timeline
     4        https://bugs.webkit.org/show_bug.cgi?id=203634
     5        <rdar://problem/56760736>
     6
     7        Reviewed by Simon Fraser.
     8
     9        Wrap the `ResizeObserver` event handler in two `InspectorInstrumentation` calls so the
     10        frontend knows how to properly label the callbacks.
     11
     12        * page/ResizeObserver.cpp:
     13        (WebCore::ResizeObserver::deliverObservations):
     14
    1152019-10-30  Alex Christensen  <achristensen@webkit.org>
    216
  • trunk/Source/WebCore/page/ResizeObserver.cpp

    r251244 r251832  
    3030
    3131#include "Element.h"
     32#include "InspectorInstrumentation.h"
    3233#include "ResizeObserverEntry.h"
    3334
     
    123124    }
    124125    m_activeObservations.clear();
     126
     127    auto* context = m_callback->scriptExecutionContext();
     128    if (!context)
     129        return;
     130
     131    InspectorInstrumentation::willFireObserverCallback(*context, "ResizeObserver"_s);
    125132    m_callback->handleEvent(entries, *this);
     133    InspectorInstrumentation::didFireObserverCallback(*context);
    126134}
    127135
Note: See TracChangeset for help on using the changeset viewer.