Changeset 251833 in webkit

Timestamp:

Oct 30, 2019 9:54:46 PM (4 years ago)

Author:

yurys@chromium.org

Message:

inspector-protocol/debugger/setBreakpoint-dfg.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=128736

Reviewed by Devin Rousso.

Reenabling the test on all platforms. Depending on the platform implementation of EventLoop
there is a difference in what is dispatched first when execution is resumed: previously
paused inspected script or commands from the inspector front-end. It would not be a problem
if InspectorFrontendAPI.dispatchMessageAsync actually delivered messages asynchronously.
With the current implementation though response to Debugger.resume
is dispatched in the front-end synchronously and the front-end would call InspectoTest.log
when inspected script execution is not yet resumed.

• TestExpectations:
• inspector/debugger/setBreakpoint-dfg-expected.txt:
• inspector/debugger/setBreakpoint-dfg.html: Print final 'PASS' output after exiting nested loop

so that it always appears last.

• platform/gtk/TestExpectations:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• TestExpectations (modified) (1 diff)
• inspector/debugger/setBreakpoint-dfg-expected.txt (modified) (1 diff)
• inspector/debugger/setBreakpoint-dfg.html (modified) (1 diff)
• platform/gtk/TestExpectations (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-10-30  Yury Semikhatsky  <yurys@chromium.org>
+
+        inspector-protocol/debugger/setBreakpoint-dfg.html is flaky
+        https://bugs.webkit.org/show_bug.cgi?id=128736
+
+        Reviewed by Devin Rousso.
+
+        Reenabling the test on all platforms. Depending on the platform implementation of EventLoop
+        there is a difference in what is dispatched first when execution is resumed: previously
+        paused inspected script or commands from the inspector front-end. It would not be a problem
+        if InspectorFrontendAPI.dispatchMessageAsync actually delivered messages asynchronously.
+        With the current implementation though response to Debugger.resume
+        is dispatched in the front-end synchronously and the front-end would call InspectoTest.log
+        when inspected script execution is not yet resumed.
+
+        * TestExpectations:
+        * inspector/debugger/setBreakpoint-dfg-expected.txt:
+        * inspector/debugger/setBreakpoint-dfg.html: Print final 'PASS' output after exiting nested loop
+        so that it always appears last.
+        * platform/gtk/TestExpectations:
+
 2019-10-30  Simon Fraser  <simon.fraser@apple.com>
 

trunk/LayoutTests/TestExpectations

@@ -925 +925 @@
 webkit.org/b/129639 inspector/dom/dom-search-crash.html [ Skip ]
 
-webkit.org/b/128736 inspector/debugger/setBreakpoint-dfg.html [ Failure Pass ]
 webkit.org/b/134982 inspector/debugger/setBreakpoint-dfg-and-modify-local.html [ Failure Pass ]
 

trunk/LayoutTests/inspector/debugger/setBreakpoint-dfg-expected.txt

@@ -14 +14 @@
 Hit Breakpoint 2!
 Removed Breakpoint 2!
+dfgWithInline result: 504500
 PASS
-dfgWithInline result: 504500
 

trunk/LayoutTests/inspector/debugger/setBreakpoint-dfg.html

@@ -70 +70 @@
         InspectorProtocol.sendCommand("Debugger.removeBreakpoint", {"breakpointId": breakpointId}, function(responseObject) {
             ProtocolTest.log("Removed Breakpoint " + breakpointsHit + "!");
-            InspectorProtocol.sendCommand("Debugger.resume", {}, function(responseObject) {
-                if (breakpointsHit == 2) {
-                    ProtocolTest.log("PASS");
-                    ProtocolTest.completeTest();
-                }
-            });
+            InspectorProtocol.sendCommand("Debugger.resume");
         });
+    }
+    InspectorProtocol.eventHandler["Debugger.resumed"] = function(messageObject)
+    {
+        if (breakpointsHit < 2)
+           return;
+        ProtocolTest.assert(breakpointsHit == 2);
+        ProtocolTest.log("PASS");
+        ProtocolTest.completeTest();
     }
 }

trunk/LayoutTests/platform/gtk/TestExpectations

@@ -1640 +1640 @@
 webkit.org/b/131545 media/media-event-listeners.html [ Failure Pass ]
 
-webkit.org/b/139364 inspector/debugger/setBreakpoint-dfg.html [ Failure Pass Timeout ]
 webkit.org/b/143876 css3/viewport-percentage-lengths/vh-resize.html [ ImageOnlyFailure Pass ]