Changeset 251837 in webkit

Timestamp:

Oct 31, 2019 2:31:14 AM (4 years ago)

Author:

magomez@igalia.com

Message:

[CoordGraphics] Avoid painting backing stores for zero-opacity layers
​https://bugs.webkit.org/show_bug.cgi?id=184143

Reviewed by Žan Doberšek.

Source/WebCore:

Skip generating backing stores for layers that have zero opacity and do
not animate the opacity value. In the current CoordinatedGraphics system
this can end up saving loads of memory on Web content that deploys a
large number of such elements.

Based on a previous patch from Žan Doberšek.

• platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::shouldHaveBackingStore const):

Source/WebKit:

Do not check whether a backingStore is required by a layer inside CoordinatedGraphicsScene. This
decision is made by the appropriate CoordinatedGraphicsLayer and propagated to the scene by
sending a valid or null Nicosia::BackingStore instance through the state.

• Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:

(WebKit::updateBackingStore):
(WebKit::layerShouldHaveBackingStore): Deleted.

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp (modified) (1 diff)
• WebKit/ChangeLog (modified) (1 diff)
• WebKit/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-10-31  Miguel Gomez  <magomez@igalia.com>
+
+        [CoordGraphics] Avoid painting backing stores for zero-opacity layers
+        https://bugs.webkit.org/show_bug.cgi?id=184143
+
+        Reviewed by Žan Doberšek.
+
+        Skip generating backing stores for layers that have zero opacity and do
+        not animate the opacity value. In the current CoordinatedGraphics system
+        this can end up saving loads of memory on Web content that deploys a
+        large number of such elements.
+
+        Based on a previous patch from Žan Doberšek.
+
+        * platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
+        (WebCore::CoordinatedGraphicsLayer::shouldHaveBackingStore const):
+
 2019-10-29  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp

@@ -1240 +1240 @@
 bool CoordinatedGraphicsLayer::shouldHaveBackingStore() const
 {
-    return drawsContent() && contentsAreVisible() && !m_size.isEmpty();
+    return drawsContent() && contentsAreVisible() && !m_size.isEmpty()
+        && (!!opacity() || m_animations.hasActiveAnimationsOfType(AnimatedPropertyOpacity));
 }
 

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-10-31  Miguel Gomez  <magomez@igalia.com>
+
+        [CoordGraphics] Avoid painting backing stores for zero-opacity layers
+        https://bugs.webkit.org/show_bug.cgi?id=184143
+
+        Reviewed by Žan Doberšek.
+
+        Do not check whether a backingStore is required by a layer inside CoordinatedGraphicsScene. This
+        decision is made by the appropriate CoordinatedGraphicsLayer and propagated to the scene by
+        sending a valid or null Nicosia::BackingStore instance through the state.
+
+        * Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:
+        (WebKit::updateBackingStore):
+        (WebKit::layerShouldHaveBackingStore): Deleted.
+
 2019-10-30  Peng Liu  <peng.liu6@apple.com>
 

trunk/Source/WebKit/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp

@@ -41 +41 @@
 using namespace WebCore;
 
-static bool layerShouldHaveBackingStore(TextureMapperLayer* layer)
-{
-    return layer->drawsContent() && layer->contentsAreVisible() && !layer->size().isEmpty();
-}
-
 CoordinatedGraphicsScene::CoordinatedGraphicsScene(CoordinatedGraphicsSceneClient* client)
     : m_client(client)
@@ -136 +131 @@
     const Nicosia::BackingStoreTextureMapperImpl::TileUpdate& update)
 {
-    if (!layerShouldHaveBackingStore(&layer)) {
-        layer.setBackingStore(nullptr);
-        compositionState.backingStore = nullptr;
-        return;
-    }
-
     if (!compositionState.backingStore)
         compositionState.backingStore = CoordinatedBackingStore::create();