Changeset 251838 in webkit

Timestamp:

Oct 31, 2019 5:01:11 AM (4 years ago)

Author:

magomez@igalia.com

Message:

Unreviewed, rolling out r251772.

Caused lots of media related tests to timeout

Reverted changeset:

"REGRESSION(r249428): [GStreamer] VP9 video rendered green"
​https://bugs.webkit.org/show_bug.cgi?id=201422
​https://trac.webkit.org/changeset/251772

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-10-31  Miguel Gomez  <magomez@igalia.com>
+
+        Unreviewed, rolling out r251772.
+
+        Caused lots of media related tests to timeout
+
+        Reverted changeset:
+
+        "REGRESSION(r249428): [GStreamer] VP9 video rendered green"
+        https://bugs.webkit.org/show_bug.cgi?id=201422
+        https://trac.webkit.org/changeset/251772
+
 2019-10-31  Miguel Gomez  <magomez@igalia.com>
 

trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp

@@ -1202 +1202 @@
 
     GRefPtr<GstCaps> caps = adoptGRef(gst_caps_from_string("video/x-raw, format = (string) " GST_GL_CAPS_FORMAT));
-    GstCapsFeatures* features = gst_caps_features_new(GST_CAPS_FEATURE_MEMORY_GL_MEMORY, nullptr);
-
-    // Workaround until we can depend on GStreamer 1.16.2.
-    // https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/commit/8d32de090554cf29fe359f83aa46000ba658a693
-    // Adding the texture upload meta here allows glupload to add video meta to
-    // the buffers, without needing the patch above. However this specific caps
-    // feature is going to be removed from GStreamer so it is considered a
-    // short-term workaround.
-    // See also https://bugs.webkit.org/show_bug.cgi?id=201422
-    if (!webkitGstCheckVersion(1, 16, 2))
-        gst_caps_features_add(features, GST_CAPS_FEATURE_META_GST_VIDEO_GL_TEXTURE_UPLOAD_META);
-
-    gst_caps_set_features(caps.get(), 0, features);
+    gst_caps_set_features(caps.get(), 0, gst_caps_features_new(GST_CAPS_FEATURE_MEMORY_GL_MEMORY, nullptr));
     g_object_set(appsink, "caps", caps.get(), nullptr);