Changeset 251849 in webkit

Timestamp:

Oct 31, 2019 8:42:49 AM (4 years ago)

Author:

aakash_jain@apple.com

Message:

[EWS] Limit API tests failures to display in the status-bubble tooltip and buildbot summary
​https://bugs.webkit.org/show_bug.cgi?id=203678

Reviewed by Jonathan Bedard.

• BuildSlaveSupport/ews-build/steps.py:

(AnalyzeAPITestsResults): Define NUM_API_FAILURES_TO_DISPLAY as 10.
(AnalyzeAPITestsResults.analyzeResults): Truncate the failure string to contain 10 test failures.

Location:

trunk/Tools

Files:

• BuildSlaveSupport/ews-build/steps.py (modified) (3 diffs)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/ews-build/steps.py

@@ -1452 +1452 @@
     description = ['analyze-api-test-results']
     descriptionDone = ['analyze-api-tests-results']
+    NUM_API_FAILURES_TO_DISPLAY = 10
 
     def start(self):
@@ -1493 +1494 @@
         flaky_failures_string = ', '.join([failure_name.replace('TestWebKitAPI.', '') for failure_name in flaky_failures])
         new_failures = failures_with_patch - clean_tree_failures
-        new_failures_string = ', '.join([failure_name.replace('TestWebKitAPI.', '') for failure_name in new_failures])
+        new_failures_to_display = list(new_failures)[:self.NUM_API_FAILURES_TO_DISPLAY]
+        new_failures_string = ', '.join([failure_name.replace('TestWebKitAPI.', '') for failure_name in new_failures_to_display])
 
         self._addToLog('stderr', '\nFailures in API Test first run: {}'.format(first_run_failures))
@@ -1506 +1508 @@
             pluralSuffix = 's' if len(new_failures) > 1 else ''
             message = 'Found {} new API test failure{}: {}'.format(len(new_failures), pluralSuffix, new_failures_string)
+            if len(new_failures) > self.NUM_API_FAILURES_TO_DISPLAY:
+                message += ' ...'
             self.descriptionDone = message
             self.build.buildFinished([message], FAILURE)

trunk/Tools/ChangeLog

@@ +1 @@
+2019-10-31  Aakash Jain  <aakash_jain@apple.com>
+
+        [EWS] Limit API tests failures to display in the status-bubble tooltip and buildbot summary
+        https://bugs.webkit.org/show_bug.cgi?id=203678
+
+        Reviewed by Jonathan Bedard.
+
+        * BuildSlaveSupport/ews-build/steps.py:
+        (AnalyzeAPITestsResults): Define NUM_API_FAILURES_TO_DISPLAY as 10.
+        (AnalyzeAPITestsResults.analyzeResults): Truncate the failure string to contain 10 test failures.
+
 2019-10-30  Peng Liu  <peng.liu6@apple.com>