Changeset 251869 in webkit

Timestamp:

Oct 31, 2019 12:56:34 PM (4 years ago)

Author:

aakash_jain@apple.com

Message:

[ews-build] Display pre-existing API test names in the build summary
​https://bugs.webkit.org/show_bug.cgi?id=199525

Reviewed by Jonathan Bedard.

• BuildSlaveSupport/ews-build/steps.py:

(AnalyzeAPITestsResults.analyzeResults): Include the names of pre-existing test failures in summary string and
limit the number of failures to display to NUM_API_FAILURES_TO_DISPLAY.

Location:

trunk/Tools

Files:

• BuildSlaveSupport/ews-build/steps.py (modified) (2 diffs)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/ews-build/steps.py

@@ -1489 +1489 @@
         second_run_failures = getAPITestFailures(second_run_results)
         clean_tree_failures = getAPITestFailures(clean_tree_results)
+        clean_tree_failures_to_display = list(clean_tree_failures)[:self.NUM_API_FAILURES_TO_DISPLAY]
+        clean_tree_failures_string = ', '.join(clean_tree_failures_to_display)
 
         failures_with_patch = first_run_failures.intersection(second_run_failures)
@@ -1518 +1520 @@
             self.descriptionDone = 'Passed API tests'
             pluralSuffix = 's' if len(clean_tree_failures) > 1 else ''
-            message = 'Found {} pre-existing API test failure{}'.format(len(clean_tree_failures), pluralSuffix)
+            message = 'Found {} pre-existing API test failure{}: {}'.format(len(clean_tree_failures), pluralSuffix, clean_tree_failures_string)
+            if len(clean_tree_failures) > self.NUM_API_FAILURES_TO_DISPLAY:
+                message += ' ...'
             if flaky_failures:
                 message += '. Flaky tests: {}'.format(flaky_failures_string)

trunk/Tools/ChangeLog

@@ +1 @@
+2019-10-31  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews-build] Display pre-existing API test names in the build summary
+        https://bugs.webkit.org/show_bug.cgi?id=199525
+
+        Reviewed by Jonathan Bedard.
+
+        * BuildSlaveSupport/ews-build/steps.py:
+        (AnalyzeAPITestsResults.analyzeResults): Include the names of pre-existing test failures in summary string and 
+        limit the number of failures to display to NUM_API_FAILURES_TO_DISPLAY.
+
 2019-10-31  Alex Christensen  <achristensen@webkit.org>