Changeset 251919 in webkit


Ignore:
Timestamp:
Nov 1, 2019 8:53:02 AM (4 years ago)
Author:
Devin Rousso
Message:

Web Inspector: Settings: Blackbox: hide icon is missing
https://bugs.webkit.org/show_bug.cgi?id=203727

Reviewed by Timothy Hatcher.

  • UserInterface/Images/Hide.svg:

WI.ImageUtilities.useSVGSymbol links directly to a specific part of the SVG resource based
on an id attribute (default to #root if not otherwise given). As a result, any <style>
that are not a child of that specific part won't be included, meaning that any CSS variables
used for controlling colors won't exist. Adding a fallback value to the var() for these
cases allows a specific part to be used without needing any surrounding styles.

  • UserInterface/Views/BlackboxSettingsView.css:

(.settings-view.blackbox > p > .toggle-script-blackbox):
Slightly adjust the size and vertical alignment to better match the surrounding text.

Location:
trunk/Source/WebInspectorUI
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebInspectorUI/ChangeLog

    r251918 r251919  
     12019-11-01  Devin Rousso  <drousso@apple.com>
     2
     3        Web Inspector: Settings: Blackbox: hide icon is missing
     4        https://bugs.webkit.org/show_bug.cgi?id=203727
     5
     6        Reviewed by Timothy Hatcher.
     7
     8        * UserInterface/Images/Hide.svg:
     9        `WI.ImageUtilities.useSVGSymbol` links directly to a specific part of the SVG resource based
     10        on an `id` attribute (default to `#root` if not otherwise given). As a result, any `<style>`
     11        that are not a child of that specific part won't be included, meaning that any CSS variables
     12        used for controlling colors won't exist. Adding a fallback value to the `var()` for these
     13        cases allows a specific part to be used without needing any surrounding styles.
     14
     15        * UserInterface/Views/BlackboxSettingsView.css:
     16        (.settings-view.blackbox > p > .toggle-script-blackbox):
     17        Slightly adjust the size and vertical alignment to better match the surrounding text.
     18
    1192019-11-01  Devin Rousso  <drousso@apple.com>
    220
  • trunk/Source/WebInspectorUI/UserInterface/Images/Hide.svg

    r251039 r251919  
    2626    <svg>
    2727        <symbol id="content">
    28             <path fill="none" stroke="var(--color)" d="M 7.942 8.124 C 6.53 8.124 5.385 6.95 5.385 5.499 C 5.385 4.05 6.53 2.875 7.942 2.875 C 9.355 2.875 10.5 4.05 10.5 5.499 C 10.5 6.95 9.355 8.124 7.942 8.124 M 7.942 1.0 C 3.923 1.0 1.001 5.499 1.001 5.499 C 1.001 5.499 3.923 9.999 7.942 9.999 C 11.962 9.999 14.884 5.499 14.884 5.499 C 14.884 5.499 11.962 1.0 7.942 1.0"/>
    29             <path fill="var(--color)" d="M 7.942 4.375 C 7.337 4.375 6.846 4.878 6.846 5.5 C 6.846 6.121 7.337 6.625 7.942 6.625 C 8.548 6.625 9.038 6.121 9.038 5.5 C 9.038 4.878 8.548 4.375 7.942 4.375"/>
    30             <path stroke="var(--color)" d="M 15.5 2 L 0.5 9"></path>
     28            <path fill="none" stroke="var(--color, currentColor)" d="M 7.942 8.124 C 6.53 8.124 5.385 6.95 5.385 5.499 C 5.385 4.05 6.53 2.875 7.942 2.875 C 9.355 2.875 10.5 4.05 10.5 5.499 C 10.5 6.95 9.355 8.124 7.942 8.124 M 7.942 1.0 C 3.923 1.0 1.001 5.499 1.001 5.499 C 1.001 5.499 3.923 9.999 7.942 9.999 C 11.962 9.999 14.884 5.499 14.884 5.499 C 14.884 5.499 11.962 1.0 7.942 1.0"/>
     29            <path fill="var(--color, currentColor)" d="M 7.942 4.375 C 7.337 4.375 6.846 4.878 6.846 5.5 C 6.846 6.121 7.337 6.625 7.942 6.625 C 8.548 6.625 9.038 6.121 9.038 5.5 C 9.038 4.878 8.548 4.375 7.942 4.375"/>
     30            <path stroke="var(--color, currentColor)" d="M 15.5 2 L 0.5 9"></path>
    3131        </symbol>
    3232    </svg>
  • trunk/Source/WebInspectorUI/UserInterface/Views/BlackboxSettingsView.css

    r251039 r251919  
    4444.settings-view.blackbox > p > .toggle-script-blackbox {
    4545    display: inline-block;
    46     width: 15px;
    47     height: 15px;
    48     vertical-align: bottom;
     46    width: 16px;
     47    height: 16px;
     48    vertical-align: middle;
    4949}
    5050
Note: See TracChangeset for help on using the changeset viewer.