Changeset 251938 in webkit

Timestamp:

Nov 1, 2019 1:55:24 PM (4 years ago)

Author:

aakash_jain@apple.com

Message:

[ews] Improve summary string when there are flaky failures in API tests
​https://bugs.webkit.org/show_bug.cgi?id=203747

Reviewed by Jonathan Bedard.

• BuildSlaveSupport/ews-build/steps.py:

(AnalyzeAPITestsResults.analyzeResults): Display pre-existing failure string string only
if there are pre-existing API test failures.

Location:

trunk/Tools

Files:

• BuildSlaveSupport/ews-build/steps.py (modified) (1 diff)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/ews-build/steps.py

@@ -1521 +1521 @@
             self.descriptionDone = 'Passed API tests'
             pluralSuffix = 's' if len(clean_tree_failures) > 1 else ''
-            message = 'Found {} pre-existing API test failure{}: {}'.format(len(clean_tree_failures), pluralSuffix, clean_tree_failures_string)
+            message = ''
+            if clean_tree_failures:
+                message = 'Found {} pre-existing API test failure{}: {}'.format(len(clean_tree_failures), pluralSuffix, clean_tree_failures_string)
             if len(clean_tree_failures) > self.NUM_API_FAILURES_TO_DISPLAY:
                 message += ' ...'
             if flaky_failures:
-                message += '. Flaky tests: {}'.format(flaky_failures_string)
+                message += ' Found flaky tests: {}'.format(flaky_failures_string)
             self.build.buildFinished([message], SUCCESS)
 

trunk/Tools/ChangeLog

@@ +1 @@
+2019-11-01  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews] Improve summary string when there are flaky failures in API tests
+        https://bugs.webkit.org/show_bug.cgi?id=203747
+
+        Reviewed by Jonathan Bedard.
+
+        * BuildSlaveSupport/ews-build/steps.py:
+        (AnalyzeAPITestsResults.analyzeResults): Display pre-existing failure string string only
+        if there are pre-existing API test failures.
+
 2019-11-01  Wenson Hsieh  <wenson_hsieh@apple.com>