Changeset 251944 in webkit

Timestamp:

Nov 1, 2019 2:39:03 PM (4 years ago)

Author:

rniwa@webkit.org

Message:

macOS WK1: requestidlecallback/requestidlecallback-document-gc.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=203758

Reviewed by Wenson Hsieh.

Fix the test by delaying the check until the next run loop via setTimeout.
This is needed to make GC work reliably in WK1.

• requestidlecallback/requestidlecallback-document-gc.html:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• requestidlecallback/requestidlecallback-document-gc.html (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-11-01  Ryosuke Niwa  <rniwa@webkit.org>
+
+        macOS WK1: requestidlecallback/requestidlecallback-document-gc.html is flaky
+        https://bugs.webkit.org/show_bug.cgi?id=203758
+
+        Reviewed by Wenson Hsieh.
+
+        Fix the test by delaying the check until the next run loop via setTimeout.
+        This is needed to make GC work reliably in WK1.
+
+        * requestidlecallback/requestidlecallback-document-gc.html:
+
 2019-11-01  Nikita Vasilyev  <nvasilyev@apple.com>
 

trunk/LayoutTests/requestidlecallback/requestidlecallback-document-gc.html

@@ -26 +26 @@
     }
     document.querySelectorAll('iframe').forEach((frame) => frame.remove());
-    GCController.collect();
-    shouldBeTrue('initialCount + frameCount / 2 > internals.numberOfLiveDocuments()');
-    finishJSTest();
+    setTimeout(() => {
+        GCController.collect();
+        shouldBeTrue('initialCount + frameCount / 2 > internals.numberOfLiveDocuments()');
+        finishJSTest();
+    }, 0);
 }