Changeset 251948 in webkit

Timestamp:

Nov 1, 2019 3:16:29 PM (4 years ago)

Author:

BJ Burg

Message:

REGRESSION(r248696): Element Click on Mac is adding an extra page topContentInsets to y-coordinate
​https://bugs.webkit.org/show_bug.cgi?id=203765
<rdar://problem/56014369>

Reviewed by Devin Rousso.

• UIProcess/Automation/mac/WebAutomationSessionMac.mm:

(WebKit::WebAutomationSession::platformSimulateMouseInteraction):
The topContentInsets is accounted for by rootViewToWindow(), so don't add it in manually.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/Automation/mac/WebAutomationSessionMac.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-11-01  Brian Burg  <bburg@apple.com>
+
+        REGRESSION(r248696): Element Click on Mac is adding an extra page topContentInsets to y-coordinate
+        https://bugs.webkit.org/show_bug.cgi?id=203765
+        <rdar://problem/56014369>
+
+        Reviewed by Devin Rousso.
+
+        * UIProcess/Automation/mac/WebAutomationSessionMac.mm:
+        (WebKit::WebAutomationSession::platformSimulateMouseInteraction):
+        The topContentInsets is accounted for by rootViewToWindow(), so don't add it in manually.
+
 2019-11-01  Per Arne Vollan  <pvollan@apple.com>
 

trunk/Source/WebKit/UIProcess/Automation/mac/WebAutomationSessionMac.mm

@@ -138 +138 @@
     IntRect windowRect;
 
-    IntPoint locationInView = WebCore::IntPoint(locationInViewport.x(), locationInViewport.y() + page.topContentInset());
+    IntPoint locationInView = WebCore::IntPoint(locationInViewport.x(), locationInViewport.y());
     page.rootViewToWindow(IntRect(locationInView, IntSize()), windowRect);
     IntPoint locationInWindow = windowRect.location();