Changeset 251973 in webkit
- Timestamp:
- Nov 3, 2019 7:10:28 AM (4 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r251972 r251973 1 2019-11-03 Zalan Bujtas <zalan@apple.com> 2 3 [LFC][IFC] Runs collapsed to zero advanced width are not always whitespace collapsed 4 https://bugs.webkit.org/show_bug.cgi?id=203778 5 <rdar://problem/56839642> 6 7 Reviewed by Antti Koivisto. 8 9 Just because a run collapses to zero advanced width, it does not necessarily mean it is a collapsed run (in whitespace collapsing sense) 10 e.g. trimmed trailing whitespace (m_collapsedToZeroAdvanceWidth should probably be renamed to something other than "collapsed" to avoid confusion). 11 12 * layout/inlineformatting/InlineLine.cpp: 13 (WebCore::Layout::Line::close): 14 (WebCore::Layout::Line::appendTextContent): 15 * layout/inlineformatting/InlineLine.h: 16 (WebCore::Layout::Line::Run::setCollapsesToZeroAdvanceWidth): 17 1 18 2019-11-03 Zalan Bujtas <zalan@apple.com> 2 19 -
trunk/Source/WebCore/layout/inlineformatting/InlineLine.cpp
r251917 r251973 159 159 return false; 160 160 // Visually empty runs are ignored. 161 if (currentRun->isCollapsedToZeroAdvanceWidth() )161 if (currentRun->isCollapsedToZeroAdvanceWidth() || previousRun->isCollapsedToZeroAdvanceWidth()) 162 162 return false; 163 163 return true; … … 464 464 if (collapsesToZeroAdvanceWidth) 465 465 lineRun->setCollapsesToZeroAdvanceWidth(); 466 elseif (collapsedRun)466 if (collapsedRun) 467 467 lineRun->setIsCollapsed(); 468 468 if (isTrimmable) -
trunk/Source/WebCore/layout/inlineformatting/InlineLine.h
r251917 r251973 183 183 inline void Line::Run::setCollapsesToZeroAdvanceWidth() 184 184 { 185 setIsCollapsed();186 185 m_collapsedToZeroAdvanceWidth = true; 187 186 m_displayRun.setLogicalWidth({ });
Note: See TracChangeset
for help on using the changeset viewer.