Changeset 251977 in webkit

Timestamp:

Nov 3, 2019 3:39:01 PM (4 years ago)

Author:

Alan Bujtas

Message:

[LFC][Verification] Forced line break display runs don't have TextContext
​https://bugs.webkit.org/show_bug.cgi?id=203779
<rdar://problem/56839710>

Reviewed by Antti Koivisto.

Display::Run's optional TextContext is not available for forced line breaks (since they are not text runs).

• layout/Verification.cpp:

(WebCore::Layout::checkForMatchingTextRuns):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• layout/Verification.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-11-03  Zalan Bujtas  <zalan@apple.com>
+
+        [LFC][Verification] Forced line break display runs don't have TextContext
+        https://bugs.webkit.org/show_bug.cgi?id=203779
+        <rdar://problem/56839710>
+
+        Reviewed by Antti Koivisto.
+
+        Display::Run's optional TextContext is not available for forced line breaks (since they are not text runs).
+
+        * layout/Verification.cpp:
+        (WebCore::Layout::checkForMatchingTextRuns):
+
 2019-11-03  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Source/WebCore/layout/Verification.cpp

@@ -126 +126 @@
         && areEssentiallyEqual(inlineTextBox.logicalTop(), inlineRun.logicalTop())
         && areEssentiallyEqual(inlineTextBox.logicalBottom(), inlineRun.logicalBottom())
-        && inlineTextBox.start() == inlineRun.textContext()->start()
-        && inlineTextBox.end() == inlineRun.textContext()->end();
+        && (inlineTextBox.isLineBreak() || (inlineTextBox.start() == inlineRun.textContext()->start() && inlineTextBox.end() == inlineRun.textContext()->end()));
 }