Changeset 252019 in webkit

Timestamp:

Nov 4, 2019 3:29:10 PM (4 years ago)

Author:

commit-queue@webkit.org

Message:

Set? isn't correct with respect to the spec and Proxy
​https://bugs.webkit.org/show_bug.cgi?id=155012

Patch by Alexey Shvayka <Alexey Shvayka> on 2019-11-04
Reviewed by Saam Barati.

This patch merely removes a FIXME comment, as JavaScriptCore has already correct
implementation of ordinary Set?. In step 2.b of ​https://tc39.es/ecma262/#sec-ordinarysetwithowndescriptor,
if parent is a Proxy, the algorithm returns result of Proxy's Set? method call.
It is up to the author of "set" trap (if any) to consult the prototype chain.

All browsers pass ​https://test262.report/browse/built-ins/Proxy/set/call-parameters-prototype.js,
which asserts that no traps besides "set" are invoked on Proxies in prototype chain during Set?.

• runtime/JSObject.cpp:

(JSC::JSObject::putInlineSlow):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• runtime/JSObject.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2019-11-04  Alexey Shvayka  <shvaikalesh@gmail.com>
+
+        [[Set]] isn't correct with respect to the spec and Proxy
+        https://bugs.webkit.org/show_bug.cgi?id=155012
+
+        Reviewed by Saam Barati.
+
+        This patch merely removes a FIXME comment, as JavaScriptCore has already correct
+        implementation of ordinary [[Set]]. In step 2.b of https://tc39.es/ecma262/#sec-ordinarysetwithowndescriptor,
+        if `parent` is a Proxy, the algorithm returns result of Proxy's [[Set]] method call.
+        It is up to the author of "set" trap (if any) to consult the prototype chain.
+
+        All browsers pass https://test262.report/browse/built-ins/Proxy/set/call-parameters-prototype.js,
+        which asserts that no traps besides "set" are invoked on Proxies in prototype chain during [[Set]].
+
+        * runtime/JSObject.cpp:
+        (JSC::JSObject::putInlineSlow):
+
 2019-11-04  Robin Morisset  <rmorisset@apple.com>
 

trunk/Source/JavaScriptCore/runtime/JSObject.cpp

@@ -839 +839 @@
         }
         if (obj->type() == ProxyObjectType) {
-            // FIXME: We shouldn't unconditionally perform [[Set]] here.
-            // We need to do more because this is observable behavior.
-            // https://bugs.webkit.org/show_bug.cgi?id=155012
             ProxyObject* proxy = jsCast<ProxyObject*>(obj);
             RELEASE_AND_RETURN(scope, proxy->ProxyObject::put(proxy, globalObject, propertyName, value, slot));