Changeset 252027 in webkit

Timestamp:

Nov 4, 2019 4:26:32 PM (4 years ago)

Author:

yurys@chromium.org

Message:

[GTK] Inspector protocol tests timing out on the bots
​https://bugs.webkit.org/show_bug.cgi?id=122571

Reviewed by Devin Rousso.

Mark more inspector tests as passing on GTK.

• inspector/dom/focus.html: Remove 'focus' event listener before closing dummy inspector

window. Otherwise it triggers a WebPage::setActivityState which in turn triggers focus
event on the page and on the focused element which results in two extra 'focus' lines printed.
To be clear this only avoids the extra text output that could be added to the output. Timeout
and crash problems must have been fixed before (likely by the recent changes in local inspector
client).

• platform/gtk/TestExpectations:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• inspector/dom/focus.html (modified) (2 diffs)
• platform/gtk/TestExpectations (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-11-04  Yury Semikhatsky  <yurys@chromium.org>
+
+        [GTK] Inspector protocol tests timing out on the bots
+        https://bugs.webkit.org/show_bug.cgi?id=122571
+
+        Reviewed by Devin Rousso.
+
+        Mark more inspector tests as passing on GTK.
+
+        * inspector/dom/focus.html: Remove 'focus' event listener before closing dummy inspector
+        window. Otherwise it triggers a WebPage::setActivityState which in turn triggers focus
+        event on the page and on the focused element which results in two extra 'focus' lines printed.
+        To be clear this only avoids the extra text output that could be added to the output. Timeout
+        and crash problems must have been fixed before (likely by the recent changes in local inspector
+        client).
+        * platform/gtk/TestExpectations:
+
 2019-11-04  Truitt Savell  <tsavell@apple.com>
 

trunk/LayoutTests/inspector/dom/focus.html

@@ -3 +3 @@
 <script src="../../http/tests/inspector/resources/protocol-test.js"></script>
 <script>
+
+function focusListener()
+{
+    log("focused");
+}
+
 window.addEventListener("load", function() {
-    document.querySelector("#second").addEventListener("focus", function() {
-        log("focused");
-    });
+    document.querySelector("#second").addEventListener("focus", focusListener);
 });
+
+function removeFocusListener()
+{
+    document.querySelector("#second").removeEventListener("focus", focusListener);
+}
 
 function test()
@@ -36 +45 @@
         if (msg.error)
             ProtocolTest.log(msg.error);
-        ProtocolTest.completeTest();
+        ProtocolTest.evaluateInPage("removeFocusListener()")
+        .then(() => {
+            ProtocolTest.completeTest();
+        });
     }
 }

trunk/LayoutTests/platform/gtk/TestExpectations

@@ -2332 +2332 @@
 
 webkit.org/b/147518 inspector/debugger/nested-inspectors.html [ Timeout ]
-webkit.org/b/122571 http/tests/inspector/dom/cross-domain-inspected-node-access.html [ Timeout Pass ]
-webkit.org/b/122571 inspector/dom/focus.html [ Failure Timeout Pass ]
-webkit.org/b/122571 inspector/runtime/getProperties.html [ Timeout Pass Crash ]
-webkit.org/b/122571 inspector/runtime/saveResult.html [ Timeout Pass Crash ]
-webkit.org/b/122571 inspector/page/frameStartedLoading.html [ Timeout Pass ]
-webkit.org/b/122571 inspector/page/frameScheduledNavigation.html [ Timeout Pass Crash ]
-webkit.org/b/122571 inspector/page/setEmulatedMedia.html [ Timeout Pass ]
-webkit.org/b/122571 inspector/css/getSupportedCSSProperties.html [ Timeout Pass ]
 
 Bug(GTK) plugins/reloadplugins-and-pages.html [ Timeout ]