Changeset 252059 in webkit


Ignore:
Timestamp:
Nov 5, 2019 10:05:12 AM (4 years ago)
Author:
eric.carlson@apple.com
Message:

http/tests/media/track-in-band-hls-metadata.html sometimes crashes after r251626
https://bugs.webkit.org/show_bug.cgi?id=203849
<rdar://problem/56889717>

Reviewed by Youenn Fablet.

No new tests, fixes existing test.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(-[WebCoreAVFMovieObserver metadataOutput:didOutputTimedMetadataGroups:fromPlayerItemTrack:]): Return early if
m_player has been cleared.
(-[WebCoreAVFMovieObserver metadataCollector:didCollectDateRangeMetadataGroups:indexesOfNewGroups:indexesOfModifiedGroups:]):
Ditto.

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r252057 r252059  
     12019-11-05  Eric Carlson  <eric.carlson@apple.com>
     2
     3        http/tests/media/track-in-band-hls-metadata.html sometimes crashes after r251626
     4        https://bugs.webkit.org/show_bug.cgi?id=203849
     5        <rdar://problem/56889717>
     6
     7        Reviewed by Youenn Fablet.
     8
     9        No new tests, fixes existing test.
     10
     11        * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
     12        (-[WebCoreAVFMovieObserver metadataOutput:didOutputTimedMetadataGroups:fromPlayerItemTrack:]): Return early if
     13        m_player has been cleared.
     14        (-[WebCoreAVFMovieObserver metadataCollector:didCollectDateRangeMetadataGroups:indexesOfNewGroups:indexesOfModifiedGroups:]):
     15        Ditto.
     16
    1172019-11-05  Andy Estes  <aestes@apple.com>
    218
  • trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm

    r251626 r252059  
    35043504    UNUSED_PARAM(track);
    35053505
     3506    if (!m_player || !metadataGroups)
     3507        return;
     3508
    35063509    m_taskQueue.enqueueTask([player = m_player, metadataGroups = retainPtr(metadataGroups), currentTime = m_player->currentMediaTime()] {
    35073510        if (!player)
     
    35193522    UNUSED_PARAM(indexesOfNewGroups);
    35203523    UNUSED_PARAM(indexesOfModifiedGroups);
     3524
     3525    if (!m_player || !metadataGroups)
     3526        return;
    35213527
    35223528    m_taskQueue.enqueueTask([player = m_player, metadataGroups = retainPtr(metadataGroups), currentTime = m_player->currentMediaTime()] {
Note: See TracChangeset for help on using the changeset viewer.