Changeset 25206 in webkit


Ignore:
Timestamp:
Aug 23, 2007 1:13:16 PM (17 years ago)
Author:
ddkilzer
Message:

WebCore:

Updated old ChangeLog entry with bug title and test information.

WebKitTools:

Reviewed by Darin and Adam.

Use a frame group name for all WebViews created by DumpRenderTree to
allow testing of cross-page frame lookup.

  • DumpRenderTree/DumpRenderTree.m: (createWebView): Pass group name to -[WebView initWithFrame:frameName:groupName:].
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (main): Pass group name to WebView::initWithFrame(RECT, BSTR, BSTR).

LayoutTests:

Reviewed by Adam.

  • http/tests/navigation/resources/target-frame-from-window-end.html: Added.
  • http/tests/navigation/resources/target-frame-from-window-popup.html: Added.
  • http/tests/navigation/resources/target-frame-from-window-start.html: Added.
  • http/tests/navigation/target-frame-from-window-expected.txt: Added.
  • http/tests/navigation/target-frame-from-window.html: Added.
  • platform/win/Skipped: Added http/tests/navigation/target-frame-from-window.html to skip list.
Location:
trunk
Files:
5 added
6 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r25203 r25206  
     12007-08-23  David Kilzer  <ddkilzer@webkit.org>
     2
     3        Reviewed by Adam.
     4
     5        - test for http://bugs.webkit.org/show_bug.cgi?id=11756
     6          REGRESSION: link targeting a frame in another window does not work
     7          <rdar://problem/5286420>
     8
     9        * http/tests/navigation/resources/target-frame-from-window-end.html: Added.
     10        * http/tests/navigation/resources/target-frame-from-window-popup.html: Added.
     11        * http/tests/navigation/resources/target-frame-from-window-start.html: Added.
     12        * http/tests/navigation/target-frame-from-window-expected.txt: Added.
     13        * http/tests/navigation/target-frame-from-window.html: Added.
     14        * platform/win/Skipped: Added http/tests/navigation/target-frame-from-window.html to skip list.
     15
    1162007-08-23  Justin Garcia  <justin.garcia@apple.com>
    217
  • trunk/LayoutTests/platform/win/Skipped

    r25182 r25206  
    270270fast/dom/open-and-close-by-DOM.html
    271271fast/history/history_reload.html
     272http/tests/navigation/target-frame-from-window.html
    272273http/tests/security/dataURL/xss-DENIED-from-data-url-in-foriegn-domain-window-open.html
    273274http/tests/security/dataURL/xss-DENIED-from-javascript-url-window-open.html
  • trunk/WebCore/ChangeLog

    r25203 r25206  
    41104110
    41114111        - fix http://bugs.webkit.org/show_bug.cgi?id=11756
     4112          REGRESSION: link targeting a frame in another window does not work
    41124113          <rdar://problem/5286420>
     4114
     4115        Test: http/tests/navigation/target-frame-from-window.html
    41134116
    41144117        Fix a typo error to really compare the present domain to the domain of the parent of the targeted frame.
  • trunk/WebKitTools/ChangeLog

    r25202 r25206  
     12007-08-23  Mitz Pettel  <mitz@webkit.org>
     2
     3        Reviewed by Darin and Adam.
     4
     5        - DumpRenderTree changes to allow testing for
     6          http://bugs.webkit.org/show_bug.cgi?id=11756
     7          REGRESSION: link targeting a frame in another window does not work
     8          <rdar://problem/5286420>
     9
     10        Use a frame group name for all WebViews created by DumpRenderTree to
     11        allow testing of cross-page frame lookup.
     12
     13        * DumpRenderTree/DumpRenderTree.m:
     14        (createWebView): Pass group name to -[WebView initWithFrame:frameName:groupName:].
     15        * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
     16        (main): Pass group name to WebView::initWithFrame(RECT, BSTR, BSTR).
     17
    1182007-08-23  David Kilzer  <ddkilzer@webkit.org>
    219
  • trunk/WebKitTools/DumpRenderTree/DumpRenderTree.m

    r25169 r25206  
    379379{
    380380    NSRect rect = NSMakeRect(0, 0, maxViewWidth, maxViewHeight);
    381     WebView *webView = [[WebView alloc] initWithFrame:rect];
     381    WebView *webView = [[WebView alloc] initWithFrame:rect frameName:nil groupName:@"org.webkit.DumpRenderTree"];
    382382       
    383383    [webView setUIDelegate:uiDelegate];
  • trunk/WebKitTools/DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp

    r25196 r25206  
    775775    RECT clientRect;
    776776    clientRect.bottom = clientRect.left = clientRect.top = clientRect.right = 0;
    777     if (FAILED(webView->initWithFrame(clientRect, 0, 0)))
     777    BSTR groupName = SysAllocString(L"org.webkit.DumpRenderTree");
     778    bool failed = FAILED(webView->initWithFrame(clientRect, 0, groupName));
     779    SysFreeString(groupName);
     780    if (failed)
    778781        return -1;
    779782
     
    787790    _tcscpy(pluginPath, exePath.c_str());
    788791    _tcscat(pluginPath, TestPluginDir);
    789     bool failed = FAILED(viewPrivate->addAdditionalPluginPath(pluginPath));
     792    failed = FAILED(viewPrivate->addAdditionalPluginPath(pluginPath));
    790793    SysFreeString(pluginPath);
    791794    if (failed)
Note: See TracChangeset for help on using the changeset viewer.