Changeset 252087 in webkit


Ignore:
Timestamp:
Nov 5, 2019 2:59:56 PM (4 years ago)
Author:
Jonathan Bedard
Message:

REGRESSION(r252031): layout tests fail to run in non apple ports after r252031 (Follow-up fix)
https://bugs.webkit.org/show_bug.cgi?id=203844

Rubber-stamped by Aakash Jain.

Remove infinite loop for Windows.

  • Scripts/webkitpy/port/win.py:

(WinPort._path_to_default_image_diff):
(WinPort._path_to_image_diff): Deleted.

Location:
trunk/Tools
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r252075 r252087  
     12019-11-05  Jonathan Bedard  <jbedard@apple.com>
     2
     3        REGRESSION(r252031): layout tests fail to run in non apple ports after r252031 (Follow-up fix)
     4        https://bugs.webkit.org/show_bug.cgi?id=203844
     5
     6        Rubber-stamped by Aakash Jain.
     7
     8        Remove infinite loop for Windows.
     9
     10        * Scripts/webkitpy/port/win.py:
     11        (WinPort._path_to_default_image_diff):
     12        (WinPort._path_to_image_diff): Deleted.
     13
    1142019-11-05  Aakash Jain  <aakash_jain@apple.com>
    215
  • trunk/Tools/Scripts/webkitpy/port/win.py

    r252050 r252087  
    193193        return "/usr/bin/php-cgi"
    194194
    195     def _path_to_image_diff(self):
    196         if self.is_cygwin():
    197             return super(WinPort, self)._path_to_image_diff()
    198 
     195    def _path_to_default_image_diff(self):
    199196        return self._build_path('ImageDiff.exe')
    200 
    201     def _path_to_default_image_diff(self):
    202         return self._path_to_image_diff()
    203197
    204198    API_TEST_BINARY_NAMES = ['TestWTF.exe', 'TestWebCore.exe', 'TestWebKitLegacy.exe']
Note: See TracChangeset for help on using the changeset viewer.