Changeset 252116 in webkit

Timestamp:

Nov 5, 2019 5:38:59 PM (4 years ago)

Author:

wilander@apple.com

Message:

Temporarily turn off NSURLSession isolation
​https://bugs.webkit.org/show_bug.cgi?id=201822

Reviewed by Chris Dumez.

Source/WebKit:

Existing tests skipped.

Re-enabling it is tracked in rdar://problem/56921584.

• NetworkProcess/cache/NetworkCacheStorage.h:

Bumps the version to force a clean cache.

• NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:

(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):

Skips setting needsIsolatedSession.

LayoutTests:

Re-enabling it is tracked in rdar://problem/56921584.

• platform/wk2/TestExpectations:

Skipped the associated tests.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/wk2/TestExpectations (modified) (1 diff)
• Source/WebKit/ChangeLog (modified) (1 diff)
• Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.h (modified) (1 diff)
• Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-11-05  John Wilander  <wilander@apple.com>
+
+        Temporarily turn off NSURLSession isolation
+        https://bugs.webkit.org/show_bug.cgi?id=201822
+
+        Reviewed by Chris Dumez.
+
+        Re-enabling it is tracked in rdar://problem/56921584.
+
+        * platform/wk2/TestExpectations:
+            Skipped the associated tests.
+
 2019-11-05  Oriol Brufau  <obrufau@igalia.com>
 

trunk/LayoutTests/platform/wk2/TestExpectations

@@ -747 +747 @@
 http/tests/resourceLoadStatistics/cap-cache-max-age-for-prevalent-resource.html [ Skip ]
 
+# rdar://problem/56921584
+http/tests/resourceLoadStatistics/switch-session-on-navigation-to-prevalent-with-interaction.php [ Skip ]
+http/tests/resourceLoadStatistics/switch-session-on-navigation-to-prevalent-with-interaction-database.php [ Skip ]
+
 # This feature is currently disabled by default and unfinished <rdar://problem/38925077>.
 http/tests/navigation/process-swap-window-open.html [ Skip ]

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-11-05  John Wilander  <wilander@apple.com>
+
+        Temporarily turn off NSURLSession isolation
+        https://bugs.webkit.org/show_bug.cgi?id=201822
+
+        Reviewed by Chris Dumez.
+
+        Existing tests skipped.
+
+        Re-enabling it is tracked in rdar://problem/56921584.
+
+        * NetworkProcess/cache/NetworkCacheStorage.h:
+            Bumps the version to force a clean cache.
+        * NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
+        (WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):
+            Skips setting needsIsolatedSession.
+
 2019-11-05  Per Arne Vollan  <pvollan@apple.com>
 

trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.h

@@ -108 +108 @@
 
     // Incrementing this number will delete all existing cache content for everyone. Do you really need to do it?
-    static const unsigned version = 14;
+    static const unsigned version = 15;
 #if PLATFORM(MAC)
     /// Allow the last stable version of the cache to co-exist with the latest development one.

trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm

@@ -214 +214 @@
         if (!shouldBlockCookies)
             shouldBlockCookies = networkStorageSession->shouldBlockCookies(request, frameID, pageID);
-        needsIsolatedSession = networkStorageSession->shouldBlockThirdPartyCookiesButKeepFirstPartyCookiesFor(firstParty);
+        // FIXME: <rdar://problem/56921584> needsIsolatedSession should be set here.
     }
 #endif