Changeset 252139 in webkit

Timestamp:

Nov 6, 2019 9:36:33 AM (4 years ago)

Author:

dbates@webkit.org

Message:

http/tests/security/isolatedWorld/bypass-main-world-csp-worker.html is a Flakey Failure
​https://bugs.webkit.org/show_bug.cgi?id=198924
<rdar://problem/51811010>

Reviewed by Brent Fulgham.

JavaScript alert() cannot be called from a Web Worker. Use postMessage() instead to post "PASS"
to the worker's owner document. The tests don't actually make use of this posted message, but
fixing the code to use postMessage() may come in handy for future tests.

• http/tests/security/contentSecurityPolicy/resources/worker.php:
• http/tests/security/contentSecurityPolicy/worker-script-src.html:
• http/tests/security/isolatedWorld/bypass-main-world-csp-worker.html:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• http/tests/security/contentSecurityPolicy/resources/worker.php (modified) (1 diff)
• http/tests/security/contentSecurityPolicy/worker-script-src.html (modified) (1 diff)
• http/tests/security/isolatedWorld/bypass-main-world-csp-worker.html (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-11-06  Daniel Bates  <dabates@apple.com>
+
+        http/tests/security/isolatedWorld/bypass-main-world-csp-worker.html is a Flakey Failure
+        https://bugs.webkit.org/show_bug.cgi?id=198924
+        <rdar://problem/51811010>
+
+        Reviewed by Brent Fulgham.
+
+        JavaScript alert() cannot be called from a Web Worker. Use postMessage() instead to post "PASS"
+        to the worker's owner document. The tests don't actually make use of this posted message, but
+        fixing the code to use postMessage() may come in handy for future tests.
+
+        * http/tests/security/contentSecurityPolicy/resources/worker.php:
+        * http/tests/security/contentSecurityPolicy/worker-script-src.html:
+        * http/tests/security/isolatedWorld/bypass-main-world-csp-worker.html:
+
 2019-11-06  Daniel Bates  <dabates@apple.com>
 

trunk/LayoutTests/http/tests/security/contentSecurityPolicy/resources/worker.php

@@ -81 +81 @@
 
 <?php
-} else if ($_GET["type"] == "alert-pass") {
+} else if ($_GET["type"] == "post-message-pass") {
 ?>
 
-alert('PASS');
+postMessage("PASS");
 
 <?php

trunk/LayoutTests/http/tests/security/contentSecurityPolicy/worker-script-src.html

@@ -12 +12 @@
 <script>
 try {
-    var worker = new Worker('http://127.0.0.1:8000/security/contentSecurityPolicy/resources/worker.php?type=alert-pass&csp=' +
+    // We ignore the message posted by the worker (by not registering an onmessage handler) as we are only interested in knowing whether an exception occurred.
+    var worker = new Worker('http://127.0.0.1:8000/security/contentSecurityPolicy/resources/worker.php?type=post-message-pass&csp=' +
                              encodeURIComponent("script-src 'self' 'unsafe-inline'"));
     alert("PASS");

trunk/LayoutTests/http/tests/security/isolatedWorld/bypass-main-world-csp-worker.html

@@ -25 +25 @@
     var worker;
     try {
-        worker = new Worker("http://127.0.0.1:8000/security/contentSecurityPolicy/resources/worker.php?type=alert-pass");
+        // We ignore the message posted by the worker (by not registering an onmessage handler) as we are only interested in knowing whether an exception occurred.
+        worker = new Worker("http://127.0.0.1:8000/security/contentSecurityPolicy/resources/worker.php?type=post-message-pass");
         window.postMessage("PASS worker instantiated.", "*");
     } catch (exception) {