Changeset 252140 in webkit


Ignore:
Timestamp:
Nov 6, 2019 9:37:48 AM (4 years ago)
Author:
dbates@webkit.org
Message:

REGRESSION [ PHP ][ iOS ]: Two http/tests/cookies/same-site/set-first-party-* Tests are Failing
​https://bugs.webkit.org/show_bug.cgi?id=203567
<rdar://problem/56708500>

Reviewed by Youenn Fablet.

A callable must be passed by string in PHP. Any other way seems to be non-standard and your
mileage may vary.

  • http/tests/cookies/resources/cookie-utilities.php:
  • http/tests/cookies/resources/cookie-utility.php:
  • platform/ios-wk2/TestExpectations:
Location:
trunk/LayoutTests
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r252139 r252140  
     12019-11-06  Daniel Bates  <dabates@apple.com>
     2
     3        REGRESSION [ PHP ][ iOS ]: Two http/tests/cookies/same-site/set-first-party-* Tests are Failing
     4        https://bugs.webkit.org/show_bug.cgi?id=203567
     5        <rdar://problem/56708500>
     6
     7        Reviewed by Youenn Fablet.
     8
     9        A callable must be passed by string in PHP. Any other way seems to be non-standard and your
     10        mileage may vary.
     11
     12        * http/tests/cookies/resources/cookie-utilities.php:
     13        * http/tests/cookies/resources/cookie-utility.php:
     14        * platform/ios-wk2/TestExpectations:
     15
    1162019-11-06  Daniel Bates  <dabates@apple.com>
    217

  • trunk/LayoutTests/http/tests/cookies/resources/cookie-utilities.php

    r234629 r252140  
    4949function resetCookiesForCurrentOrigin()
    5050{
    51     array_walk($_COOKIE, _deleteCookieCallback);
     51    array_walk($_COOKIE, '_deleteCookieCallback');
    5252}
    5353?>

  • trunk/LayoutTests/http/tests/cookies/resources/cookie-utility.php

    r234767 r252140  
    4242{
    4343    echo "Cookies are:\n";
    44     array_walk($_COOKIE, echoCookie);   
     44    array_walk($_COOKIE, 'echoCookie');
    4545}
    4646

  • trunk/LayoutTests/platform/ios-wk2/TestExpectations

    r251949 r252140  
    13651365webkit.org/b/203572 media/remoteplayback-target-availability.html [ Skip ]
    13661366
    1367 # <rdar://problem/56708500> REGRESSION [ PHP ][ iOS ]: Two http/tests/cookies/same-site/set-first-party-* Tests are Failing (203567)
    1368 webkit.org/b/203567 http/tests/cookies/same-site/set-first-party-cross-site-cookies.php [ Failure ]
    1369 webkit.org/b/203567 http/tests/cookies/same-site/set-first-party-same-site-cookies.php [ Failure ]
    1370 
    13711367# <rdar://problem/56761171> [ iOS ] Layout Test fast/css-custom-paint/simple-hidpi.html is a Flaky Failure (203637)
    13721368webkit.org/b/203637 fast/css-custom-paint/simple-hidpi.html [ Pass ImageOnlyFailure ]
    1373 
Note: See TracChangeset for help on using the changeset viewer.