Changeset 252153 in webkit


Ignore:
Timestamp:
Nov 6, 2019 3:03:10 PM (4 years ago)
Author:
dbates@webkit.org
Message:

Update SameSite tests for new semantics for empty and invalid SameSite attribute
​https://bugs.webkit.org/show_bug.cgi?id=203755
<rdar://problem/50816282>

Reviewed by Brent Fulgham.

Update the tests and test expectations following CFNetwork change <rdar://problem/42290578> as we
now only recognize SameSite=Strict and SameSite=Lax. That is, we no longer treat SameSite= or
SameSite=<some garbage value> as SameSite=Strict.

MacOS Mojave does not have the fix for <rdar://problem/42290578> and so we land expected failure results.

  • http/tests/cookies/same-site/fetch-after-navigating-iframe-in-cross-origin-page-expected.txt:
  • http/tests/cookies/same-site/fetch-after-top-level-cross-origin-redirect-expected.txt:
  • http/tests/cookies/same-site/fetch-after-top-level-navigation-from-cross-origin-page-expected.txt:
  • http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page-expected.txt:
  • http/tests/cookies/same-site/fetch-in-cross-origin-service-worker-expected.txt:
  • http/tests/cookies/same-site/popup-cross-site-post.html:
  • http/tests/cookies/same-site/popup-cross-site.html:
  • http/tests/cookies/same-site/popup-same-site-via-cross-site-redirect.html:
  • http/tests/cookies/same-site/resources/fetch-after-navigating-iframe-in-cross-origin-page.php:
  • http/tests/cookies/same-site/resources/fetch-after-top-level-cross-origin-redirect.php:
  • http/tests/cookies/same-site/resources/fetch-after-top-level-navigation-from-cross-origin-page.php:
  • http/tests/cookies/same-site/resources/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.php:
  • http/tests/cookies/same-site/resources/fetch-in-cross-origin-service-worker.html:
  • platform/ios-12/http/tests/cookies/same-site/fetch-after-navigating-iframe-in-cross-origin-page-expected.txt: Removed.
  • platform/ios-12/http/tests/cookies/same-site/fetch-after-top-level-cross-origin-redirect-expected.txt: Removed.
  • platform/ios-12/http/tests/cookies/same-site/fetch-after-top-level-navigation-from-cross-origin-page-expected.txt: Removed.
  • platform/ios-12/http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page-expected.txt: Removed.
  • platform/ios-12/http/tests/cookies/same-site/fetch-in-cross-origin-service-worker-expected.txt: Removed.
  • platform/ios-12/http/tests/cookies/same-site/popup-cross-site-expected.txt: Removed.
  • platform/ios-12/http/tests/cookies/same-site/popup-cross-site-post-expected.txt: Removed.
  • platform/ios-12/http/tests/cookies/same-site/popup-same-site-via-cross-site-redirect-expected.txt: Removed.
  • platform/ios/http/tests/cookies/same-site/fetch-after-navigating-iframe-in-cross-origin-page-expected.txt: Removed.
  • platform/ios/http/tests/cookies/same-site/fetch-after-top-level-cross-origin-redirect-expected.txt: Removed.
  • platform/ios/http/tests/cookies/same-site/fetch-after-top-level-navigation-from-cross-origin-page-expected.txt: Removed.
  • platform/ios/http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page-expected.txt: Removed.
  • platform/ios/http/tests/cookies/same-site/fetch-in-cross-origin-service-worker-expected.txt: Removed.
  • platform/ios/http/tests/cookies/same-site/popup-cross-site-expected.txt: Removed.
  • platform/ios/http/tests/cookies/same-site/popup-cross-site-post-expected.txt: Removed.
  • platform/ios/http/tests/cookies/same-site/popup-same-site-via-cross-site-redirect-expected.txt: Removed.
  • platform/mac-mojave/http/tests/cookies/same-site/fetch-after-navigating-iframe-in-cross-origin-page-expected.txt:
  • platform/mac-mojave/http/tests/cookies/same-site/fetch-after-top-level-cross-origin-redirect-expected.txt:
  • platform/mac-mojave/http/tests/cookies/same-site/fetch-after-top-level-navigation-from-cross-origin-page-expected.txt:
  • platform/mac-mojave/http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page-expected.txt:
  • platform/mac-mojave/http/tests/cookies/same-site/fetch-in-cross-origin-service-worker-expected.txt:
  • platform/mac-mojave/http/tests/cookies/same-site/popup-cross-site-expected.txt:
  • platform/mac-mojave/http/tests/cookies/same-site/popup-cross-site-post-expected.txt:
  • platform/mac-mojave/http/tests/cookies/same-site/popup-same-site-via-cross-site-redirect-expected.txt:
  • platform/mac/http/tests/cookies/same-site/fetch-after-navigating-iframe-in-cross-origin-page-expected.txt: Removed.
  • platform/mac/http/tests/cookies/same-site/fetch-after-top-level-cross-origin-redirect-expected.txt: Removed.
  • platform/mac/http/tests/cookies/same-site/fetch-after-top-level-navigation-from-cross-origin-page-expected.txt: Removed.
  • platform/mac/http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page-expected.txt: Removed.
  • platform/mac/http/tests/cookies/same-site/fetch-in-cross-origin-service-worker-expected.txt: Removed.
  • platform/mac/http/tests/cookies/same-site/popup-cross-site-expected.txt: Removed.
  • platform/mac/http/tests/cookies/same-site/popup-cross-site-post-expected.txt: Removed.
  • platform/mac/http/tests/cookies/same-site/popup-same-site-via-cross-site-redirect-expected.txt: Removed.
Location:
trunk/LayoutTests
Files:
3 deleted
22 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r252149 r252153  
     12019-11-06  Daniel Bates  <dabates@apple.com>
     2
     3        Update SameSite tests for new semantics for empty and invalid SameSite attribute
     4        https://bugs.webkit.org/show_bug.cgi?id=203755
     5        <rdar://problem/50816282>
     6
     7        Reviewed by Brent Fulgham.
     8
     9        Update the tests and test expectations following CFNetwork change <rdar://problem/42290578> as we
     10        now only recognize SameSite=Strict and SameSite=Lax. That is, we no longer treat SameSite= or
     11        SameSite=<some garbage value> as SameSite=Strict.
     12
     13        MacOS Mojave does not have the fix for <rdar://problem/42290578> and so we land expected failure results.
     14
     15        * http/tests/cookies/same-site/fetch-after-navigating-iframe-in-cross-origin-page-expected.txt:
     16        * http/tests/cookies/same-site/fetch-after-top-level-cross-origin-redirect-expected.txt:
     17        * http/tests/cookies/same-site/fetch-after-top-level-navigation-from-cross-origin-page-expected.txt:
     18        * http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page-expected.txt:
     19        * http/tests/cookies/same-site/fetch-in-cross-origin-service-worker-expected.txt:
     20        * http/tests/cookies/same-site/popup-cross-site-post.html:
     21        * http/tests/cookies/same-site/popup-cross-site.html:
     22        * http/tests/cookies/same-site/popup-same-site-via-cross-site-redirect.html:
     23        * http/tests/cookies/same-site/resources/fetch-after-navigating-iframe-in-cross-origin-page.php:
     24        * http/tests/cookies/same-site/resources/fetch-after-top-level-cross-origin-redirect.php:
     25        * http/tests/cookies/same-site/resources/fetch-after-top-level-navigation-from-cross-origin-page.php:
     26        * http/tests/cookies/same-site/resources/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.php:
     27        * http/tests/cookies/same-site/resources/fetch-in-cross-origin-service-worker.html:
     28        * platform/ios-12/http/tests/cookies/same-site/fetch-after-navigating-iframe-in-cross-origin-page-expected.txt: Removed.
     29        * platform/ios-12/http/tests/cookies/same-site/fetch-after-top-level-cross-origin-redirect-expected.txt: Removed.
     30        * platform/ios-12/http/tests/cookies/same-site/fetch-after-top-level-navigation-from-cross-origin-page-expected.txt: Removed.
     31        * platform/ios-12/http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page-expected.txt: Removed.
     32        * platform/ios-12/http/tests/cookies/same-site/fetch-in-cross-origin-service-worker-expected.txt: Removed.
     33        * platform/ios-12/http/tests/cookies/same-site/popup-cross-site-expected.txt: Removed.
     34        * platform/ios-12/http/tests/cookies/same-site/popup-cross-site-post-expected.txt: Removed.
     35        * platform/ios-12/http/tests/cookies/same-site/popup-same-site-via-cross-site-redirect-expected.txt: Removed.
     36        * platform/ios/http/tests/cookies/same-site/fetch-after-navigating-iframe-in-cross-origin-page-expected.txt: Removed.
     37        * platform/ios/http/tests/cookies/same-site/fetch-after-top-level-cross-origin-redirect-expected.txt: Removed.
     38        * platform/ios/http/tests/cookies/same-site/fetch-after-top-level-navigation-from-cross-origin-page-expected.txt: Removed.
     39        * platform/ios/http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page-expected.txt: Removed.
     40        * platform/ios/http/tests/cookies/same-site/fetch-in-cross-origin-service-worker-expected.txt: Removed.
     41        * platform/ios/http/tests/cookies/same-site/popup-cross-site-expected.txt: Removed.
     42        * platform/ios/http/tests/cookies/same-site/popup-cross-site-post-expected.txt: Removed.
     43        * platform/ios/http/tests/cookies/same-site/popup-same-site-via-cross-site-redirect-expected.txt: Removed.
     44        * platform/mac-mojave/http/tests/cookies/same-site/fetch-after-navigating-iframe-in-cross-origin-page-expected.txt:
     45        * platform/mac-mojave/http/tests/cookies/same-site/fetch-after-top-level-cross-origin-redirect-expected.txt:
     46        * platform/mac-mojave/http/tests/cookies/same-site/fetch-after-top-level-navigation-from-cross-origin-page-expected.txt:
     47        * platform/mac-mojave/http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page-expected.txt:
     48        * platform/mac-mojave/http/tests/cookies/same-site/fetch-in-cross-origin-service-worker-expected.txt:
     49        * platform/mac-mojave/http/tests/cookies/same-site/popup-cross-site-expected.txt:
     50        * platform/mac-mojave/http/tests/cookies/same-site/popup-cross-site-post-expected.txt:
     51        * platform/mac-mojave/http/tests/cookies/same-site/popup-same-site-via-cross-site-redirect-expected.txt:
     52        * platform/mac/http/tests/cookies/same-site/fetch-after-navigating-iframe-in-cross-origin-page-expected.txt: Removed.
     53        * platform/mac/http/tests/cookies/same-site/fetch-after-top-level-cross-origin-redirect-expected.txt: Removed.
     54        * platform/mac/http/tests/cookies/same-site/fetch-after-top-level-navigation-from-cross-origin-page-expected.txt: Removed.
     55        * platform/mac/http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page-expected.txt: Removed.
     56        * platform/mac/http/tests/cookies/same-site/fetch-in-cross-origin-service-worker-expected.txt: Removed.
     57        * platform/mac/http/tests/cookies/same-site/popup-cross-site-expected.txt: Removed.
     58        * platform/mac/http/tests/cookies/same-site/popup-cross-site-post-expected.txt: Removed.
     59        * platform/mac/http/tests/cookies/same-site/popup-same-site-via-cross-site-redirect-expected.txt: Removed.
     60
    1612019-11-06  Truitt Savell  <tsavell@apple.com>
    262

  • trunk/LayoutTests/http/tests/cookies/same-site/fetch-after-navigating-iframe-in-cross-origin-page-expected.txt

    r252149 r252153  
    1111Cookies sent with HTTP request:
    1212PASS Do not have cookie "strict".
    13 PASS Do not have cookie "implicit-strict".
    14 PASS Do not have cookie "strict-because-invalid-SameSite-value".
     13PASS Has cookie "implicit-strict" with value 6.
     14PASS Has cookie "strict-because-invalid-SameSite-value" with value 6.
    1515PASS Do not have cookie "lax".
    1616
    1717Cookies visible in DOM:
    1818PASS Do not have DOM cookie "strict".
    19 PASS Do not have DOM cookie "implicit-strict".
    20 PASS Do not have DOM cookie "strict-because-invalid-SameSite-value".
     19PASS Has DOM cookie "implicit-strict" with value 6.
     20PASS Has DOM cookie "strict-because-invalid-SameSite-value" with value 6.
    2121PASS Do not have DOM cookie "lax".
    2222PASS successfullyParsed is true

  • trunk/LayoutTests/http/tests/cookies/same-site/fetch-after-top-level-cross-origin-redirect-expected.txt

    r252149 r252153  
    66Cookies sent with HTTP request:
    77PASS Do not have cookie "strict".
    8 PASS Do not have cookie "implicit-strict".
    9 PASS Do not have cookie "strict-because-invalid-SameSite-value".
     8PASS Has cookie "implicit-strict" with value 19.
     9PASS Has cookie "strict-because-invalid-SameSite-value" with value 19.
    1010PASS Has cookie "lax" with value 19.
    1111
    1212Cookies visible in DOM:
    1313PASS Do not have DOM cookie "strict".
    14 PASS Do not have DOM cookie "implicit-strict".
    15 PASS Do not have DOM cookie "strict-because-invalid-SameSite-value".
     14PASS Has DOM cookie "implicit-strict" with value 19.
     15PASS Has DOM cookie "strict-because-invalid-SameSite-value" with value 19.
    1616PASS Has DOM cookie "lax" with value 19.
    1717PASS successfullyParsed is true

  • trunk/LayoutTests/http/tests/cookies/same-site/fetch-after-top-level-navigation-from-cross-origin-page-expected.txt

    r252149 r252153  
    66Cookies sent with HTTP request:
    77PASS Do not have cookie "strict".
    8 PASS Do not have cookie "implicit-strict".
    9 PASS Do not have cookie "strict-because-invalid-SameSite-value".
     8PASS Has cookie "implicit-strict" with value 5.
     9PASS Has cookie "strict-because-invalid-SameSite-value" with value 5.
    1010PASS Has cookie "lax" with value 5.
    1111
    1212Cookies visible in DOM:
    1313PASS Do not have DOM cookie "strict".
    14 PASS Do not have DOM cookie "implicit-strict".
    15 PASS Do not have DOM cookie "strict-because-invalid-SameSite-value".
     14PASS Has DOM cookie "implicit-strict" with value 5.
     15PASS Has DOM cookie "strict-because-invalid-SameSite-value" with value 5.
    1616PASS Has DOM cookie "lax" with value 5.
    1717PASS successfullyParsed is true

  • trunk/LayoutTests/http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page-expected.txt

    r252149 r252153  
    66Cookies sent with HTTP request:
    77PASS Do not have cookie "strict".
    8 PASS Do not have cookie "implicit-strict".
    9 PASS Do not have cookie "strict-because-invalid-SameSite-value".
     8PASS Has cookie "implicit-strict" with value 4.
     9PASS Has cookie "strict-because-invalid-SameSite-value" with value 4.
    1010PASS Has cookie "lax" with value 4.
    1111
    1212Cookies visible in DOM:
    1313PASS Do not have DOM cookie "strict".
    14 PASS Do not have DOM cookie "implicit-strict".
    15 PASS Do not have DOM cookie "strict-because-invalid-SameSite-value".
     14PASS Has DOM cookie "implicit-strict" with value 4.
     15PASS Has DOM cookie "strict-because-invalid-SameSite-value" with value 4.
    1616PASS Has DOM cookie "lax" with value 4.
    1717PASS successfullyParsed is true

  • trunk/LayoutTests/http/tests/cookies/same-site/fetch-in-cross-origin-service-worker-expected.txt

    r252149 r252153  
    1111Cookies sent with HTTP request:
    1212PASS Do not have cookie "strict".
    13 PASS Do not have cookie "implicit-strict".
    14 PASS Do not have cookie "strict-because-invalid-SameSite-value".
     13PASS Has cookie "implicit-strict" with value 10.
     14PASS Has cookie "strict-because-invalid-SameSite-value" with value 10.
    1515PASS Do not have cookie "lax".
    1616

  • trunk/LayoutTests/http/tests/cookies/same-site/popup-cross-site-post.html

    r252149 r252153  
    1717        window.addEventListener("message", t.step_func_done(e => {
    1818            assert_equals(e.data.http[STRICT_DOM], undefined, "strict");
    19             assert_equals(e.data.http[IMPLICIT_STRICT_DOM], undefined, "implicit-strict");
    20             assert_equals(e.data.http[STRICT_BECAUSE_INVALID_SAMESITE_VALUE], undefined, "strict-because-invalid-SameSite-value");
     19            assert_equals(e.data.http[IMPLICIT_STRICT_DOM], "1", "implicit-strict");
     20            assert_equals(e.data.http[STRICT_BECAUSE_INVALID_SAMESITE_VALUE], "1", "strict-because-invalid-SameSite-value");
    2121            assert_equals(e.data.http[LAX_DOM], undefined, "lax");
    2222            assert_equals(e.data.http[NORMAL_DOM], "1", "normal");
    23             assert_equals(normalizeCookie(e.data.document), normalizeCookie(LAX_DOM + "=1; " + NORMAL_DOM + "=1"));
     23            assert_equals(normalizeCookie(e.data.document), normalizeCookie(IMPLICIT_STRICT_DOM + "=1; " + LAX_DOM + "=1; " + NORMAL_DOM + "=1; " + STRICT_BECAUSE_INVALID_SAMESITE_VALUE + "=1"));
    2424            e.source.close();
    2525        }));

  • trunk/LayoutTests/http/tests/cookies/same-site/popup-cross-site.html

    r252149 r252153  
    1616        window.addEventListener("message", t.step_func_done(e => {
    1717            assert_equals(e.data.http[STRICT_DOM], undefined, "strict");
    18             assert_equals(e.data.http[IMPLICIT_STRICT_DOM], undefined, "implicit-strict");
    19             assert_equals(e.data.http[STRICT_BECAUSE_INVALID_SAMESITE_VALUE], undefined, "strict-because-invalid-SameSite-value");
     18            assert_equals(e.data.http[IMPLICIT_STRICT_DOM], "1", "implicit-strict");
     19            assert_equals(e.data.http[STRICT_BECAUSE_INVALID_SAMESITE_VALUE], "1", "strict-because-invalid-SameSite-value");
    2020            assert_equals(e.data.http[LAX_DOM], "1", "lax");
    2121            assert_equals(e.data.http[NORMAL_DOM], "1", "normal");
    22             assert_equals(normalizeCookie(e.data.document), normalizeCookie(LAX_DOM + "=1; " + NORMAL_DOM + "=1"));
     22            assert_equals(normalizeCookie(e.data.document), normalizeCookie(IMPLICIT_STRICT_DOM + "=1; " + LAX_DOM + "=1; " + NORMAL_DOM + "=1; " + STRICT_BECAUSE_INVALID_SAMESITE_VALUE + "=1"));
    2323        }));
    2424    }, "'127.0.0.1' is not same-site with 'localhost', so strict samesite cookies are not sent.");

  • trunk/LayoutTests/http/tests/cookies/same-site/popup-same-site-via-cross-site-redirect.html

    r252149 r252153  
    1414    window.addEventListener("message", t.step_func_done(e => {
    1515        assert_equals(e.data.http[STRICT_DOM], undefined, "strict");
    16         assert_equals(e.data.http[IMPLICIT_STRICT_DOM], undefined, "implicit-strict");
    17         assert_equals(e.data.http[STRICT_BECAUSE_INVALID_SAMESITE_VALUE], undefined, "strict-because-invalid-SameSite-value");
     16        assert_equals(e.data.http[IMPLICIT_STRICT_DOM], "1", "implicit-strict");
     17        assert_equals(e.data.http[STRICT_BECAUSE_INVALID_SAMESITE_VALUE], "1", "strict-because-invalid-SameSite-value");
    1818        assert_equals(e.data.http[LAX_DOM], "1", "lax");
    1919        assert_equals(e.data.http[NORMAL_DOM], "1", "normal");
    20         assert_equals(normalizeCookie(e.data.document), normalizeCookie(LAX_DOM + "=1; " + NORMAL_DOM + "=1"));
     20        assert_equals(normalizeCookie(e.data.document), normalizeCookie(IMPLICIT_STRICT_DOM + "=1; " + LAX_DOM + "=1; " + NORMAL_DOM + "=1; " + STRICT_BECAUSE_INVALID_SAMESITE_VALUE + "=1"));
    2121    }));
    2222

  • trunk/LayoutTests/http/tests/cookies/same-site/resources/fetch-after-navigating-iframe-in-cross-origin-page.php

    r252149 r252153  
    1616    debug("Cookies sent with HTTP request:");
    1717    await shouldNotHaveCookie("strict");
    18     await shouldNotHaveCookie("implicit-strict");
    19     await shouldNotHaveCookie("strict-because-invalid-SameSite-value");
     18    await shouldHaveCookieWithValue("implicit-strict", "6");
     19    await shouldHaveCookieWithValue("strict-because-invalid-SameSite-value", "6");
    2020    await shouldNotHaveCookie("lax");
    2121
    2222    debug("<br>Cookies visible in DOM:");
    2323    shouldNotHaveDOMCookie("strict");
    24     shouldNotHaveDOMCookie("implicit-strict");
    25     shouldNotHaveDOMCookie("strict-because-invalid-SameSite-value");
     24    shouldHaveDOMCookieWithValue("implicit-strict", "6");
     25    shouldHaveDOMCookieWithValue("strict-because-invalid-SameSite-value", "6");
    2626    shouldNotHaveDOMCookie("lax");
    2727

  • trunk/LayoutTests/http/tests/cookies/same-site/resources/fetch-after-top-level-cross-origin-redirect.php

    r252149 r252153  
    1616    debug("Cookies sent with HTTP request:");
    1717    await shouldNotHaveCookie("strict");
    18     await shouldNotHaveCookie("implicit-strict");
    19     await shouldNotHaveCookie("strict-because-invalid-SameSite-value");
     18    await shouldHaveCookieWithValue("implicit-strict", "19");
     19    await shouldHaveCookieWithValue("strict-because-invalid-SameSite-value", "19");
    2020    await shouldHaveCookieWithValue("lax", "19");
    2121
    2222    debug("<br>Cookies visible in DOM:");
    2323    shouldNotHaveDOMCookie("strict");
    24     shouldNotHaveDOMCookie("implicit-strict");
    25     shouldNotHaveDOMCookie("strict-because-invalid-SameSite-value");
     24    shouldHaveDOMCookieWithValue("implicit-strict", "19");
     25    shouldHaveDOMCookieWithValue("strict-because-invalid-SameSite-value", "19");
    2626    shouldHaveDOMCookieWithValue("lax", "19");
    2727

  • trunk/LayoutTests/http/tests/cookies/same-site/resources/fetch-after-top-level-navigation-from-cross-origin-page.php

    r252149 r252153  
    1616    debug("Cookies sent with HTTP request:");
    1717    await shouldNotHaveCookie("strict");
    18     await shouldNotHaveCookie("implicit-strict");
    19     await shouldNotHaveCookie("strict-because-invalid-SameSite-value");
     18    await shouldHaveCookieWithValue("implicit-strict", "5");
     19    await shouldHaveCookieWithValue("strict-because-invalid-SameSite-value", "5");
    2020    await shouldHaveCookieWithValue("lax", "5");
    2121
    2222    debug("<br>Cookies visible in DOM:");
    2323    shouldNotHaveDOMCookie("strict");
    24     shouldNotHaveDOMCookie("implicit-strict");
    25     shouldNotHaveDOMCookie("strict-because-invalid-SameSite-value");
     24    shouldHaveDOMCookieWithValue("implicit-strict", "5");
     25    shouldHaveDOMCookieWithValue("strict-because-invalid-SameSite-value", "5");
    2626    shouldHaveDOMCookieWithValue("lax", "5");
    2727

  • trunk/LayoutTests/http/tests/cookies/same-site/resources/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.php

    r252149 r252153  
    1616    debug("Cookies sent with HTTP request:");
    1717    await shouldNotHaveCookie("strict");
    18     await shouldNotHaveCookie("implicit-strict");
    19     await shouldNotHaveCookie("strict-because-invalid-SameSite-value");
     18    await shouldHaveCookieWithValue("implicit-strict", "4");
     19    await shouldHaveCookieWithValue("strict-because-invalid-SameSite-value", "4");
    2020    await shouldHaveCookieWithValue("lax", "4");
    2121
    2222    debug("<br>Cookies visible in DOM:");
    2323    shouldNotHaveDOMCookie("strict");
    24     shouldNotHaveDOMCookie("implicit-strict");
    25     shouldNotHaveDOMCookie("strict-because-invalid-SameSite-value");
     24    shouldHaveDOMCookieWithValue("implicit-strict", "4");
     25    shouldHaveDOMCookieWithValue("strict-because-invalid-SameSite-value", "4");
    2626    shouldHaveDOMCookieWithValue("lax", "4");
    2727

  • trunk/LayoutTests/http/tests/cookies/same-site/resources/fetch-in-cross-origin-service-worker.html

    r252149 r252153  
    1717    debug("Cookies sent with HTTP request:");
    1818    await shouldNotHaveCookie("strict");
    19     await shouldNotHaveCookie("implicit-strict");
    20     await shouldNotHaveCookie("strict-because-invalid-SameSite-value");
     19    await shouldHaveCookieWithValue("implicit-strict", "10"); // Behaves like a non-SameSite cookie
     20    await shouldHaveCookieWithValue("strict-because-invalid-SameSite-value", "10"); // Behaves like a non-SameSite cookie
    2121    await shouldNotHaveCookie("lax");
    2222

  • trunk/LayoutTests/platform/mac-mojave/http/tests/cookies/same-site/fetch-after-navigating-iframe-in-cross-origin-page-expected.txt

    r252149 r252153  
    1111Cookies sent with HTTP request:
    1212PASS Do not have cookie "strict".
    13 PASS Do not have cookie "implicit-strict".
    14 PASS Do not have cookie "strict-because-invalid-SameSite-value".
     13FAIL Should have cookie "implicit-strict". But do not.
     14FAIL Should have cookie "strict-because-invalid-SameSite-value". But do not.
    1515PASS Do not have cookie "lax".
    1616
    1717Cookies visible in DOM:
    1818PASS Do not have DOM cookie "strict".
    19 PASS Do not have DOM cookie "implicit-strict".
    20 PASS Do not have DOM cookie "strict-because-invalid-SameSite-value".
     19FAIL Should have DOM cookie "implicit-strict". But do not.
     20FAIL Should have DOM cookie "strict-because-invalid-SameSite-value". But do not.
    2121PASS Do not have DOM cookie "lax".
    2222PASS successfullyParsed is true
     23Some tests failed.
    2324
    2425TEST COMPLETE

  • trunk/LayoutTests/platform/mac-mojave/http/tests/cookies/same-site/fetch-after-top-level-cross-origin-redirect-expected.txt

    r252149 r252153  
    66Cookies sent with HTTP request:
    77PASS Do not have cookie "strict".
    8 PASS Do not have cookie "implicit-strict".
    9 PASS Do not have cookie "strict-because-invalid-SameSite-value".
     8FAIL Should have cookie "implicit-strict". But do not.
     9FAIL Should have cookie "strict-because-invalid-SameSite-value". But do not.
    1010PASS Has cookie "lax" with value 19.
    1111
    1212Cookies visible in DOM:
    1313PASS Do not have DOM cookie "strict".
    14 PASS Do not have DOM cookie "implicit-strict".
    15 PASS Do not have DOM cookie "strict-because-invalid-SameSite-value".
     14FAIL Should have DOM cookie "implicit-strict". But do not.
     15FAIL Should have DOM cookie "strict-because-invalid-SameSite-value". But do not.
    1616PASS Has DOM cookie "lax" with value 19.
    1717PASS successfullyParsed is true
     18Some tests failed.
    1819
    1920TEST COMPLETE

  • trunk/LayoutTests/platform/mac-mojave/http/tests/cookies/same-site/fetch-after-top-level-navigation-from-cross-origin-page-expected.txt

    r252149 r252153  
    66Cookies sent with HTTP request:
    77PASS Do not have cookie "strict".
    8 PASS Do not have cookie "implicit-strict".
    9 PASS Do not have cookie "strict-because-invalid-SameSite-value".
     8FAIL Should have cookie "implicit-strict". But do not.
     9FAIL Should have cookie "strict-because-invalid-SameSite-value". But do not.
    1010PASS Has cookie "lax" with value 5.
    1111
    1212Cookies visible in DOM:
    1313PASS Do not have DOM cookie "strict".
    14 PASS Do not have DOM cookie "implicit-strict".
    15 PASS Do not have DOM cookie "strict-because-invalid-SameSite-value".
     14FAIL Should have DOM cookie "implicit-strict". But do not.
     15FAIL Should have DOM cookie "strict-because-invalid-SameSite-value". But do not.
    1616PASS Has DOM cookie "lax" with value 5.
    1717PASS successfullyParsed is true
     18Some tests failed.
    1819
    1920TEST COMPLETE

  • trunk/LayoutTests/platform/mac-mojave/http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page-expected.txt

    r252149 r252153  
    66Cookies sent with HTTP request:
    77PASS Do not have cookie "strict".
    8 PASS Do not have cookie "implicit-strict".
    9 PASS Do not have cookie "strict-because-invalid-SameSite-value".
     8FAIL Should have cookie "implicit-strict". But do not.
     9FAIL Should have cookie "strict-because-invalid-SameSite-value". But do not.
    1010PASS Has cookie "lax" with value 4.
    1111
    1212Cookies visible in DOM:
    1313PASS Do not have DOM cookie "strict".
    14 PASS Do not have DOM cookie "implicit-strict".
    15 PASS Do not have DOM cookie "strict-because-invalid-SameSite-value".
     14FAIL Should have DOM cookie "implicit-strict". But do not.
     15FAIL Should have DOM cookie "strict-because-invalid-SameSite-value". But do not.
    1616PASS Has DOM cookie "lax" with value 4.
    1717PASS successfullyParsed is true
     18Some tests failed.
    1819
    1920TEST COMPLETE

  • trunk/LayoutTests/platform/mac-mojave/http/tests/cookies/same-site/fetch-in-cross-origin-service-worker-expected.txt

    r252149 r252153  
    1111Cookies sent with HTTP request:
    1212PASS Do not have cookie "strict".
    13 PASS Do not have cookie "implicit-strict".
    14 PASS Do not have cookie "strict-because-invalid-SameSite-value".
     13FAIL Should have cookie "implicit-strict". But do not.
     14FAIL Should have cookie "strict-because-invalid-SameSite-value". But do not.
    1515PASS Do not have cookie "lax".
    1616
    … …  
    2121PASS Do not have DOM cookie "lax".
    2222PASS successfullyParsed is true
     23Some tests failed.
    2324
    2425TEST COMPLETE

  • trunk/LayoutTests/platform/mac-mojave/http/tests/cookies/same-site/popup-cross-site-expected.txt

    r252149 r252153  
    11
    2 PASS '127.0.0.1' is not same-site with 'localhost', so strict samesite cookies are not sent.
     2FAIL '127.0.0.1' is not same-site with 'localhost', so strict samesite cookies are not sent. assert_equals: implicit-strict expected (string) "1" but got (undefined) undefined
    33

  • trunk/LayoutTests/platform/mac-mojave/http/tests/cookies/same-site/popup-cross-site-post-expected.txt

    r252149 r252153  
    11
    2 PASS '127.0.0.1' is not same-site with 'localhost', so samesite cookies are not sent via POST.
     2FAIL '127.0.0.1' is not same-site with 'localhost', so samesite cookies are not sent via POST. assert_equals: implicit-strict expected (string) "1" but got (undefined) undefined
    33

  • trunk/LayoutTests/platform/mac-mojave/http/tests/cookies/same-site/popup-same-site-via-cross-site-redirect-expected.txt

    r252149 r252153  
    11
    2 PASS '127.0.0.1' is same-site with itself, so samesite cookies are sent.
     2FAIL '127.0.0.1' is same-site with itself, so samesite cookies are sent. assert_equals: implicit-strict expected (string) "1" but got (undefined) undefined
    33
Note: See TracChangeset for help on using the changeset viewer.