Changeset 252158 in webkit


Ignore:
Timestamp:
Nov 6, 2019 4:00:04 PM (4 years ago)
Author:
commit-queue@webkit.org
Message:

Unreviewed, rolling out r251940.
​https://bugs.webkit.org/show_bug.cgi?id=203920

"it introduced test262 failures" (Requested by rkirsling on
#webkit).

Reverted changeset:

"HasProperty? result of Proxy in prototype chain is
ignored"
​https://bugs.webkit.org/show_bug.cgi?id=203560
​https://trac.webkit.org/changeset/251940

Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/JSTests/ChangeLog

    r252024 r252158  
     12019-11-06  Commit Queue  <commit-queue@webkit.org>
     2
     3        Unreviewed, rolling out r251940.
     4        https://bugs.webkit.org/show_bug.cgi?id=203920
     5
     6        "it introduced test262 failures" (Requested by rkirsling on
     7        #webkit).
     8
     9        Reverted changeset:
     10
     11        "[[HasProperty]] result of Proxy in prototype chain is
     12        ignored"
     13        https://bugs.webkit.org/show_bug.cgi?id=203560
     14        https://trac.webkit.org/changeset/251940
     15
    1162019-11-04  Saam Barati  <sbarati@apple.com>
    217

  • trunk/JSTests/stress/proxy-get-prototype-of.js

    r251940 r252158  
    390390    let handler = {
    391391        getPrototypeOf: function(theTarget) {
     392            assert(theTarget === target);
    392393            called = true;
    393394            return proto;
    … …  
    400401    let proxy = new Proxy(target, handler);
    401402    for (let i = 0; i < 500; i++) {
    402         let result = 1 in proxy;
    403         assert(!called);
     403        let result = "x" in proxy;
     404        assert(called);
     405        called = false;
    404406    }
    405407}

  • trunk/JSTests/test262/expectations.yaml

    r251940 r252158  
    634634  default: 'TypeError: Attempted to assign to readonly property.'
    635635  strict mode: 'TypeError: Attempted to assign to readonly property.'
     636test/built-ins/Array/prototype/indexOf/calls-only-has-on-prototype-after-length-zeroed.js:
     637  default: 'Test262Error: [[GetPrototypeOf]] trap called'
     638  strict mode: 'Test262Error: [[GetPrototypeOf]] trap called'
     639test/built-ins/Array/prototype/lastIndexOf/calls-only-has-on-prototype-after-length-zeroed.js:
     640  default: 'Test262Error: [[GetPrototypeOf]] trap called'
     641  strict mode: 'Test262Error: [[GetPrototypeOf]] trap called'
    636642test/built-ins/Array/prototype/map/target-array-with-non-writable-property.js:
    637643  default: 'TypeError: Attempted to assign to readonly property.'
    … …  
    11481154  default: 'Test262Error: Expected a TypeError but got a TypeError'
    11491155  strict mode: 'Test262Error: Expected a TypeError but got a TypeError'
     1156test/built-ins/Proxy/has/call-in-prototype.js:
     1157  default: 'Test262Error: [[GetPrototypeOf]] trap called'
     1158  strict mode: 'Test262Error: [[GetPrototypeOf]] trap called'
    11501159test/built-ins/Proxy/revocable/revocation-function-name.js:
    11511160  default: 'Test262Error: obj should have an own property name'

  • trunk/Source/JavaScriptCore/ChangeLog

    r252124 r252158  
     12019-11-06  Commit Queue  <commit-queue@webkit.org>
     2
     3        Unreviewed, rolling out r251940.
     4        https://bugs.webkit.org/show_bug.cgi?id=203920
     5
     6        "it introduced test262 failures" (Requested by rkirsling on
     7        #webkit).
     8
     9        Reverted changeset:
     10
     11        "[[HasProperty]] result of Proxy in prototype chain is
     12        ignored"
     13        https://bugs.webkit.org/show_bug.cgi?id=203560
     14        https://trac.webkit.org/changeset/251940
     15
    1162019-11-05  Mark Lam  <mark.lam@apple.com>
    217

  • trunk/Source/JavaScriptCore/runtime/JSObjectInlines.h

    r251940 r252158  
    127127        if (hasSlot)
    128128            return true;
    129         if (object->type() == ProxyObjectType && slot.internalMethodType() == PropertySlot::InternalMethodType::HasProperty)
    130             return false;
    131129        JSValue prototype;
    132130        if (LIKELY(structure->classInfo()->methodTable.getPrototype == defaultGetPrototype || slot.internalMethodType() == PropertySlot::InternalMethodType::VMInquiry))
    … …  
    162160            if (hasSlot)
    163161                return true;
    164             if (object->type() == ProxyObjectType && slot.internalMethodType() == PropertySlot::InternalMethodType::HasProperty)
    165                 return false;
    166162        }
    167163        JSValue prototype;
Note: See TracChangeset for help on using the changeset viewer.