Changeset 252165 in webkit


Ignore:
Timestamp:
Nov 6, 2019 6:04:31 PM (4 years ago)
Author:
Fujii Hironori
Message:

[Win] DumpRenderTree.exe and WebKitTestRunner.exe shouldn't link with WebCoreTestSupport
​https://bugs.webkit.org/show_bug.cgi?id=203879

Reviewed by Ross Kirsling.

After r252086, WinCairo DumpRenderTree.exe and
WebKitTestRunner.exe can't start because they are linked with
WinCairoRequirements DLLs unexpectedly.

DumpRenderTree.exe and WebKitTestRunner.exe are just wrapper
programs. They shouldn't link with WinCairoRequirements libs.

  • DumpRenderTree/PlatformWin.cmake: Set DumpRenderTree_LIBRARIES only shlwapi.
  • WebKitTestRunner/PlatformWin.cmake: Set WebKitTestRunner_LIBRARIES only shlwapi.
Location:
trunk/Tools
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/Tools/ChangeLog

    r252163 r252165  
     12019-11-06  Fujii Hironori  <Hironori.Fujii@sony.com>
     2
     3        [Win] DumpRenderTree.exe and WebKitTestRunner.exe shouldn't link with WebCoreTestSupport
     4        https://bugs.webkit.org/show_bug.cgi?id=203879
     5
     6        Reviewed by Ross Kirsling.
     7
     8        After r252086, WinCairo DumpRenderTree.exe and
     9        WebKitTestRunner.exe can't start because they are linked with
     10        WinCairoRequirements DLLs unexpectedly.
     11
     12        DumpRenderTree.exe and WebKitTestRunner.exe are just wrapper
     13        programs. They shouldn't link with WinCairoRequirements libs.
     14
     15        * DumpRenderTree/PlatformWin.cmake: Set DumpRenderTree_LIBRARIES only shlwapi.
     16        * WebKitTestRunner/PlatformWin.cmake: Set WebKitTestRunner_LIBRARIES only shlwapi.
     17
    1182019-11-06  Kate Cheney  <katherine_cheney@apple.com>
    219

  • trunk/Tools/DumpRenderTree/PlatformWin.cmake

    r249746 r252165  
    6969)
    7070
    71 list(APPEND DumpRenderTree_LIBRARIES
    72     WebKitLegacy
    73     shlwapi
    74 )
    75 
    7671set(DumpRenderTreeLib_LIBRARIES
    7772    ${DumpRenderTree_LIBRARIES}
    7873    Comsuppw
    7974    Oleacc
     75    WebKitLegacy
    8076    WebKitLegacyGUID
     77)
     78
     79set(DumpRenderTree_LIBRARIES
     80    shlwapi
    8181)
    8282

  • trunk/Tools/WebKitTestRunner/PlatformWin.cmake

    r245968 r252165  
    3636)
    3737
    38 list(APPEND WebKitTestRunner_LIBRARIES
    39     WebKit
     38set(WebKitTestRunner_LIBRARIES
     39    shlwapi
    4040)
    4141
Note: See TracChangeset for help on using the changeset viewer.