Changeset 252179 in webkit

Timestamp:

Nov 7, 2019 1:52:27 AM (4 years ago)

Author:

commit-queue@webkit.org

Message:

Indentation in ThreadGlobalData.h is incorrect
​https://bugs.webkit.org/show_bug.cgi?id=203895

Patch by Chris Lord <Chris Lord> on 2019-11-07
Reviewed by Žan Doberšek.

No new tests -- no change in behavior.

• platform/ThreadGlobalData.h:

(WebCore::ThreadGlobalData::ThreadGlobalData::cachedResourceRequestInitiators):
(WebCore::ThreadGlobalData::ThreadGlobalData::eventNames):
(WebCore::ThreadGlobalData::ThreadGlobalData::threadTimers):
(WebCore::ThreadGlobalData::ThreadGlobalData::qualifiedNameCache):
(WebCore::ThreadGlobalData::ThreadGlobalData::cachedConverterICU):
(WebCore::ThreadGlobalData::ThreadGlobalData::currentState const):
(WebCore::ThreadGlobalData::ThreadGlobalData::setCurrentState):
(WebCore::ThreadGlobalData::ThreadGlobalData::isInRemoveAllEventListeners const):
(WebCore::ThreadGlobalData::ThreadGlobalData::setIsInRemoveAllEventListeners):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/ThreadGlobalData.h (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-11-07  Chris Lord  <clord@igalia.com>
+
+        Indentation in ThreadGlobalData.h is incorrect
+        https://bugs.webkit.org/show_bug.cgi?id=203895
+
+        Reviewed by Žan Doberšek.
+
+        No new tests -- no change in behavior.
+
+        * platform/ThreadGlobalData.h:
+        (WebCore::ThreadGlobalData::ThreadGlobalData::cachedResourceRequestInitiators):
+        (WebCore::ThreadGlobalData::ThreadGlobalData::eventNames):
+        (WebCore::ThreadGlobalData::ThreadGlobalData::threadTimers):
+        (WebCore::ThreadGlobalData::ThreadGlobalData::qualifiedNameCache):
+        (WebCore::ThreadGlobalData::ThreadGlobalData::cachedConverterICU):
+        (WebCore::ThreadGlobalData::ThreadGlobalData::currentState const):
+        (WebCore::ThreadGlobalData::ThreadGlobalData::setCurrentState):
+        (WebCore::ThreadGlobalData::ThreadGlobalData::isInRemoveAllEventListeners const):
+        (WebCore::ThreadGlobalData::ThreadGlobalData::setIsInRemoveAllEventListeners):
+
 2019-11-05  Sergio Villar Senin  <svillar@igalia.com>
 

trunk/Source/WebCore/platform/ThreadGlobalData.h

@@ -38 +38 @@
 namespace WebCore {
 
-    class QualifiedNameCache;
-    class ThreadTimers;
+class QualifiedNameCache;
+class ThreadTimers;
 
-    struct CachedResourceRequestInitiators;
-    struct EventNames;
-    struct ICUConverterWrapper;
+struct CachedResourceRequestInitiators;
+struct EventNames;
+struct ICUConverterWrapper;
 
 #if USE(WEB_THREAD)
-    class ThreadGlobalData : public ThreadSafeRefCounted<ThreadGlobalData> {
+class ThreadGlobalData : public ThreadSafeRefCounted<ThreadGlobalData> {
 #else
-    class ThreadGlobalData {
+class ThreadGlobalData {
 #endif
-        WTF_MAKE_NONCOPYABLE(ThreadGlobalData);
-        WTF_MAKE_FAST_ALLOCATED;
-    public:
-        WEBCORE_EXPORT ThreadGlobalData();
-        WEBCORE_EXPORT ~ThreadGlobalData();
-        void destroy(); // called on workers to clean up the ThreadGlobalData before the thread exits.
+    WTF_MAKE_NONCOPYABLE(ThreadGlobalData);
+    WTF_MAKE_FAST_ALLOCATED;
+public:
+    WEBCORE_EXPORT ThreadGlobalData();
+    WEBCORE_EXPORT ~ThreadGlobalData();
+    void destroy(); // called on workers to clean up the ThreadGlobalData before the thread exits.
 
-        const CachedResourceRequestInitiators& cachedResourceRequestInitiators() { return *m_cachedResourceRequestInitiators; }
-        EventNames& eventNames() { return *m_eventNames; }
-        ThreadTimers& threadTimers() { return *m_threadTimers; }
-        QualifiedNameCache& qualifiedNameCache() { return *m_qualifiedNameCache; }
+    const CachedResourceRequestInitiators& cachedResourceRequestInitiators() { return *m_cachedResourceRequestInitiators; }
+    EventNames& eventNames() { return *m_eventNames; }
+    ThreadTimers& threadTimers() { return *m_threadTimers; }
+    QualifiedNameCache& qualifiedNameCache() { return *m_qualifiedNameCache; }
 
-        ICUConverterWrapper& cachedConverterICU() { return *m_cachedConverterICU; }
+    ICUConverterWrapper& cachedConverterICU() { return *m_cachedConverterICU; }
 
-        JSC::JSGlobalObject* currentState() const { return m_currentState; }
-        void setCurrentState(JSC::JSGlobalObject* state) { m_currentState = state; }
+    JSC::JSGlobalObject* currentState() const { return m_currentState; }
+    void setCurrentState(JSC::JSGlobalObject* state) { m_currentState = state; }
 
 #if USE(WEB_THREAD)
-        void setWebCoreThreadData();
+    void setWebCoreThreadData();
 #endif
 
-        bool isInRemoveAllEventListeners() const { return m_isInRemoveAllEventListeners; }
-        void setIsInRemoveAllEventListeners(bool value) { m_isInRemoveAllEventListeners = value; }
+    bool isInRemoveAllEventListeners() const { return m_isInRemoveAllEventListeners; }
+    void setIsInRemoveAllEventListeners(bool value) { m_isInRemoveAllEventListeners = value; }
 
-    private:
-        std::unique_ptr<CachedResourceRequestInitiators> m_cachedResourceRequestInitiators;
-        std::unique_ptr<EventNames> m_eventNames;
-        std::unique_ptr<ThreadTimers> m_threadTimers;
-        std::unique_ptr<QualifiedNameCache> m_qualifiedNameCache;
-        JSC::JSGlobalObject* m_currentState { nullptr };
+private:
+    std::unique_ptr<CachedResourceRequestInitiators> m_cachedResourceRequestInitiators;
+    std::unique_ptr<EventNames> m_eventNames;
+    std::unique_ptr<ThreadTimers> m_threadTimers;
+    std::unique_ptr<QualifiedNameCache> m_qualifiedNameCache;
+    JSC::JSGlobalObject* m_currentState { nullptr };
 
 #ifndef NDEBUG
-        bool m_isMainThread;
+    bool m_isMainThread;
 #endif
 
-        bool m_isInRemoveAllEventListeners { false };
+    bool m_isInRemoveAllEventListeners { false };
 
-        std::unique_ptr<ICUConverterWrapper> m_cachedConverterICU;
+    std::unique_ptr<ICUConverterWrapper> m_cachedConverterICU;
 
-        WEBCORE_EXPORT friend ThreadGlobalData& threadGlobalData();
-    };
+    WEBCORE_EXPORT friend ThreadGlobalData& threadGlobalData();
+};
 
 #if USE(WEB_THREAD)
@@ -97 +97 @@
 WEBCORE_EXPORT ThreadGlobalData& threadGlobalData() PURE_FUNCTION;
 #endif
-    
+
 } // namespace WebCore