Changeset 252183 in webkit

Timestamp:

Nov 7, 2019 6:55:13 AM (4 years ago)

Author:

commit-queue@webkit.org

Message:

ASSERTION FAILED: m_clientCounts.contains(contextId) in WebKit::VideoFullscreenManagerProxy::removeClientForContext(uint64_t)
​https://bugs.webkit.org/show_bug.cgi?id=203918

Patch by Peng Liu <Peng Liu> on 2019-11-07
Reviewed by Jer Noble.

Postpone the transition to exit fullscreen of a video element
before the previous transition of fullscreen mode change is completed.

Fix a flakey layout test (media/video-autoplay.html). No new test is needed.

• WebProcess/cocoa/VideoFullscreenManager.mm:

(WebKit::VideoFullscreenManager::exitVideoFullscreenForVideoElement):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/cocoa/VideoFullscreenManager.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-11-07  Peng Liu  <peng.liu6@apple.com>
+
+        ASSERTION FAILED: m_clientCounts.contains(contextId) in WebKit::VideoFullscreenManagerProxy::removeClientForContext(uint64_t)
+        https://bugs.webkit.org/show_bug.cgi?id=203918
+
+        Reviewed by Jer Noble.
+
+        Postpone the transition to exit fullscreen of a video element
+        before the previous transition of fullscreen mode change is completed.
+
+        Fix a flakey layout test (media/video-autoplay.html). No new test is needed.
+
+        * WebProcess/cocoa/VideoFullscreenManager.mm:
+        (WebKit::VideoFullscreenManager::exitVideoFullscreenForVideoElement):
+
 2019-11-07  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.mm

@@ -300 +300 @@
     interface.setTargetIsFullscreen(false);
 
-    if (interface.animationState() == VideoFullscreenInterfaceContext::AnimationType::FromFullscreen)
+    if (interface.animationState() != VideoFullscreenInterfaceContext::AnimationType::None)
         return;
     interface.setAnimationState(VideoFullscreenInterfaceContext::AnimationType::FromFullscreen);