Changeset 252217 in webkit


Ignore:
Timestamp:
Nov 7, 2019 4:52:28 PM (4 years ago)
Author:
youenn@apple.com
Message:

Layout Test http/tests/appcache/remove-cache.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=199124
<rdar://problem/52008712>

Reviewed by Chris Dumez.

The flakiness probably comes from the use of a setTimeout that might kick in while in most runs, it never kicks in.
When the timer kicks in, the test is reloaded, which triggers a new console log line.
The current console lines do not bring more values than what the test checks with appcache events.
Removing console log lines from the expected file will fix the flakiness.

  • TestExpectations:
  • http/tests/appcache/remove-cache-expected.txt:
  • platform/mac/TestExpectations:
Location:
trunk/LayoutTests
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r252214 r252217  
     12019-11-07  youenn fablet  <youenn@apple.com>
     2
     3        Layout Test http/tests/appcache/remove-cache.html is a flaky failure
     4        https://bugs.webkit.org/show_bug.cgi?id=199124
     5        <rdar://problem/52008712>
     6
     7        Reviewed by Chris Dumez.
     8
     9        The flakiness probably comes from the use of a setTimeout that might kick in while in most runs, it never kicks in.
     10        When the timer kicks in, the test is reloaded, which triggers a new console log line.
     11        The current console lines do not bring more values than what the test checks with appcache events.
     12        Removing console log lines from the expected file will fix the flakiness.
     13
     14        * TestExpectations:
     15        * http/tests/appcache/remove-cache-expected.txt:
     16        * platform/mac/TestExpectations:
     17
    1182019-11-07  Yury Semikhatsky  <yurys@chromium.org>
    219
  • trunk/LayoutTests/TestExpectations

    r252202 r252217  
    21052105
    21062106webkit.org/b/158085 http/tests/css/shared-stylesheet-mutation.html [ Pass Failure ]
     2107
     2108http/tests/appcache/remove-cache.html [ DumpJSConsoleLogInStdErr ]
    21072109
    21082110# PiP tests are only relevant on macOS Sierra and newer.
  • trunk/LayoutTests/http/tests/appcache/remove-cache-expected.txt

    r227225 r252217  
    1 CONSOLE MESSAGE: line 1: ApplicationCache is deprecated. Please use ServiceWorkers instead.
    2 CONSOLE MESSAGE: line 1: ApplicationCache is deprecated. Please use ServiceWorkers instead.
    3 CONSOLE MESSAGE: line 1: ApplicationCache is deprecated. Please use ServiceWorkers instead.
    4 CONSOLE MESSAGE: Application Cache manifest could not be fetched, because the manifest had a 404 response.
    5 CONSOLE MESSAGE: line 1: ApplicationCache is deprecated. Please use ServiceWorkers instead.
    6 CONSOLE MESSAGE: Application Cache manifest could not be fetched, because the manifest had a 404 response.
    7 CONSOLE MESSAGE: line 1: ApplicationCache is deprecated. Please use ServiceWorkers instead.
    81Test that a 404 response for manifest results in cache removal.
    92
  • trunk/LayoutTests/platform/mac/TestExpectations

    r252204 r252217  
    19451945webkit.org/b/181837 [ Release ] imported/w3c/web-platform-tests/service-workers/service-worker/ready.https.html [ Pass Failure ]
    19461946
    1947 webkit.org/b/199124 http/tests/appcache/remove-cache.html [ Pass Failure ]
    1948 
    19491947# rdar://55405851 ([ macOS ] Layout tests webgpu/*-triangle-strip.html are flaky failures. (201827))
    19501948webkit.org/b/201827 webgpu/blend-color-triangle-strip.html [ Pass ImageOnlyFailure ]
Note: See TracChangeset for help on using the changeset viewer.