Changeset 252301 in webkit

Timestamp:

Nov 8, 2019 7:29:14 PM (4 years ago)

Author:

Chris Dumez

Message:

Add back/forward cache quirk for Vimeo.com
​https://bugs.webkit.org/show_bug.cgi?id=204025
<rdar://problem/56996057>

Reviewed by Antti Koivisto.

Vimeo.com used to bypass the back/forward cache by serving "Cache-Control: no-store" over HTTPS.
We started caching such content in r250437 but the vimeo.com content unfortunately is not currently compatible
because it changes the opacity of its body to 0 when navigating away and fails to restore the original opacity
when coming back from the back/forward cache (e.g. in 'pageshow' event handler).

To address the issue, this patch introduces a quirk to restore pre-r250437 on Vimeo.com, until they get
a chance to fix their content.

• history/BackForwardCache.cpp:

(WebCore::canCacheFrame):

• page/DiagnosticLoggingKeys.cpp:

(WebCore::DiagnosticLoggingKeys::siteSpecificQuirkKey):

• page/DiagnosticLoggingKeys.h:
• page/Quirks.cpp:

(WebCore::Quirks::shouldBypassBackForwardCache const):

• page/Quirks.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• history/BackForwardCache.cpp (modified) (2 diffs)
• page/DiagnosticLoggingKeys.cpp (modified) (1 diff)
• page/DiagnosticLoggingKeys.h (modified) (1 diff)
• page/Quirks.cpp (modified) (1 diff)
• page/Quirks.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-11-08  Chris Dumez  <cdumez@apple.com>
+
+        Add back/forward cache quirk for Vimeo.com
+        https://bugs.webkit.org/show_bug.cgi?id=204025
+        <rdar://problem/56996057>
+
+        Reviewed by Antti Koivisto.
+
+        Vimeo.com used to bypass the back/forward cache by serving "Cache-Control: no-store" over HTTPS.
+        We started caching such content in r250437 but the vimeo.com content unfortunately is not currently compatible
+        because it changes the opacity of its body to 0 when navigating away and fails to restore the original opacity
+        when coming back from the back/forward cache (e.g. in 'pageshow' event handler).
+
+        To address the issue, this patch introduces a quirk to restore pre-r250437 on Vimeo.com, until they get
+        a chance to fix their content.
+
+        * history/BackForwardCache.cpp:
+        (WebCore::canCacheFrame):
+        * page/DiagnosticLoggingKeys.cpp:
+        (WebCore::DiagnosticLoggingKeys::siteSpecificQuirkKey):
+        * page/DiagnosticLoggingKeys.h:
+        * page/Quirks.cpp:
+        (WebCore::Quirks::shouldBypassBackForwardCache const):
+        * page/Quirks.h:
+
 2019-11-08  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/WebCore/history/BackForwardCache.cpp

@@ -46 +46 @@
 #include "Logging.h"
 #include "Page.h"
+#include "Quirks.h"
 #include "ScriptDisallowedScope.h"
 #include "Settings.h"
@@ -117 +118 @@
 
     bool isCacheable = true;
+
+    if (frame.isMainFrame() && frame.document()->quirks().shouldBypassBackForwardCache()) {
+        PCLOG("   -Disabled by site-specific quirk");
+        logBackForwardCacheFailureDiagnosticMessage(diagnosticLoggingClient, DiagnosticLoggingKeys::siteSpecificQuirkKey());
+        isCacheable = false;
+    }
+
     // Do not cache error pages (these can be recognized as pages with substitute data or unreachable URLs).
     if (documentLoader->substituteData().isValid() && !documentLoader->substituteData().failingURL().isEmpty()) {

trunk/Source/WebCore/page/DiagnosticLoggingKeys.cpp

@@ -536 +536 @@
 }
 
+String DiagnosticLoggingKeys::siteSpecificQuirkKey()
+{
+    return "siteSpecificQuirk"_s;
+}
+
 String DiagnosticLoggingKeys::streamingMedia()
 {

trunk/Source/WebCore/page/DiagnosticLoggingKeys.h

@@ -150 +150 @@
     static String scriptKey();
     static String serviceWorkerKey();
+    static String siteSpecificQuirkKey();
     WEBCORE_EXPORT static String streamingMedia();
     static String styleSheetKey();

trunk/Source/WebCore/page/Quirks.cpp

@@ -610 +610 @@
 }
 
-}
+bool Quirks::shouldBypassBackForwardCache() const
+{
+    if (!needsQuirks())
+        return false;
+
+    auto topURL = m_document->topDocument().url();
+    auto host = topURL.host();
+
+    // Vimeo.com used to bypass the back/forward cache by serving "Cache-Control: no-store" over HTTPS.
+    // We started caching such content in r250437 but the vimeo.com content unfortunately is not currently compatible
+    // because it changes the opacity of its body to 0 when navigating away and fails to restore the original opacity
+    // when coming back from the back/forward cache (e.g. in 'pageshow' event handler). See <rdar://problem/56996057>.
+    if (topURL.protocolIs("https") && equalLettersIgnoringASCIICase(host, "vimeo.com")) {
+        if (auto* documentLoader = m_document->frame() ? m_document->frame()->loader().documentLoader() : nullptr)
+            return documentLoader->response().cacheControlContainsNoStore();
+    }
+
+    return false;
+}
+
+}

trunk/Source/WebCore/page/Quirks.h

@@ -83 +83 @@
     bool needsFullWidthHeightFullscreenStyleQuirk() const;
 
+    bool shouldBypassBackForwardCache() const;
+
 private:
     bool needsQuirks() const;