Changeset 252305 in webkit

Timestamp:

Nov 8, 2019 10:27:57 PM (4 years ago)

Author:

yurys@chromium.org

Message:

New test inspector-protocol/page/archive.html added in r154828 fails on EFL, Qt, GTK
​https://bugs.webkit.org/show_bug.cgi?id=120682

Reviewed by Devin Rousso.

Generate custom expectations for inspector-protocol/page/archive.html on the platforms
where Page.archive is not supported yet.

• inspector/page/archive.html: 'Not supported' is a valid response on some platforms.
• platform/gtk/TestExpectations:
• platform/gtk/inspector/page/archive-expected.txt: Added.

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• inspector/page/archive.html (modified) (1 diff)
• platform/gtk/TestExpectations (modified) (1 diff)
• platform/gtk/inspector/page (added)
• platform/gtk/inspector/page/archive-expected.txt (added)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-11-08  Yury Semikhatsky  <yurys@chromium.org>
+
+        New test inspector-protocol/page/archive.html added in r154828 fails on EFL, Qt, GTK
+        https://bugs.webkit.org/show_bug.cgi?id=120682
+
+        Reviewed by Devin Rousso.
+
+        Generate custom expectations for inspector-protocol/page/archive.html on the platforms
+        where Page.archive is not supported yet.
+
+        * inspector/page/archive.html: 'Not supported' is a valid response on some platforms.
+        * platform/gtk/TestExpectations:
+        * platform/gtk/inspector/page/archive-expected.txt: Added.
+
 2019-11-08  Peng Liu  <peng.liu6@apple.com>
 

trunk/LayoutTests/inspector/page/archive.html

@@ -7 +7 @@
     InspectorProtocol.sendCommand("Page.enable", {});
     InspectorProtocol.sendCommand("Page.archive", {}, function(event) {
-        var data = event.result.data;
-        if (!data)
-            ProtocolTest.log("FAIL: no data");
-        else if (data.length < 1000)
-            ProtocolTest.log("FAIL: unexpectedly short data. A serialized archive should be pretty large.");
-        else
-            ProtocolTest.log("PASS: Received archive data.");
-
+        if (event.error) {
+            ProtocolTest.fail(`Page.archive returned error: '${event.error.message}'.`);
+        } else {
+            let data = event.result.data;
+            if (!data)
+                ProtocolTest.fail("no data");
+            else if (data.length < 1000)
+                ProtocolTest.fail("unexpectedly short data. A serialized archive should be pretty large.");
+            else
+                ProtocolTest.pass("Received archive data.");
+        }
         ProtocolTest.completeTest();
     });

trunk/LayoutTests/platform/gtk/TestExpectations

@@ -2319 +2319 @@
 webkit.org/b/116957 media/track/track-automatic-subtitles.html [ Timeout ]
 
-webkit.org/b/120682 inspector/page/archive.html [ Timeout ]
-
 webkit.org/b/147518 inspector/debugger/nested-inspectors.html [ Timeout ]