Changeset 252324 in webkit

Timestamp:

Nov 11, 2019 8:23:25 AM (4 years ago)

Author:

aakash_jain@apple.com

Message:

EWS should retry build in case of kill-old-processes failure
​https://bugs.webkit.org/show_bug.cgi?id=203858

Reviewed by Jonathan Bedard.

• BuildSlaveSupport/ews-build/steps.py:

(KillOldProcesses.evaluateCommand): Retry the build in case of failure.
(KillOldProcesses.getResultSummary): Update the build-step summary string.

• BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.

Location:

trunk/Tools

Files:

• BuildSlaveSupport/ews-build/steps.py (modified) (1 diff)
• BuildSlaveSupport/ews-build/steps_unittest.py (modified) (1 diff)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/ews-build/steps.py

@@ -995 +995 @@
     def __init__(self, **kwargs):
         super(KillOldProcesses, self).__init__(timeout=60, logEnviron=False, **kwargs)
+
+    def evaluateCommand(self, cmd):
+        if cmd.didFail():
+            self.build.buildFinished(['Failed to kill old processes, retrying build'], RETRY)
+        return shell.Compile.evaluateCommand(self, cmd)
+
+    def getResultSummary(self):
+        if self.results == FAILURE:
+            return {u'step': u'Failed to kill old processes'}
+        return shell.Compile.getResultSummary(self)
 
 

trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py

@@ -592 +592 @@
             + 2,
         )
-        self.expectOutcome(result=FAILURE, state_string='Killed old processes (failure)')
+        self.expectOutcome(result=FAILURE, state_string='Failed to kill old processes')
         return self.runStep()
 

trunk/Tools/ChangeLog

@@ +1 @@
+2019-11-11  Aakash Jain  <aakash_jain@apple.com>
+
+        EWS should retry build in case of kill-old-processes failure
+        https://bugs.webkit.org/show_bug.cgi?id=203858
+
+        Reviewed by Jonathan Bedard.
+
+        * BuildSlaveSupport/ews-build/steps.py:
+        (KillOldProcesses.evaluateCommand): Retry the build in case of failure.
+        (KillOldProcesses.getResultSummary): Update the build-step summary string.
+        * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
+
 2019-11-09  Dean Jackson  <dino@apple.com>