Changeset 252357 in webkit


Ignore:
Timestamp:
Nov 12, 2019 12:26:33 AM (4 years ago)
Author:
Fujii Hironori
Message:

[Win] UIScriptController::zoomToScale not implemented
​https://bugs.webkit.org/show_bug.cgi?id=180424

Reviewed by Alex Christensen.

Tools:

  • DumpRenderTree/PlatformWin.cmake:
  • DumpRenderTree/win/UIScriptControllerWin.cpp: Added.

(WTR::UIScriptController::create):
(WTR::UIScriptControllerWin::doAsyncTask):
(WTR::UIScriptControllerWin::zoomToScale):
(WTR::UIScriptControllerWin::zoomScale const):

  • DumpRenderTree/win/UIScriptControllerWin.h: Added.

(WTR::UIScriptControllerWin::UIScriptControllerWin):

  • TestRunnerShared/UIScriptContext/UIScriptController.cpp:
  • WebKitTestRunner/PlatformWin.cmake:
  • WebKitTestRunner/win/UIScriptControllerWin.cpp: Added.

(WTR::UIScriptController::create):
(WTR::UIScriptControllerWin::doAsyncTask):
(WTR::UIScriptControllerWin::zoomToScale):
(WTR::UIScriptControllerWin::zoomScale const):

  • WebKitTestRunner/win/UIScriptControllerWin.h: Added.

(WTR::UIScriptControllerWin::UIScriptControllerWin):

LayoutTests:

  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:

Unmarked skipped tests for webkit.org/b/180424.
Marked fast/visual-viewport/client-coordinates-relative-to-layout-viewport.html,
fast/visual-viewport/client-rects-relative-to-layout-viewport.html
and fast/visual-viewport/zoomed-fixed-scroll-down-then-up.html as
Failure.

Location:
trunk
Files:
4 added
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r252353 r252357  
     12019-11-12  Fujii Hironori  <Hironori.Fujii@sony.com>
     2
     3        [Win] UIScriptController::zoomToScale not implemented
     4        https://bugs.webkit.org/show_bug.cgi?id=180424
     5
     6        Reviewed by Alex Christensen.
     7
     8        * platform/win/TestExpectations:
     9        * platform/wincairo/TestExpectations:
     10        Unmarked skipped tests for webkit.org/b/180424.
     11        Marked fast/visual-viewport/client-coordinates-relative-to-layout-viewport.html,
     12        fast/visual-viewport/client-rects-relative-to-layout-viewport.html
     13        and fast/visual-viewport/zoomed-fixed-scroll-down-then-up.html as
     14        Failure.
     15
    1162019-11-11  Ryosuke Niwa  <rniwa@webkit.org>
    217

  • trunk/LayoutTests/platform/win/TestExpectations

    r252325 r252357  
    225225fast/events/autoscroll-when-input-is-offscreen.html [ Skip ]
    226226
    227 # UIScriptController::zoomToScale is not supported.
    228 fast/visual-viewport/client-coordinates-relative-to-layout-viewport.html [ Skip ]
    229 fast/visual-viewport/client-rects-relative-to-layout-viewport.html [ Skip ]
    230 
    231227# UIScriptController::removeViewFromWindow/addViewToWindow is not supported.
    232228pageoverlay/overlay-remove-reinsert-view.html [ Skip ]
    … …  
    692688imported/w3c/web-platform-tests/credential-management/ [ Skip ]
    693689
    694 # UIScriptController::zoomToScale is not implemented on Windows.
    695 webkit.org/b/180424 fast/visual-viewport/resize-event-fired.html [ Skip ]
    696 webkit.org/b/180424 fast/visual-viewport/rtl-zoomed-rects.html [ Skip ]
    697 webkit.org/b/180424 fast/visual-viewport/scroll-event-fired.html [ Skip ]
    698 webkit.org/b/180424 fast/visual-viewport/viewport-dimensions-exclude-custom-scrollbars.html [ Skip ]
    699 webkit.org/b/180424 fast/visual-viewport/viewport-dimensions-exclude-scrollbars.html [ Skip ]
    700 webkit.org/b/180424 fast/visual-viewport/viewport-dimensions-iframe.html [ Skip ]
    701 webkit.org/b/180424 fast/visual-viewport/viewport-dimensions-under-page-zoom.html [ Skip ]
    702 webkit.org/b/180424 fast/visual-viewport/viewport-dimensions.html [ Skip ]
    703 webkit.org/b/180424 fast/visual-viewport/zoomed-fixed-header-and-footer.html [ Skip ]
    704 webkit.org/b/180424 fast/visual-viewport/zoomed-fixed-scroll-down-then-up.html [ Skip ]
    705 webkit.org/b/180424 fast/visual-viewport/zoomed-fixed.html [ Skip ]
    706 webkit.org/b/180424 fast/visual-viewport/zoomed-rects.html [ Skip ]
    707 webkit.org/b/180424 fast/zooming/client-rect-in-fixed-zoomed.html [ Skip ]
    708 webkit.org/b/180424 fast/zooming/uiscript-zooming.html [ Skip ]
     690fast/visual-viewport/client-coordinates-relative-to-layout-viewport.html [ Failure ]
     691fast/visual-viewport/zoomed-fixed-scroll-down-then-up.html [ Failure ]
    709692
    710693################################################################################

  • trunk/LayoutTests/platform/wincairo/TestExpectations

    r250973 r252357  
    531531streams/shadowing-Promise.html [ Failure ]
    532532
    533 # UIScriptController::zoomToScale() is not implemented.
    534 webkit.org/b/180424 fast/visual-viewport/resize-event-fired.html [ Skip ]
    535 webkit.org/b/180424 fast/visual-viewport/rtl-zoomed-rects.html [ Skip ]
    536 webkit.org/b/180424 fast/visual-viewport/scroll-event-fired.html [ Skip ]
    537 webkit.org/b/180424 fast/visual-viewport/viewport-dimensions-exclude-custom-scrollbars.html [ Skip ]
    538 webkit.org/b/180424 fast/visual-viewport/viewport-dimensions-exclude-scrollbars.html [ Skip ]
    539 webkit.org/b/180424 fast/visual-viewport/viewport-dimensions-iframe.html [ Skip ]
    540 webkit.org/b/180424 fast/visual-viewport/viewport-dimensions-under-page-zoom.html [ Skip ]
    541 webkit.org/b/180424 fast/visual-viewport/viewport-dimensions.html [ Skip ]
    542 webkit.org/b/180424 fast/visual-viewport/zoomed-fixed-header-and-footer.html [ Skip ]
    543 webkit.org/b/180424 fast/visual-viewport/zoomed-fixed-scroll-down-then-up.html [ Skip ]
    544 webkit.org/b/180424 fast/visual-viewport/zoomed-fixed.html [ Skip ]
    545 webkit.org/b/180424 fast/visual-viewport/zoomed-rects.html [ Skip ]
    546 webkit.org/b/180424 fast/zooming/client-rect-in-fixed-zoomed.html [ Skip ]
    547 webkit.org/b/180424 fast/zooming/uiscript-zooming.html [ Skip ]
     533fast/visual-viewport/client-rects-relative-to-layout-viewport.html [ Failure ]
     534fast/visual-viewport/zoomed-fixed-scroll-down-then-up.html [ Failure ]
    548535
    549536# eventSender.scheduleAsynchronousClick is not a function.
    … …  
    15551542fast/tokenizer [ Skip ]
    15561543fast/transforms [ Skip ]
    1557 fast/visual-viewport [ Skip ]
    15581544fast/workers/worker-exception-during-navigation.html [ Pass Failure ]
    15591545fast/writing-mode [ Skip ]

  • trunk/Tools/ChangeLog

    r252356 r252357  
     12019-11-12  Fujii Hironori  <Hironori.Fujii@sony.com>
     2
     3        [Win] UIScriptController::zoomToScale not implemented
     4        https://bugs.webkit.org/show_bug.cgi?id=180424
     5
     6        Reviewed by Alex Christensen.
     7
     8        * DumpRenderTree/PlatformWin.cmake:
     9        * DumpRenderTree/win/UIScriptControllerWin.cpp: Added.
     10        (WTR::UIScriptController::create):
     11        (WTR::UIScriptControllerWin::doAsyncTask):
     12        (WTR::UIScriptControllerWin::zoomToScale):
     13        (WTR::UIScriptControllerWin::zoomScale const):
     14        * DumpRenderTree/win/UIScriptControllerWin.h: Added.
     15        (WTR::UIScriptControllerWin::UIScriptControllerWin):
     16        * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
     17        * WebKitTestRunner/PlatformWin.cmake:
     18        * WebKitTestRunner/win/UIScriptControllerWin.cpp: Added.
     19        (WTR::UIScriptController::create):
     20        (WTR::UIScriptControllerWin::doAsyncTask):
     21        (WTR::UIScriptControllerWin::zoomToScale):
     22        (WTR::UIScriptControllerWin::zoomScale const):
     23        * WebKitTestRunner/win/UIScriptControllerWin.h: Added.
     24        (WTR::UIScriptControllerWin::UIScriptControllerWin):
     25
    1262019-11-12  Carlos Garcia Campos  <cgarcia@igalia.com>
    227

  • trunk/Tools/DumpRenderTree/PlatformWin.cmake

    r252165 r252357  
    2222    win/TextInputControllerWin.cpp
    2323    win/UIDelegate.cpp
     24    win/UIScriptControllerWin.cpp
    2425    win/WorkQueueItemWin.cpp
    2526)

  • trunk/Tools/TestRunnerShared/UIScriptContext/UIScriptController.cpp

    r251522 r252357  
    5959}
    6060
    61 #if !PLATFORM(GTK) && !PLATFORM(COCOA)
     61#if !PLATFORM(GTK) && !PLATFORM(COCOA) && !PLATFORM(WIN)
    6262Ref<UIScriptController> UIScriptController::create(UIScriptContext& context)
    6363{

  • trunk/Tools/WebKitTestRunner/PlatformWin.cmake

    r252165 r252357  
    55    win/PlatformWebViewWin.cpp
    66    win/TestControllerWin.cpp
     7    win/UIScriptControllerWin.cpp
    78    win/main.cpp
    89)
Note: See TracChangeset for help on using the changeset viewer.