Changeset 252361 in webkit


Ignore:
Timestamp:
Nov 12, 2019 6:42:11 AM (4 years ago)
Author:
clopez@igalia.com
Message:

[GTK][WPE] Enable CSS Painting API
https://bugs.webkit.org/show_bug.cgi?id=190710

Reviewed by Don Olmstead.

.:

This enables the feature when building with experimental features enabled.

  • Source/cmake/OptionsGTK.cmake:
  • Source/cmake/OptionsWPE.cmake:

Source/WebKit:

Enable the runtime feature by default on GTK/WPE when building with
experimental features enabled.

Covered by existing tests.

  • Shared/WebPreferences.yaml:
  • Shared/WebPreferencesDefaultValues.h:

LayoutTests:

Unskip the tests that now pass.

  • platform/gtk/TestExpectations:
  • platform/wpe/TestExpectations:
Location:
trunk
Files:
9 edited

Legend:

Unmodified
Added
Removed
  • trunk/ChangeLog

    r252126 r252361  
     12019-11-12  Carlos Alberto Lopez Perez  <clopez@igalia.com>
     2
     3        [GTK][WPE] Enable CSS Painting API
     4        https://bugs.webkit.org/show_bug.cgi?id=190710
     5
     6        Reviewed by Don Olmstead.
     7
     8        This enables the feature when building with experimental features enabled.
     9
     10        * Source/cmake/OptionsGTK.cmake:
     11        * Source/cmake/OptionsWPE.cmake:
     12
    1132019-11-06  Carlos Garcia Campos  <cgarcia@igalia.com>
    214
  • trunk/LayoutTests/ChangeLog

    r252360 r252361  
     12019-11-12  Carlos Alberto Lopez Perez  <clopez@igalia.com>
     2
     3        [GTK][WPE] Enable CSS Painting API
     4        https://bugs.webkit.org/show_bug.cgi?id=190710
     5
     6        Reviewed by Don Olmstead.
     7
     8        Unskip the tests that now pass.
     9
     10        * platform/gtk/TestExpectations:
     11        * platform/wpe/TestExpectations:
     12
    1132019-11-12  Carlos Alberto Lopez Perez  <clopez@igalia.com>
    214
  • trunk/LayoutTests/platform/gtk/TestExpectations

    r252359 r252361  
    712712css3/scroll-snap [ Skip ]
    713713
    714 # ENABLE(CSS_PAINTING_API) is disabled.
    715 webkit.org/b/190710 fast/css-custom-paint [ Skip ]
    716 
    717714# ENABLE(WEBVTT_REGIONS) is disabled
    718715webkit.org/b/109570 media/track/regions-webvtt [ Skip ]
  • trunk/LayoutTests/platform/wpe/TestExpectations

    r252359 r252361  
    197197# ENABLE_DARK_MODE_CSS is OFF in WPE.
    198198css-dark-mode [ Skip ]
    199 
    200 # ENABLE(CSS_PAINTING_API) is disabled
    201 webkit.org/b/190710 fast/css-custom-paint [ Skip ]
    202199
    203200# Tests below are copied from wk2 expectations, because we've marked
  • trunk/Source/WebKit/ChangeLog

    r252356 r252361  
     12019-11-12  Carlos Alberto Lopez Perez  <clopez@igalia.com>
     2
     3        [GTK][WPE] Enable CSS Painting API
     4        https://bugs.webkit.org/show_bug.cgi?id=190710
     5
     6        Reviewed by Don Olmstead.
     7
     8        Enable the runtime feature by default on GTK/WPE when building with
     9        experimental features enabled.
     10
     11        Covered by existing tests.
     12
     13        * Shared/WebPreferences.yaml:
     14        * Shared/WebPreferencesDefaultValues.h:
     15
    1162019-11-12  Carlos Garcia Campos  <cgarcia@igalia.com>
    217
  • trunk/Source/WebKit/Shared/WebPreferences.yaml

    r251950 r252361  
    13801380CSSPaintingAPIEnabled:
    13811381  type: bool
    1382   defaultValue: false
     1382  defaultValue: DEFAULT_CSS_PAINTING_API_ENABLED
    13831383  humanReadableName: "CSS Painting API"
    13841384  humanReadableDescription: "Enable the CSS Painting API"
  • trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h

    r251896 r252361  
    280280
    281281#if ENABLE(EXPERIMENTAL_FEATURES) && (PLATFORM(GTK) || PLATFORM(WPE))
     282#define DEFAULT_CSS_PAINTING_API_ENABLED true
    282283#define DEFAULT_CSS_TYPED_OM_ENABLED true
    283284#else
     285#define DEFAULT_CSS_PAINTING_API_ENABLED false
    284286#define DEFAULT_CSS_TYPED_OM_ENABLED false
    285287#endif
  • trunk/Source/cmake/OptionsGTK.cmake

    r252126 r252361  
    165165WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_SHAREABLE_RESOURCE PUBLIC ON)
    166166WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEB_RTC PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})
     167WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_PAINTING_API PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})
    167168WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_TYPED_OM PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})
    168169
  • trunk/Source/cmake/OptionsWPE.cmake

    r251702 r252361  
    6161WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEBGL2 PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})
    6262WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEB_RTC PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})
     63WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_PAINTING_API PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})
    6364WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_TYPED_OM PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})
    6465
Note: See TracChangeset for help on using the changeset viewer.