Changeset 252365 in webkit

Timestamp:

Nov 12, 2019 7:39:48 AM (4 years ago)

Author:

commit-queue@webkit.org

Message:

Picture-in-Picture events are not fired if we switch the Picture-in-Picture mode through modern media controls
​https://bugs.webkit.org/show_bug.cgi?id=203933

Patch by Peng Liu <Peng Liu> on 2019-11-12
Reviewed by Eric Carlson.

When the Picture-in-Picture API is not available, we need to call webkitSetPresentationMode()
of the video element to implement the picture-in-picture feature.

No new tests, covered by test: media/modern-media-controls/pip-support/pip-support-click.html

• Modules/modern-media-controls/media/pip-support.js:

(PiPSupport.prototype.buttonWasPressed):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/modern-media-controls/media/pip-support.js (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-11-12  Peng Liu  <peng.liu6@apple.com>
+
+        Picture-in-Picture events are not fired if we switch the Picture-in-Picture mode through modern media controls
+        https://bugs.webkit.org/show_bug.cgi?id=203933
+
+        Reviewed by Eric Carlson.
+
+        When the Picture-in-Picture API is not available, we need to call webkitSetPresentationMode()
+        of the video element to implement the picture-in-picture feature.
+
+        No new tests, covered by test: media/modern-media-controls/pip-support/pip-support-click.html
+
+        * Modules/modern-media-controls/media/pip-support.js:
+        (PiPSupport.prototype.buttonWasPressed):
+
 2019-11-11  Per Arne Vollan  <pvollan@apple.com>
 

trunk/Source/WebCore/Modules/modern-media-controls/media/pip-support.js

@@ -50 +50 @@
     {
         const media = this.mediaController.media;
+        if (!document.pictureInPictureEnabled) {
+            media.webkitSetPresentationMode(media.webkitPresentationMode === PiPMode ? InlineMode : PiPMode);
+            return;
+        }
+
         if (!document.pictureInPictureElement)
             media.requestPictureInPicture();