Changeset 252416 in webkit

Timestamp:

Nov 13, 2019 10:45:52 AM (4 years ago)

Author:

ysuzuki@apple.com

Message:

[JSC] AI should convert IsCellWithType to constant when Structure set is finite
​https://bugs.webkit.org/show_bug.cgi?id=204141

Reviewed by Saam Barati.

JSTests:

• stress/generator-cell-with-type.js: Added.

(shouldBe):
(shouldThrow):
(test):
(i.shouldThrow):

Source/JavaScriptCore:

We should fold IsCellWithType if Structure set is finite since we have a chance to know what JSType is.

• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

Location:

trunk

Files:

• JSTests/ChangeLog (modified) (1 diff)
• JSTests/stress/generator-cell-with-type.js (added)
• Source/JavaScriptCore/ChangeLog (modified) (1 diff)
• Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h (modified) (1 diff)

trunk/JSTests/ChangeLog

@@ +1 @@
+2019-11-13  Yusuke Suzuki  <ysuzuki@apple.com>
+
+        [JSC] AI should convert IsCellWithType to constant when Structure set is finite
+        https://bugs.webkit.org/show_bug.cgi?id=204141
+
+        Reviewed by Saam Barati.
+
+        * stress/generator-cell-with-type.js: Added.
+        (shouldBe):
+        (shouldThrow):
+        (test):
+        (i.shouldThrow):
+
 2019-11-12  Yusuke Suzuki  <ysuzuki@apple.com>
 

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2019-11-13  Yusuke Suzuki  <ysuzuki@apple.com>
+
+        [JSC] AI should convert IsCellWithType to constant when Structure set is finite
+        https://bugs.webkit.org/show_bug.cgi?id=204141
+
+        Reviewed by Saam Barati.
+
+        We should fold IsCellWithType if Structure set is finite since we have a chance to know what JSType is.
+
+        * dfg/DFGAbstractInterpreterInlines.h:
+        (JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
+
 2019-11-12  Yusuke Suzuki  <ysuzuki@apple.com>
 

trunk/Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h

@@ -1415 +1415 @@
             default:
                 constantWasSet = false;
+                break;
+            }
+            if (constantWasSet)
+                break;
+        }
+
+        if (forNode(node->child1()).m_structure.isFinite()) {
+            bool constantWasSet = false;
+            switch (node->op()) {
+            case IsCellWithType: {
+                bool ok = true;
+                Optional<bool> result;
+                forNode(node->child1()).m_structure.forEach(
+                    [&](RegisteredStructure structure) {
+                        bool matched = structure->typeInfo().type() == node->queriedType();
+                        if (!result)
+                            result = matched;
+                        else {
+                            if (result.value() != matched)
+                                ok = false;
+                        }
+                    });
+                if (ok && result) {
+                    setConstant(node, jsBoolean(result.value()));
+                    constantWasSet = true;
+                }
+                break;
+            }
+            default:
                 break;
             }