Changeset 252420 in webkit


Ignore:
Timestamp:
Nov 13, 2019 11:36:39 AM (4 years ago)
Author:
Devin Rousso
Message:

Web Inspector: inspector/model/remote-object-weak-collection.html is failing
https://bugs.webkit.org/show_bug.cgi?id=202932

Reviewed by Brian Burg.

  • inspector/model/remote-object-weak-collection.html:

Don't generatePreview when evaluating each expression, as that can create additional
references to the object. Use HeapAgent.gc() as that's guaranteed to be synchronous.

Location:
trunk/LayoutTests
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r252419 r252420  
     12019-11-13  Devin Rousso  <drousso@apple.com>
     2
     3        Web Inspector: inspector/model/remote-object-weak-collection.html is failing
     4        https://bugs.webkit.org/show_bug.cgi?id=202932
     5
     6        Reviewed by Brian Burg.
     7
     8        * inspector/model/remote-object-weak-collection.html:
     9        Don't `generatePreview` when evaluating each expression, as that can create additional
     10        references to the object. Use `HeapAgent.gc()` as that's guaranteed to be synchronous.
     11
    1122019-11-13  Antti Koivisto  <antti@apple.com>
    213
  • trunk/LayoutTests/inspector/model/remote-object-weak-collection.html

    r250087 r252420  
    5555        // Run the expression, and then run a garbage collection on a different
    5656        // event loop so no objects are kept alive by the stack.
    57         WI.runtimeManager.evaluateInInspectedWindow(step.expression, {objectGroup: "test", doNotPauseOnExceptionsAndMuteConsole: true, generatePreview: true}, function(remoteObject, wasThrown) {
    58             WI.runtimeManager.evaluateInInspectedWindow("GCController.collect()", {objectGroup: "test", doNotPauseOnExceptionsAndMuteConsole: true}, function() {
    59                 InspectorTest.assert(remoteObject instanceof WI.RemoteObject);
     57        WI.runtimeManager.evaluateInInspectedWindow(step.expression, {objectGroup: "test", doNotPauseOnExceptionsAndMuteConsole: true}, function(remoteObject, wasThrown) {
     58            InspectorTest.assert(remoteObject instanceof WI.RemoteObject);
     59            InspectorTest.assert(!wasThrown);
     60
     61            HeapAgent.gc(function(error) {
     62                InspectorTest.assert(!error, error);
     63
    6064                remoteObject.getCollectionEntries(function(entries) {
    6165                    InspectorTest.log("ENTRIES:");
Note: See TracChangeset for help on using the changeset viewer.