Changeset 25248 in webkit

Timestamp:

Aug 25, 2007 12:02:35 PM (17 years ago)

Author:

bdash

Message:

2007-08-25 Mitz Pettel <​mitz@webkit.org>

Reviewed by Sam Weinig.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=15077 REGRESSION: Cannot drag selected text out of a background window

• manual-tests/drag-out-of-background-window.html: Added.
• page/EventHandler.cpp: (WebCore::EventHandler::eventMayStartDrag): Added missing coordinate conversion.

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• manual-tests/drag-out-of-background-window.html (added)
• page/EventHandler.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2007-08-25  Mitz Pettel  <mitz@webkit.org>
+
+        Reviewed by Sam Weinig.
+
+        - fix http://bugs.webkit.org/show_bug.cgi?id=15077
+          REGRESSION: Cannot drag selected text out of a background window
+
+        * manual-tests/drag-out-of-background-window.html: Added.
+        * page/EventHandler.cpp:
+        (WebCore::EventHandler::eventMayStartDrag): Added missing coordinate
+        conversion.
+
 2007-08-25  Rob Buis  <buis@kde.org>
 

trunk/WebCore/page/EventHandler.cpp

@@ -373 +373 @@
     
     HitTestRequest request(true, false);
-    HitTestResult result(event.pos());
+    HitTestResult result(m_frame->view()->windowToContents(event.pos()));
     m_frame->renderer()->layer()->hitTest(request, result);
     bool srcIsDHTML;
-    return result.innerNode() && result.innerNode()->renderer()->draggableNode(DHTMLFlag, UAFlag, event.x(), event.y(), srcIsDHTML);
+    return result.innerNode() && result.innerNode()->renderer()->draggableNode(DHTMLFlag, UAFlag, result.point().x(), result.point().y(), srcIsDHTML);
 }