Changeset 252489 in webkit


Ignore:
Timestamp:
Nov 15, 2019 10:00:42 AM (4 years ago)
Author:
Jonathan Bedard
Message:

run-webkit-tests loads committers.py 4 times, taking about 40ms
https://bugs.webkit.org/show_bug.cgi?id=204211

Reviewed by Aakash Jain.

  • Scripts/webkitpy/common/checkout/changelog.py:

(ChangeLogEntry): Don't create CommitterList on import.

  • Scripts/webkitpy/common/checkout/commitinfo.py:

(CommitInfo.init): Ditto.

Location:
trunk/Tools
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r252485 r252489  
     12019-11-15  Jonathan Bedard  <jbedard@apple.com>
     2
     3        run-webkit-tests loads committers.py 4 times, taking about 40ms
     4        https://bugs.webkit.org/show_bug.cgi?id=204211
     5
     6        Reviewed by Aakash Jain.
     7
     8        * Scripts/webkitpy/common/checkout/changelog.py:
     9        (ChangeLogEntry): Don't create CommitterList on import.
     10        * Scripts/webkitpy/common/checkout/commitinfo.py:
     11        (CommitInfo.__init__): Ditto.
     12
    1132019-11-15  Aakash Jain  <aakash_jain@apple.com>
    214
  • trunk/Tools/Scripts/webkitpy/common/checkout/changelog.py

    r251613 r252489  
    108108    split_names_regexp = r'\s*(?:,(?:\s+and\s+|&)?|(?:^|\s+)and\s+|&&|[/+&])\s*'
    109109
    110     def __init__(self, contents, committer_list=CommitterList(), revision=None):
     110    def __init__(self, contents, committer_list=None, revision=None):
    111111        self._contents = contents
    112         self._committer_list = committer_list
     112        self._committer_list = committer_list or CommitterList()
    113113        self._revision = revision
    114114        self._parse_entry()
  • trunk/Tools/Scripts/webkitpy/common/checkout/commitinfo.py

    r202362 r252489  
    3434
    3535class CommitInfo(object):
    36     def __init__(self, revision, committer_email, changelog_data, committer_list=CommitterList()):
     36    def __init__(self, revision, committer_email, changelog_data, committer_list=None):
    3737        self._revision = revision
    3838        self._committer_email = committer_email
     
    4040
    4141        # Derived values:
    42         self._committer = committer_list.committer_by_email(committer_email)
     42        self._committer = (committer_list or CommitterList()).committer_by_email(committer_email)
    4343
    4444    def revision(self):
Note: See TracChangeset for help on using the changeset viewer.