Changeset 252625 in webkit

Timestamp:

Nov 19, 2019 4:45:53 AM (4 years ago)

Author:

commit-queue@webkit.org

Message:

Setup EWS queues for JSConly 32bits ARMv7 and MIPSel
​https://bugs.webkit.org/show_bug.cgi?id=203946

Patch by Paulo Matos <Paulo Matos> on 2019-11-19
Reviewed by Aakash Jain.

Naming of queues follow old EWS: jsc-mips for MIPSel
and jsc-armv7 for ARMv7.

• BuildSlaveSupport/ews-build/config.json:
• BuildSlaveSupport/ews-build/steps.py:

(RunJavaScriptCoreTests.start):
(PrintConfiguration.run):

• BuildSlaveSupport/ews-build/steps_unittest.py:

(TestRunJavaScriptCoreTests.test_remote_success):

Location:

trunk/Tools

Files:

• BuildSlaveSupport/ews-build/config.json (modified) (3 diffs)
• BuildSlaveSupport/ews-build/steps.py (modified) (2 diffs)
• BuildSlaveSupport/ews-build/steps_unittest.py (modified) (1 diff)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/ews-build/config.json

@@ -5 +5 @@
       "platform": "*",
       "max_builds": 3
+    },
+    {
+      "name": "igalia-jsc32-armv7-ews",
+      "platform": "jsc-only"
+    },
+    {
+      "name": "igalia-jsc32-mipsel-ews",
+      "platform": "jsc-only"
     },
     {
@@ -418 +426 @@
     },
     {
+      "name": "JSC-MIPSEL-32bits-EWS",
+      "shortname": "jsc-mips",
+      "icon": "buildAndTest",
+      "factory": "JSCTestsFactory",
+      "platform": "jsc-only",
+      "configuration": "release",
+      "architectures": ["mipsel"],
+      "workernames": ["igalia-jsc32-mipsel-ews"],
+      "remotes": "../../EWS-test-devices.json"
+    },
+    {
+      "name": "JSC-ARMv7-32bits-EWS",
+      "shortname": "jsc-armv7",
+      "icon": "buildAndTest",
+      "factory": "JSCTestsFactory",
+      "platform": "jsc-only",
+      "configuration": "release",
+      "architectures": ["armv7"],
+      "workernames": ["igalia-jsc32-armv7-ews"],
+      "remotes": "../../EWS-test-devices.json"
+    },
+    {
       "name": "Bindings-Tests-EWS",
       "shortname": "bindings",
@@ -472 +502 @@
       "port": 5555,
       "builderNames": ["Apply-WatchList-EWS", "Bindings-Tests-EWS", "GTK-Webkit2-EWS", "iOS-13-Build-EWS", "iOS-13-Simulator-Build-EWS",
-                       "JSC-Tests-EWS", "macOS-High-Sierra-Debug-Build-EWS", "macOS-High-Sierra-Release-Build-EWS",
+                       "JSC-ARMv7-32bits-EWS", "JSC-MIPSEL-32bits-EWS", "JSC-Tests-EWS", "macOS-High-Sierra-Debug-Build-EWS", "macOS-High-Sierra-Release-Build-EWS",
                        "Services-EWS", "Style-EWS", "WebKitPerl-Tests-EWS", "WebKitPy-Tests-EWS", "WPE-EWS", "WinCairo-EWS"]
     },

trunk/Tools/BuildSlaveSupport/ews-build/steps.py

@@ -964 +964 @@
             self.command.append('--remote-config-file={0}'.format(remotesfile))
 
+        platform = self.getProperty('platform')
+        if platform == 'jsc-only' and remotesfile:
+            self.command.extend(['--no-testmasm', '--no-testair', '--no-testb3', '--no-testdfg', '--no-testapi', '--memory-limited'])
         appendCustomBuildFlags(self, self.getProperty('platform'), self.getProperty('fullPlatform'))
         return shell.Test.start(self)
@@ -1888 +1891 @@
         command_list = list(self.command_list_generic)
         platform = self.getProperty('platform', '*')
-        platform = platform.split('-')[0]
+        if platform != 'jsc-only':
+            platform = platform.split('-')[0]
         if platform in ('mac', 'ios', '*'):
             command_list.extend(self.command_list_apple)
-        elif platform in ('gtk', 'wpe'):
+        elif platform in ('gtk', 'wpe', 'jsc-only'):
             command_list.extend(self.command_list_linux)
         elif platform in ('win', 'wincairo'):

trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py

@@ -1039 +1039 @@
             ExpectShell(workdir='wkdir',
                         logEnviron=False,
-                        command=['perl', 'Tools/Scripts/run-javascriptcore-tests', '--no-build', '--no-fail-fast', '--json-output={0}'.format(self.jsonFileName), '--release', '--remote-config-file=remote-machines.json', '--jsc-only'],
+                        command=['perl', 'Tools/Scripts/run-javascriptcore-tests', '--no-build', '--no-fail-fast', '--json-output={0}'.format(self.jsonFileName), '--release', '--remote-config-file=remote-machines.json', '--no-testmasm', '--no-testair', '--no-testb3', '--no-testdfg', '--no-testapi', '--memory-limited', '--jsc-only'],
                         logfiles={'json': self.jsonFileName},
                         )

trunk/Tools/ChangeLog

@@ +1 @@
+2019-11-19  Paulo Matos  <pmatos@igalia.com>
+
+        Setup EWS queues for JSConly 32bits ARMv7 and MIPSel
+        https://bugs.webkit.org/show_bug.cgi?id=203946
+
+        Reviewed by Aakash Jain.
+
+        Naming of queues follow old EWS: jsc-mips for MIPSel
+        and jsc-armv7 for ARMv7.
+
+        * BuildSlaveSupport/ews-build/config.json:
+        * BuildSlaveSupport/ews-build/steps.py:
+        (RunJavaScriptCoreTests.start):
+        (PrintConfiguration.run):
+        * BuildSlaveSupport/ews-build/steps_unittest.py:
+        (TestRunJavaScriptCoreTests.test_remote_success):
+
 2019-11-18  John Wilander  <wilander@apple.com>