Changeset 252655 in webkit


Ignore:
Timestamp:
Nov 19, 2019 4:32:19 PM (4 years ago)
Author:
Chris Dumez
Message:

Protect MessageReceivers when possible while they are processing incoming IPC messages
https://bugs.webkit.org/show_bug.cgi?id=204377

Reviewed by Brady Eidson.

Protect MessageReceiver while they are processing incoming IPC messages for
extra safety. It is a common mistake to call client delegates as a result of an IPC, and
failing to protect |this| while doing so. Client code can destroy |this| and we end up
crashing.

For MessageReceivers that are not RefCounted, they can use the "NotRefCounted" attribute
in their messages.in file to opt out.

  • NetworkProcess/Cookies/WebCookieManager.messages.in:
  • NetworkProcess/CustomProtocols/LegacyCustomProtocolManager.messages.in:
  • NetworkProcess/IndexedDB/WebIDBConnectionToClient.messages.in:
  • NetworkProcess/NetworkContentRuleListManager.messages.in:
  • NetworkProcess/NetworkSocketChannel.messages.in:
  • NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.messages.in:
  • NetworkProcess/ServiceWorker/WebSWServerConnection.messages.in:
  • NetworkProcess/ServiceWorker/WebSWServerToContextConnection.messages.in:
  • NetworkProcess/webrtc/NetworkMDNSRegister.messages.in:
  • NetworkProcess/webrtc/NetworkRTCMonitor.messages.in:
  • NetworkProcess/webrtc/NetworkRTCSocket.messages.in:
  • PluginProcess/PluginControllerProxy.messages.in:
  • PluginProcess/PluginProcess.messages.in:
  • Scripts/webkit/messages.py:
  • Shared/API/Cocoa/RemoteObjectRegistry.messages.in:
  • Shared/ApplePay/WebPaymentCoordinatorProxy.messages.in:
  • Shared/Authentication/AuthenticationManager.messages.in:
  • Shared/AuxiliaryProcess.messages.in:
  • Shared/Plugins/NPObjectMessageReceiver.messages.in:
  • UIProcess/Cocoa/UserMediaCaptureManagerProxy.messages.in:
  • UIProcess/DrawingAreaProxy.messages.in:
  • UIProcess/Network/CustomProtocols/LegacyCustomProtocolManagerProxy.messages.in:
  • UIProcess/Network/NetworkProcessProxy.messages.in:
  • UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.messages.in:
  • UIProcess/ViewGestureController.messages.in:
  • UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.messages.in:
  • UIProcess/WebFullScreenManagerProxy.messages.in:
  • UIProcess/WebPasteboardProxy.messages.in:
  • UIProcess/ios/SmartMagnificationController.messages.in:
  • WebProcess/ApplePay/WebPaymentCoordinator.messages.in:
  • WebProcess/Automation/WebAutomationSessionProxy.messages.in:
  • WebProcess/Geolocation/WebGeolocationManager.messages.in:
  • WebProcess/Network/webrtc/WebMDNSRegister.messages.in:
  • WebProcess/Network/webrtc/WebRTCMonitor.messages.in:
  • WebProcess/Network/webrtc/WebRTCResolver.messages.in:
  • WebProcess/Network/webrtc/WebRTCSocket.messages.in:
  • WebProcess/Notifications/WebNotificationManager.messages.in:
  • WebProcess/Storage/WebSWContextManagerConnection.messages.in:
  • WebProcess/WebPage/DrawingArea.messages.in:
  • WebProcess/WebPage/ViewGestureGeometryCollector.messages.in:
  • WebProcess/WebProcess.messages.in:
  • WebProcess/cocoa/UserMediaCaptureManager.messages.in:
Location:
trunk/Source/WebKit
Files:
43 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit/ChangeLog

    r252643 r252655  
     12019-11-19  Chris Dumez  <cdumez@apple.com>
     2
     3        Protect MessageReceivers when possible while they are processing incoming IPC messages
     4        https://bugs.webkit.org/show_bug.cgi?id=204377
     5
     6        Reviewed by Brady Eidson.
     7
     8        Protect MessageReceiver while they are processing incoming IPC messages for
     9        extra safety. It is a common mistake to call client delegates as a result of an IPC, and
     10        failing to protect |this| while doing so. Client code can destroy |this| and we end up
     11        crashing.
     12
     13        For MessageReceivers that are not RefCounted, they can use the "NotRefCounted" attribute
     14        in their messages.in file to opt out.
     15
     16        * NetworkProcess/Cookies/WebCookieManager.messages.in:
     17        * NetworkProcess/CustomProtocols/LegacyCustomProtocolManager.messages.in:
     18        * NetworkProcess/IndexedDB/WebIDBConnectionToClient.messages.in:
     19        * NetworkProcess/NetworkContentRuleListManager.messages.in:
     20        * NetworkProcess/NetworkSocketChannel.messages.in:
     21        * NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.messages.in:
     22        * NetworkProcess/ServiceWorker/WebSWServerConnection.messages.in:
     23        * NetworkProcess/ServiceWorker/WebSWServerToContextConnection.messages.in:
     24        * NetworkProcess/webrtc/NetworkMDNSRegister.messages.in:
     25        * NetworkProcess/webrtc/NetworkRTCMonitor.messages.in:
     26        * NetworkProcess/webrtc/NetworkRTCSocket.messages.in:
     27        * PluginProcess/PluginControllerProxy.messages.in:
     28        * PluginProcess/PluginProcess.messages.in:
     29        * Scripts/webkit/messages.py:
     30        * Shared/API/Cocoa/RemoteObjectRegistry.messages.in:
     31        * Shared/ApplePay/WebPaymentCoordinatorProxy.messages.in:
     32        * Shared/Authentication/AuthenticationManager.messages.in:
     33        * Shared/AuxiliaryProcess.messages.in:
     34        * Shared/Plugins/NPObjectMessageReceiver.messages.in:
     35        * UIProcess/Cocoa/UserMediaCaptureManagerProxy.messages.in:
     36        * UIProcess/DrawingAreaProxy.messages.in:
     37        * UIProcess/Network/CustomProtocols/LegacyCustomProtocolManagerProxy.messages.in:
     38        * UIProcess/Network/NetworkProcessProxy.messages.in:
     39        * UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.messages.in:
     40        * UIProcess/ViewGestureController.messages.in:
     41        * UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.messages.in:
     42        * UIProcess/WebFullScreenManagerProxy.messages.in:
     43        * UIProcess/WebPasteboardProxy.messages.in:
     44        * UIProcess/ios/SmartMagnificationController.messages.in:
     45        * WebProcess/ApplePay/WebPaymentCoordinator.messages.in:
     46        * WebProcess/Automation/WebAutomationSessionProxy.messages.in:
     47        * WebProcess/Geolocation/WebGeolocationManager.messages.in:
     48        * WebProcess/Network/webrtc/WebMDNSRegister.messages.in:
     49        * WebProcess/Network/webrtc/WebRTCMonitor.messages.in:
     50        * WebProcess/Network/webrtc/WebRTCResolver.messages.in:
     51        * WebProcess/Network/webrtc/WebRTCSocket.messages.in:
     52        * WebProcess/Notifications/WebNotificationManager.messages.in:
     53        * WebProcess/Storage/WebSWContextManagerConnection.messages.in:
     54        * WebProcess/WebPage/DrawingArea.messages.in:
     55        * WebProcess/WebPage/ViewGestureGeometryCollector.messages.in:
     56        * WebProcess/WebProcess.messages.in:
     57        * WebProcess/cocoa/UserMediaCaptureManager.messages.in:
     58
    1592019-11-19  Per Arne Vollan  <pvollan@apple.com>
    260
  • trunk/Source/WebKit/NetworkProcess/Cookies/WebCookieManager.messages.in

    r251011 r252655  
    2424 */
    2525 
    26 messages -> WebCookieManager {
     26messages -> WebCookieManager NotRefCounted {
    2727    void GetHostnamesWithCookies(PAL::SessionID sessionID) -> (Vector<String> hostnames) Async
    2828    void DeleteCookiesForHostnames(PAL::SessionID sessionID, Vector<String> hostnames)
  • trunk/Source/WebKit/NetworkProcess/CustomProtocols/LegacyCustomProtocolManager.messages.in

    r213441 r252655  
    2121# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
    2222
    23 messages -> LegacyCustomProtocolManager {
     23messages -> LegacyCustomProtocolManager NotRefCounted {
    2424    DidFailWithError(uint64_t customProtocolID, WebCore::ResourceError error)
    2525    DidLoadData(uint64_t customProtocolID, IPC::DataReference data)
  • trunk/Source/WebKit/NetworkProcess/IndexedDB/WebIDBConnectionToClient.messages.in

    r252060 r252655  
    2323#if ENABLE(INDEXED_DATABASE)
    2424
    25 messages -> WebIDBConnectionToClient {
     25messages -> WebIDBConnectionToClient NotRefCounted {
    2626    DeleteDatabase(WebCore::IDBRequestData requestData)
    2727    OpenDatabase(WebCore::IDBRequestData requestData);
  • trunk/Source/WebKit/NetworkProcess/NetworkContentRuleListManager.messages.in

    r230223 r252655  
    2323#if ENABLE(CONTENT_EXTENSIONS)
    2424
    25 messages -> NetworkContentRuleListManager {
     25messages -> NetworkContentRuleListManager NotRefCounted {
    2626    Remove(WebKit::UserContentControllerIdentifier identifier)
    2727    AddContentRuleLists(WebKit::UserContentControllerIdentifier identifier, Vector<std::pair<String, WebKit::WebCompiledContentRuleListData>> contentFilters)
  • trunk/Source/WebKit/NetworkProcess/NetworkSocketChannel.messages.in

    r246388 r252655  
    2121# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
    2222
    23 messages -> NetworkSocketChannel {
     23messages -> NetworkSocketChannel NotRefCounted {
    2424    SendString(String message) -> () Async
    2525    SendData(IPC::DataReference data) -> () Async
  • trunk/Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.messages.in

    r242503 r252655  
    2323#if ENABLE(SERVICE_WORKER)
    2424
    25 messages -> ServiceWorkerFetchTask {
     25messages -> ServiceWorkerFetchTask NotRefCounted {
    2626    DidNotHandle()
    2727    DidFail(WebCore::ResourceError error)
  • trunk/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.messages.in

    r251124 r252655  
    2323#if ENABLE(SERVICE_WORKER)
    2424
    25 messages -> WebSWServerConnection {
     25messages -> WebSWServerConnection NotRefCounted {
    2626    # When possible, these messages can be implemented directly by WebCore::SWClientConnection
    2727    ScheduleJobInServer(struct WebCore::ServiceWorkerJobData jobData)
  • trunk/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.messages.in

    r250041 r252655  
    2323#if ENABLE(SERVICE_WORKER)
    2424
    25 messages -> WebSWServerToContextConnection {
     25messages -> WebSWServerToContextConnection NotRefCounted {
    2626    # When possible, these messages can be implemented directly by WebCore::SWServerToContextConnection
    2727
  • trunk/Source/WebKit/NetworkProcess/webrtc/NetworkMDNSRegister.messages.in

    r249980 r252655  
    2323#if ENABLE(WEB_RTC)
    2424
    25 messages -> NetworkMDNSRegister {
     25messages -> NetworkMDNSRegister NotRefCounted {
    2626    UnregisterMDNSNames(WebCore::DocumentIdentifier documentIdentifier)
    2727    RegisterMDNSName(uint64_t requestIdentifier, WebCore::DocumentIdentifier documentIdentifier, String ipAddress)
  • trunk/Source/WebKit/NetworkProcess/webrtc/NetworkRTCMonitor.messages.in

    r211441 r252655  
    2323#if USE(LIBWEBRTC)
    2424
    25 messages -> NetworkRTCMonitor {
     25messages -> NetworkRTCMonitor NotRefCounted {
    2626    void StartUpdating()
    2727    void StopUpdating()
  • trunk/Source/WebKit/NetworkProcess/webrtc/NetworkRTCSocket.messages.in

    r222894 r252655  
    2323#if USE(LIBWEBRTC)
    2424
    25 messages -> NetworkRTCSocket {
     25messages -> NetworkRTCSocket NotRefCounted {
    2626    void SendTo(IPC::DataReference data, WebKit::RTCNetwork::SocketAddress address, struct WebKit::RTCPacketOptions options)
    2727    void Close()
  • trunk/Source/WebKit/PluginProcess/PluginControllerProxy.messages.in

    r243345 r252655  
    2323#if ENABLE(NETSCAPE_PLUGIN_API)
    2424
    25 messages -> PluginControllerProxy LegacyReceiver {
     25messages -> PluginControllerProxy LegacyReceiver NotRefCounted {
    2626    # Sent when the plug-in geometry changes.
    2727    GeometryDidChange(WebCore::IntSize pluginSize, WebCore::IntRect clipRect, WebCore::AffineTransform pluginToRootViewTransform, float scaleFactor, WebKit::ShareableBitmap::Handle backingStoreHandle)
  • trunk/Source/WebKit/PluginProcess/PluginProcess.messages.in

    r231771 r252655  
    2323#if ENABLE(NETSCAPE_PLUGIN_API)
    2424
    25 messages -> PluginProcess LegacyReceiver {
     25messages -> PluginProcess LegacyReceiver NotRefCounted {
    2626    # Initializes the plug-in process.
    2727    InitializePluginProcess(struct WebKit::PluginProcessCreationParameters processCreationParameters)
  • trunk/Source/WebKit/Scripts/webkit/messages.py

    r252274 r252655  
    2929WANTS_CONNECTION_ATTRIBUTE = 'WantsConnection'
    3030LEGACY_RECEIVER_ATTRIBUTE = 'LegacyReceiver'
     31NOT_REFCOUNTED_RECEIVER_ATTRIBUTE = 'NotRefCounted'
    3132SYNCHRONOUS_ATTRIBUTE = 'Synchronous'
    3233ASYNC_ATTRIBUTE = 'Async'
     
    754755        result.append('void %s::didReceive%sMessage(IPC::Connection& connection, IPC::Decoder& decoder)\n' % (receiver.name, receiver.name if receiver.has_attribute(LEGACY_RECEIVER_ATTRIBUTE) else ''))
    755756        result.append('{\n')
     757        if not receiver.has_attribute(NOT_REFCOUNTED_RECEIVER_ATTRIBUTE):
     758            result.append('    auto protectedThis = makeRef(*this);\n')
     759
    756760        result += [async_message_statement(receiver, message) for message in async_messages]
    757761        if (receiver.superclass):
     
    767771        result.append('void %s::didReceiveSync%sMessage(IPC::Connection& connection, IPC::Decoder& decoder, std::unique_ptr<IPC::Encoder>& replyEncoder)\n' % (receiver.name, receiver.name if receiver.has_attribute(LEGACY_RECEIVER_ATTRIBUTE) else ''))
    768772        result.append('{\n')
     773        if not receiver.has_attribute(NOT_REFCOUNTED_RECEIVER_ATTRIBUTE):
     774            result.append('    auto protectedThis = makeRef(*this);\n')
    769775        result += [sync_message_statement(receiver, message) for message in sync_messages]
    770776        result.append('    UNUSED_PARAM(connection);\n')
  • trunk/Source/WebKit/Shared/API/Cocoa/RemoteObjectRegistry.messages.in

    r204245 r252655  
    2121# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
    2222
    23 messages -> RemoteObjectRegistry {
     23messages -> RemoteObjectRegistry NotRefCounted {
    2424    InvokeMethod(WebKit::RemoteObjectInvocation invocation)
    2525    CallReplyBlock(uint64_t replyID, WebKit::UserData blockInvocation);
  • trunk/Source/WebKit/Shared/ApplePay/WebPaymentCoordinatorProxy.messages.in

    r249975 r252655  
    2525#if ENABLE(APPLE_PAY)
    2626
    27 messages -> WebPaymentCoordinatorProxy {
     27messages -> WebPaymentCoordinatorProxy NotRefCounted {
    2828
    2929    CanMakePayments() -> (bool result) Synchronous
  • trunk/Source/WebKit/Shared/Authentication/AuthenticationManager.messages.in

    r237110 r252655  
    2121# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
    2222
    23 messages -> AuthenticationManager {
     23messages -> AuthenticationManager NotRefCounted {
    2424    void CompleteAuthenticationChallenge(uint64_t challengeID, enum:uint8_t WebKit::AuthenticationChallengeDisposition disposition, WebCore::Credential credential);
    2525}
  • trunk/Source/WebKit/Shared/AuxiliaryProcess.messages.in

    r250728 r252655  
    2121# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
    2222
    23 messages -> AuxiliaryProcess {
     23messages -> AuxiliaryProcess NotRefCounted {
    2424    ShutDown()
    2525    SetProcessSuppressionEnabled(bool flag)
  • trunk/Source/WebKit/Shared/Plugins/NPObjectMessageReceiver.messages.in

    r243345 r252655  
    2323#if ENABLE(NETSCAPE_PLUGIN_API)
    2424
    25 messages -> NPObjectMessageReceiver LegacyReceiver {
     25messages -> NPObjectMessageReceiver LegacyReceiver NotRefCounted {
    2626    Deallocate() -> () Synchronous
    2727    HasMethod(WebKit::NPIdentifierData methodName) -> (bool returnValue) Synchronous
  • trunk/Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.messages.in

    r243345 r252655  
    2424#if ENABLE(MEDIA_STREAM)
    2525
    26 messages -> UserMediaCaptureManagerProxy {
     26messages -> UserMediaCaptureManagerProxy NotRefCounted {
    2727    CreateMediaSourceForCaptureDeviceWithConstraints(uint64_t id, WebCore::CaptureDevice device, String hashSalt, struct WebCore::MediaConstraints constraints) -> (bool success, String invalidConstraints, WebCore::RealtimeMediaSourceSettings settings) Synchronous
    2828    StartProducingData(uint64_t id)
  • trunk/Source/WebKit/UIProcess/DrawingAreaProxy.messages.in

    r244633 r252655  
    2121# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
    2222
    23 messages -> DrawingAreaProxy {
     23messages -> DrawingAreaProxy NotRefCounted {
    2424    Update(uint64_t stateID, WebKit::UpdateInfo updateInfo)
    2525    DidUpdateBackingStoreState(uint64_t backingStoreStateID, WebKit::UpdateInfo updateInfo, WebKit::LayerTreeContext context)
  • trunk/Source/WebKit/UIProcess/Network/CustomProtocols/LegacyCustomProtocolManagerProxy.messages.in

    r213441 r252655  
    2121# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
    2222
    23 messages -> LegacyCustomProtocolManagerProxy {
     23messages -> LegacyCustomProtocolManagerProxy NotRefCounted {
    2424    StartLoading(uint64_t customProtocolID, WebCore::ResourceRequest request)
    2525    StopLoading(uint64_t customProtocolID)
  • trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.messages.in

    r252418 r252655  
    2121# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
    2222
    23 messages -> NetworkProcessProxy LegacyReceiver {
     23messages -> NetworkProcessProxy LegacyReceiver NotRefCounted {
    2424    DidReceiveAuthenticationChallenge(PAL::SessionID sessionID, WebKit::WebPageProxyIdentifier pageID, Optional<WebCore::SecurityOriginData> topOrigin, WebCore::AuthenticationChallenge challenge, uint64_t challengeID)
    2525
  • trunk/Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.messages.in

    r249093 r252655  
    2121# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
    2222
    23 messages -> RemoteLayerTreeDrawingAreaProxy : DrawingAreaProxy {
     23messages -> RemoteLayerTreeDrawingAreaProxy : DrawingAreaProxy NotRefCounted {
    2424    void WillCommitLayerTree(WebKit::TransactionID transactionID)
    2525    void CommitLayerTree(WebKit::RemoteLayerTreeTransaction layerTreeTransaction, WebKit::RemoteScrollingCoordinatorTransaction scrollingTreeTransaction)
  • trunk/Source/WebKit/UIProcess/ViewGestureController.messages.in

    r241224 r252655  
    2121# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
    2222
    23 messages -> ViewGestureController {
     23messages -> ViewGestureController NotRefCounted {
    2424#if PLATFORM(MAC)
    2525    DidCollectGeometryForMagnificationGesture(WebCore::FloatRect visibleContentBounds, bool frameHandlesMagnificationGesture)
  • trunk/Source/WebKit/UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.messages.in

    r251489 r252655  
    2525#if ENABLE(WEB_AUTHN)
    2626
    27 messages -> WebAuthenticatorCoordinatorProxy {
     27messages -> WebAuthenticatorCoordinatorProxy NotRefCounted {
    2828
    2929    MakeCredential(WebCore::FrameIdentifier frameID, struct WebCore::SecurityOriginData origin, Vector<uint8_t> hash, struct WebCore::PublicKeyCredentialCreationOptions options) -> (struct WebCore::PublicKeyCredentialData data, struct WebCore::ExceptionData exception) Async
  • trunk/Source/WebKit/UIProcess/WebFullScreenManagerProxy.messages.in

    r243345 r252655  
    2222
    2323#if ENABLE(FULLSCREEN_API)
    24 messages -> WebFullScreenManagerProxy {
     24messages -> WebFullScreenManagerProxy NotRefCounted {
    2525    SupportsFullScreen(bool withKeyboard) -> (bool supportsFullScreen) Synchronous
    2626    EnterFullScreen()
  • trunk/Source/WebKit/UIProcess/WebPasteboardProxy.messages.in

    r251421 r252655  
    2121# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
    2222
    23 messages -> WebPasteboardProxy {
     23messages -> WebPasteboardProxy NotRefCounted {
    2424#if PLATFORM(IOS_FAMILY)
    2525    WriteURLToPasteboard(struct WebCore::PasteboardURL url, String pasteboardName)
  • trunk/Source/WebKit/UIProcess/ios/SmartMagnificationController.messages.in

    r241323 r252655  
    2323#if PLATFORM(IOS_FAMILY)
    2424
    25 messages -> SmartMagnificationController {
     25messages -> SmartMagnificationController NotRefCounted {
    2626    DidCollectGeometryForSmartMagnificationGesture(WebCore::FloatPoint origin, WebCore::FloatRect renderRect, WebCore::FloatRect visibleContentBounds, bool fitEntireRect, double viewportMinimumScale, double viewportMaximumScale)
    2727    Magnify(WebCore::FloatPoint origin, WebCore::FloatRect targetRect, WebCore::FloatRect visibleContentRect, double viewportMinimumScale, double viewportMaximumScale)
  • trunk/Source/WebKit/WebProcess/ApplePay/WebPaymentCoordinator.messages.in

    r250048 r252655  
    2525#if ENABLE(APPLE_PAY)
    2626
    27 messages -> WebPaymentCoordinator {
     27messages -> WebPaymentCoordinator NotRefCounted {
    2828
    2929    ValidateMerchant(String validationURLString)
  • trunk/Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.messages.in

    r248713 r252655  
    2121# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
    2222
    23 messages -> WebAutomationSessionProxy {
     23messages -> WebAutomationSessionProxy NotRefCounted {
    2424    EvaluateJavaScriptFunction(WebCore::PageIdentifier pageID, Optional<WebCore::FrameIdentifier> frameID, String function, Vector<String> arguments, bool expectsImplicitCallbackArgument, int callbackTimeout, uint64_t callbackID)
    2525
  • trunk/Source/WebKit/WebProcess/Geolocation/WebGeolocationManager.messages.in

    r249066 r252655  
    2121# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
    2222
    23 messages -> WebGeolocationManager {
     23messages -> WebGeolocationManager NotRefCounted {
    2424    DidChangePosition(WebCore::GeolocationPositionData position);
    2525    DidFailToDeterminePosition(String errorMessage);
  • trunk/Source/WebKit/WebProcess/Network/webrtc/WebMDNSRegister.messages.in

    r237568 r252655  
    2323#if ENABLE(WEB_RTC)
    2424
    25 messages -> WebMDNSRegister {
     25messages -> WebMDNSRegister NotRefCounted {
    2626    void FinishedRegisteringMDNSName(uint64_t identifier, WebCore::LibWebRTCProvider::MDNSNameOrError result)
    2727}
  • trunk/Source/WebKit/WebProcess/Network/webrtc/WebRTCMonitor.messages.in

    r211441 r252655  
    2323#if USE(LIBWEBRTC)
    2424
    25 messages -> WebRTCMonitor {
     25messages -> WebRTCMonitor NotRefCounted {
    2626    void NetworksChanged(Vector<WebKit::RTCNetwork> networks, WebKit::RTCNetwork::IPAddress defaultIPV4Address, WebKit::RTCNetwork::IPAddress defaultIPV6Address)
    2727}
  • trunk/Source/WebKit/WebProcess/Network/webrtc/WebRTCResolver.messages.in

    r211441 r252655  
    2323#if USE(LIBWEBRTC)
    2424
    25 messages -> WebRTCResolver {
     25messages -> WebRTCResolver NotRefCounted {
    2626    void SetResolvedAddress(Vector<WebKit::RTCNetwork::IPAddress> addresses)
    2727    void ResolvedAddressError(int error)
  • trunk/Source/WebKit/WebProcess/Network/webrtc/WebRTCSocket.messages.in

    r250599 r252655  
    2323#if USE(LIBWEBRTC)
    2424
    25 messages -> WebRTCSocket {
     25messages -> WebRTCSocket NotRefCounted {
    2626    SignalReadPacket(IPC::DataReference data, WebKit::RTCNetwork::IPAddress address, uint16_t port, int64_t timestamp)
    2727    SignalSentPacket(int packetSize, int64_t timestamp)
  • trunk/Source/WebKit/WebProcess/Notifications/WebNotificationManager.messages.in

    r160022 r252655  
    2121# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
    2222
    23 messages -> WebNotificationManager {
     23messages -> WebNotificationManager NotRefCounted {
    2424    DidShowNotification(uint64_t notificationID);
    2525    DidClickNotification(uint64_t notificationID);
  • trunk/Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.messages.in

    r251067 r252655  
    2323#if ENABLE(SERVICE_WORKER)
    2424
    25 messages -> WebSWContextManagerConnection {
     25messages -> WebSWContextManagerConnection NotRefCounted {
    2626    InstallServiceWorker(struct WebCore::ServiceWorkerContextData contextData, String userAgent)
    2727    StartFetch(WebCore::SWServerConnectionIdentifier serverConnectionIdentifier, WebCore::ServiceWorkerIdentifier serviceWorkerIdentifier, WebCore::FetchIdentifier fetchIdentifier, WebCore::ResourceRequest request, struct WebCore::FetchOptions options, IPC::FormDataReference requestBody, String referrer)
  • trunk/Source/WebKit/WebProcess/WebPage/DrawingArea.messages.in

    r246308 r252655  
    2121# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
    2222
    23 messages -> DrawingArea {
     23messages -> DrawingArea NotRefCounted {
    2424    UpdateBackingStoreState(uint64_t backingStoreStateID, bool respondImmediately, float deviceScaleFactor, WebCore::IntSize size, WebCore::IntSize scrollOffset)
    2525    DidUpdate()
  • trunk/Source/WebKit/WebProcess/WebPage/ViewGestureGeometryCollector.messages.in

    r241224 r252655  
    2121# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
    2222
    23 messages -> ViewGestureGeometryCollector {
     23messages -> ViewGestureGeometryCollector NotRefCounted {
    2424#if PLATFORM(COCOA)
    2525    CollectGeometryForSmartMagnificationGesture(WebCore::FloatPoint origin)
  • trunk/Source/WebKit/WebProcess/WebProcess.messages.in

    r252636 r252655  
    2121# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
    2222
    23 messages -> WebProcess LegacyReceiver {
     23messages -> WebProcess LegacyReceiver NotRefCounted {
    2424    InitializeWebProcess(struct WebKit::WebProcessCreationParameters processCreationParameters)
    2525    SetWebsiteDataStoreParameters(struct WebKit::WebProcessDataStoreParameters parameters)
  • trunk/Source/WebKit/WebProcess/cocoa/UserMediaCaptureManager.messages.in

    r237281 r252655  
    2424#if ENABLE(MEDIA_STREAM)
    2525
    26 messages -> UserMediaCaptureManager {
     26messages -> UserMediaCaptureManager NotRefCounted {
    2727    CaptureFailed(uint64_t id)
    2828    SourceStopped(uint64_t id)
Note: See TracChangeset for help on using the changeset viewer.