Changeset 252668 in webkit


Ignore:
Timestamp:
Nov 19, 2019 5:35:20 PM (4 years ago)
Author:
jiewen_tan@apple.com
Message:

Improve WebAuthn NFC tests after r252297
https://bugs.webkit.org/show_bug.cgi?id=204251

Reviewed by Alexey Proskuryakov.

This patch fixes a test failure after r252297 and adds new test contents for r252297.

  • http/wpt/webauthn/public-key-credential-create-failure-nfc.https-expected.txt:
  • http/wpt/webauthn/public-key-credential-create-failure-nfc.https.html:
  • http/wpt/webauthn/public-key-credential-create-success-nfc.https-expected.txt:
  • http/wpt/webauthn/public-key-credential-create-success-nfc.https.html:
Location:
trunk/LayoutTests
Files:
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r252667 r252668  
     12019-11-19  Jiewen Tan  <jiewen_tan@apple.com>
     2
     3        Improve WebAuthn NFC tests after r252297
     4        https://bugs.webkit.org/show_bug.cgi?id=204251
     5
     6        Reviewed by Alexey Proskuryakov.
     7
     8        This patch fixes a test failure after r252297 and adds new test contents for r252297.
     9
     10        * http/wpt/webauthn/public-key-credential-create-failure-nfc.https-expected.txt:
     11        * http/wpt/webauthn/public-key-credential-create-failure-nfc.https.html:
     12        * http/wpt/webauthn/public-key-credential-create-success-nfc.https-expected.txt:
     13        * http/wpt/webauthn/public-key-credential-create-success-nfc.https.html:
     14
    1152019-11-19  Sunny He  <sunny_he@apple.com>
    216
  • trunk/LayoutTests/http/wpt/webauthn/public-key-credential-create-failure-nfc.https-expected.txt

    r249059 r252668  
    66PASS PublicKeyCredential's [[create]] with null version in a mock nfc authenticator.
    77PASS PublicKeyCredential's [[create]] with wrong version in a mock nfc authenticator.
     8PASS PublicKeyCredential's [[create]] with wrong version in a mock nfc authenticator.2
    89
  • trunk/LayoutTests/http/wpt/webauthn/public-key-credential-create-failure-nfc.https.html

    r250940 r252668  
    138138    }, "PublicKeyCredential's [[create]] with wrong version in a mock nfc authenticator.");
    139139
     140    promise_test(function(t) {
     141        const options = {
     142            publicKey: {
     143                rp: {
     144                    name: "example.com"
     145                },
     146                user: {
     147                    name: "John Appleseed",
     148                    id: asciiToUint8Array("123456"),
     149                    displayName: "John",
     150                },
     151                challenge: asciiToUint8Array("123456"),
     152                pubKeyCredParams: [{ type: "public-key", alg: -7 }],
     153                timeout: 10
     154            }
     155        };
     156
     157        if (window.internals)
     158            internals.setMockWebAuthenticationConfiguration({ nfc: { error: "malicious-payload", payloadBase64:[testDummyMessagePayloadBase64, testDummyMessagePayloadBase64] } });
     159        return promiseRejects(t, "NotAllowedError", navigator.credentials.create(options), "Operation timed out.");
     160    }, "PublicKeyCredential's [[create]] with wrong version in a mock nfc authenticator.2");
     161
    140162</script>
  • trunk/LayoutTests/http/wpt/webauthn/public-key-credential-create-success-nfc.https-expected.txt

    r251645 r252668  
    66PASS PublicKeyCredential's [[create]] with multiple physical tags in a mock nfc authenticator.
    77PASS PublicKeyCredential's [[create]] with service restart in a mock nfc authenticator.
     8PASS PublicKeyCredential's [[create]] with legacy U2F keys in a mock nfc authenticator.
    89
  • trunk/LayoutTests/http/wpt/webauthn/public-key-credential-create-success-nfc.https.html

    r251645 r252668  
    139139
    140140        if (window.internals)
    141             internals.setMockWebAuthenticationConfiguration({ silentFailure: true, nfc: { error: "malicious-payload", payloadBase64: [testDummyMessagePayloadBase64, testNfcCtapVersionBase64, testGetInfoResponseApduBase64, testCreationMessageApduBase64] } });
     141            internals.setMockWebAuthenticationConfiguration({ silentFailure: true, nfc: { error: "malicious-payload", payloadBase64: [testDummyMessagePayloadBase64, testDummyMessagePayloadBase64, testNfcCtapVersionBase64, testGetInfoResponseApduBase64, testCreationMessageApduBase64] } });
    142142        return navigator.credentials.create(options).then(credential => {
    143143            checkCtapMakeCredentialResult(credential);
    144144        });
    145145    }, "PublicKeyCredential's [[create]] with service restart in a mock nfc authenticator.");
     146
     147    promise_test(t => {
     148        const options = {
     149            publicKey: {
     150                rp: {
     151                    name: "localhost",
     152                },
     153                user: {
     154                    name: "John Appleseed",
     155                    id: Base64URL.parse(testUserhandleBase64),
     156                    displayName: "Appleseed",
     157                },
     158                challenge: Base64URL.parse("MTIzNDU2"),
     159                pubKeyCredParams: [{ type: "public-key", alg: -7 }]
     160            }
     161        };
     162
     163        if (window.internals)
     164            internals.setMockWebAuthenticationConfiguration({ silentFailure: true, nfc: { error: "malicious-payload", payloadBase64: [testDummyMessagePayloadBase64, testNfcU2fVersionBase64, testGetInfoResponseApduBase64, testCreationMessageApduBase64] } });
     165        return navigator.credentials.create(options).then(credential => {
     166            checkCtapMakeCredentialResult(credential);
     167        });
     168    }, "PublicKeyCredential's [[create]] with legacy U2F keys in a mock nfc authenticator.");
    146169</script>
Note: See TracChangeset for help on using the changeset viewer.