Changeset 252670 in webkit

Timestamp:

Nov 19, 2019 5:53:06 PM (4 years ago)

Author:

sihui_liu@apple.com

Message:

IndexedDB: update m_objectStoresByName after renaming object store
​https://bugs.webkit.org/show_bug.cgi?id=204373

Reviewed by Brady Eidson.

Source/WebCore:

Tests: storage/indexeddb/put-after-objectstore-rename-private.html

storage/indexeddb/put-after-objectstore-rename.html

• Modules/indexeddb/server/MemoryIDBBackingStore.cpp:

(WebCore::IDBServer::MemoryIDBBackingStore::renameObjectStore):

LayoutTests:

• storage/indexeddb/put-after-objectstore-rename-expected.txt: Added.
• storage/indexeddb/put-after-objectstore-rename-private-expected.txt: Added.
• storage/indexeddb/put-after-objectstore-rename-private.html: Added.
• storage/indexeddb/put-after-objectstore-rename.html: Added.
• storage/indexeddb/resources/put-after-objectstore-rename.js: Added.

(prepareDatabase):
(openSuccess):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/storage/indexeddb/put-after-objectstore-rename-expected.txt (added)
• LayoutTests/storage/indexeddb/put-after-objectstore-rename-private-expected.txt (added)
• LayoutTests/storage/indexeddb/put-after-objectstore-rename-private.html (added)
• LayoutTests/storage/indexeddb/put-after-objectstore-rename.html (added)
• LayoutTests/storage/indexeddb/resources/put-after-objectstore-rename.js (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/Modules/indexeddb/server/MemoryIDBBackingStore.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-11-19  Sihui Liu  <sihui_liu@apple.com>
+
+        IndexedDB: update m_objectStoresByName after renaming object store
+        https://bugs.webkit.org/show_bug.cgi?id=204373
+
+        Reviewed by Brady Eidson.
+
+        * storage/indexeddb/put-after-objectstore-rename-expected.txt: Added.
+        * storage/indexeddb/put-after-objectstore-rename-private-expected.txt: Added.
+        * storage/indexeddb/put-after-objectstore-rename-private.html: Added.
+        * storage/indexeddb/put-after-objectstore-rename.html: Added.
+        * storage/indexeddb/resources/put-after-objectstore-rename.js: Added.
+        (prepareDatabase):
+        (openSuccess):
+
 2019-11-19  Jiewen Tan  <jiewen_tan@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-11-19  Sihui Liu  <sihui_liu@apple.com>
+
+        IndexedDB: update m_objectStoresByName after renaming object store
+        https://bugs.webkit.org/show_bug.cgi?id=204373
+
+        Reviewed by Brady Eidson.
+
+        Tests: storage/indexeddb/put-after-objectstore-rename-private.html
+               storage/indexeddb/put-after-objectstore-rename.html
+
+        * Modules/indexeddb/server/MemoryIDBBackingStore.cpp:
+        (WebCore::IDBServer::MemoryIDBBackingStore::renameObjectStore):
+
 2019-11-19  Sunny He  <sunny_he@apple.com>
 

trunk/Source/WebCore/Modules/indexeddb/server/MemoryIDBBackingStore.cpp

@@ -195 +195 @@
     transaction->objectStoreRenamed(*objectStore, oldName);
 
+    m_objectStoresByName.remove(oldName);
+    m_objectStoresByName.set(newName, objectStore);
+
     m_databaseInfo->renameObjectStore(objectStoreIdentifier, newName);