Changeset 252719 in webkit


Ignore:
Timestamp:
Nov 20, 2019 5:08:30 PM (4 years ago)
Author:
Wenson Hsieh
Message:

Correct argument types in UIScriptController::activateDataListSuggestion after r252062
​https://bugs.webkit.org/show_bug.cgi?id=203116

Reviewed by Tim Horton.

Use unsigned to represent unsigned long arguments declared in the IDL.

  • DumpRenderTree/mac/UIScriptControllerMac.h:
  • DumpRenderTree/mac/UIScriptControllerMac.mm:

(WTR::UIScriptControllerMac::activateDataListSuggestion):

  • TestRunnerShared/UIScriptContext/UIScriptController.h:

(WTR::UIScriptController::activateDataListSuggestion):

  • WebKitTestRunner/ios/UIScriptControllerIOS.h:
  • WebKitTestRunner/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptControllerIOS::activateDataListSuggestion):

  • WebKitTestRunner/mac/UIScriptControllerMac.h:
  • WebKitTestRunner/mac/UIScriptControllerMac.mm:

(WTR::UIScriptControllerMac::activateDataListSuggestion):

Location:
trunk/Tools
Files:
8 edited

Legend:

Unmodified
Added
Removed

  • trunk/Tools/ChangeLog

    r252714 r252719  
     12019-11-20  Wenson Hsieh  <wenson_hsieh@apple.com>
     2
     3        Correct argument types in UIScriptController::activateDataListSuggestion after r252062
     4        https://bugs.webkit.org/show_bug.cgi?id=203116
     5
     6        Reviewed by Tim Horton.
     7
     8        Use `unsigned` to represent `unsigned long` arguments declared in the IDL.
     9
     10        * DumpRenderTree/mac/UIScriptControllerMac.h:
     11        * DumpRenderTree/mac/UIScriptControllerMac.mm:
     12        (WTR::UIScriptControllerMac::activateDataListSuggestion):
     13        * TestRunnerShared/UIScriptContext/UIScriptController.h:
     14        (WTR::UIScriptController::activateDataListSuggestion):
     15        * WebKitTestRunner/ios/UIScriptControllerIOS.h:
     16        * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
     17        (WTR::UIScriptControllerIOS::activateDataListSuggestion):
     18        * WebKitTestRunner/mac/UIScriptControllerMac.h:
     19        * WebKitTestRunner/mac/UIScriptControllerMac.mm:
     20        (WTR::UIScriptControllerMac::activateDataListSuggestion):
     21
    1222019-11-20  Fujii Hironori  <Hironori.Fujii@sony.com>
    223

  • trunk/Tools/DumpRenderTree/mac/UIScriptControllerMac.h

    r252377 r252719  
    5151    NSUndoManager *platformUndoManager() const override;
    5252    void copyText(JSStringRef) override;
    53     void activateDataListSuggestion(long, JSValueRef) override;
     53    void activateDataListSuggestion(unsigned, JSValueRef) override;
    5454};
    5555

  • trunk/Tools/DumpRenderTree/mac/UIScriptControllerMac.mm

    r252062 r252719  
    101101}
    102102
    103 void UIScriptControllerMac::activateDataListSuggestion(long index, JSValueRef callback)
     103void UIScriptControllerMac::activateDataListSuggestion(unsigned index, JSValueRef callback)
    104104{
    105105    // FIXME: Not implemented.

  • trunk/Tools/TestRunnerShared/UIScriptContext/UIScriptController.h

    r252377 r252719  
    203203    virtual void setDefaultCalendarType(JSStringRef calendarIdentifier) { notImplemented(); }
    204204    virtual JSObjectRef inputViewBounds() const { notImplemented(); return nullptr; }
    205     virtual void activateDataListSuggestion(long, JSValueRef) { notImplemented(); }
     205    virtual void activateDataListSuggestion(unsigned, JSValueRef) { notImplemented(); }
    206206
    207207    // Share Sheet

  • trunk/Tools/WebKitTestRunner/ios/UIScriptControllerIOS.h

    r252062 r252719  
    130130    void completeBackSwipe(JSValueRef) override;
    131131    bool isShowingDataListSuggestions() const override;
    132     void activateDataListSuggestion(long, JSValueRef) override;
     132    void activateDataListSuggestion(unsigned, JSValueRef) override;
    133133    void drawSquareInEditableImage() override;
    134134    long numberOfStrokesInEditableImage() override;

  • trunk/Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm

    r252062 r252719  
    10331033}
    10341034
    1035 void UIScriptControllerIOS::activateDataListSuggestion(long index, JSValueRef callback)
     1035void UIScriptControllerIOS::activateDataListSuggestion(unsigned index, JSValueRef callback)
    10361036{
    10371037    // FIXME: Not implemented.

  • trunk/Tools/WebKitTestRunner/mac/UIScriptControllerMac.h

    r252062 r252719  
    4444    void simulateAccessibilitySettingsChangeNotification(JSValueRef) override;
    4545    bool isShowingDataListSuggestions() const override;
    46     void activateDataListSuggestion(long index, JSValueRef callback) override;
     46    void activateDataListSuggestion(unsigned index, JSValueRef callback) override;
    4747    void beginBackSwipe(JSValueRef) override;
    4848    void completeBackSwipe(JSValueRef) override;

  • trunk/Tools/WebKitTestRunner/mac/UIScriptControllerMac.mm

    r252062 r252719  
    101101}
    102102
    103 void UIScriptControllerMac::activateDataListSuggestion(long index, JSValueRef callback)
     103void UIScriptControllerMac::activateDataListSuggestion(unsigned index, JSValueRef callback)
    104104{
    105105    unsigned callbackID = m_context->prepareForAsyncTask(callback, CallbackTypeNonPersistent);
Note: See TracChangeset for help on using the changeset viewer.