Changeset 252768 in webkit

Timestamp:

Nov 22, 2019 5:09:29 AM (4 years ago)

Author:

Carlos Garcia Campos

Message:

File input should fire an 'input' event before the 'change' event
​https://bugs.webkit.org/show_bug.cgi?id=204292

Reviewed by Wenson Hsieh.

Source/WebCore:

"Queue a task to first update the element's selected files so that it represents the user's selection, then fire
an event named input at the input element, with the bubbles attribute initialized to true, and finally fire an
event named change at the input element, with the bubbles attribute initialized to true."
​https://html.spec.whatwg.org/#file-upload-state-(type=file):event-input

This will also fix WebDriver test imported/w3c/webdriver/tests/element_send_keys/events.py::test_file_upload in
safari driver.

Test: fast/forms/file/file-input-user-selection-events.html

• html/FileInputType.cpp:

(WebCore::FileInputType::setFiles):

LayoutTests:

Add new test to check both events are fired now.

• fast/forms/file/file-input-user-selection-events-expected.txt: Added.
• fast/forms/file/file-input-user-selection-events.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/forms/file/file-input-user-selection-events-expected.txt (added)
• LayoutTests/fast/forms/file/file-input-user-selection-events.html (added)
• LayoutTests/platform/win/TestExpectations (modified) (1 diff)
• LayoutTests/platform/wincairo/TestExpectations (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/FileInputType.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        File input should fire an 'input' event before the 'change' event
+        https://bugs.webkit.org/show_bug.cgi?id=204292
+
+        Reviewed by Wenson Hsieh.
+
+        Add new test to check both events are fired now.
+
+        * fast/forms/file/file-input-user-selection-events-expected.txt: Added.
+        * fast/forms/file/file-input-user-selection-events.html: Added.
+
 2019-11-21  Jer Noble  <jer.noble@apple.com>
 

trunk/LayoutTests/platform/win/TestExpectations

@@ -3672 +3672 @@
 fast/dom/FileList-iterator-using-open-panel.html [ Skip ]
 fast/forms/file/file-input-reset-using-open-panel.html [ Skip ]
+fast/forms/file/file-input-user-selection-events.html [ Skip ]
 fast/forms/file/file-reset-in-change-using-open-panel.html [ Skip ]
 fast/forms/file/file-reset-in-change-using-open-panel-with-icon.html [ Skip ]

trunk/LayoutTests/platform/wincairo/TestExpectations

@@ -762 +762 @@
 fast/files/filereader-zip-bundle-using-open-panel.html [ Timeout ]
 fast/forms/file/file-input-reset-using-open-panel.html [ Timeout ]
+fast/forms/file/file-input-user-selection-events.html [ Timeout ]
 fast/forms/file/entries-api/webkitdirectory-open-panel.html [ Timeout ]
 fast/forms/file/file-reset-in-change-using-open-panel.html [ Timeout ]

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        File input should fire an 'input' event before the 'change' event
+        https://bugs.webkit.org/show_bug.cgi?id=204292
+
+        Reviewed by Wenson Hsieh.
+
+        "Queue a task to first update the element's selected files so that it represents the user's selection, then fire
+        an event named input at the input element, with the bubbles attribute initialized to true, and finally fire an
+        event named change at the input element, with the bubbles attribute initialized to true."
+        https://html.spec.whatwg.org/#file-upload-state-(type=file):event-input
+
+        This will also fix WebDriver test imported/w3c/webdriver/tests/element_send_keys/events.py::test_file_upload in
+        safari driver.
+
+        Test: fast/forms/file/file-input-user-selection-events.html
+
+        * html/FileInputType.cpp:
+        (WebCore::FileInputType::setFiles):
+
 2019-11-21  Jer Noble  <jer.noble@apple.com>
 

trunk/Source/WebCore/html/FileInputType.cpp

@@ -400 +400 @@
         // This call may cause destruction of this instance.
         // input instance is safe since it is ref-counted.
+        protectedInputElement->dispatchInputEvent();
         protectedInputElement->dispatchChangeEvent();
     }