Changeset 252769 in webkit


Ignore:
Timestamp:
Nov 22, 2019 5:28:57 AM (4 years ago)
Author:
Chris Dumez
Message:

[ iOS Release ]: Layout Test http/tests/navigation/page-cache-domcache-pending-promise.html is a Flaky Timeout
​https://bugs.webkit.org/show_bug.cgi?id=203373
<rdar://problem/56590038>

Reviewed by Youenn Fablet.

I am not able to reproduce the flakiness so this includes speculative fixes and better error handling so
that the test would hopefully fail with a message instead of timing out.

Speculative fixes:

  1. If the promise is resolved before we've navigated away, retry it asynchronously.
  2. If the promise is rejected before we've navigated away, retry it asynchronously instead of synchronously. I believe it is possible to prevent the navigation otherwise, in cases where the promise is rejected synchronously.
  • http/tests/navigation/page-cache-domcache-pending-promise-expected.txt:
  • http/tests/navigation/page-cache-domcache-pending-promise.html:
Location:
trunk/LayoutTests
Files:
1 added
1 deleted
5 edited
3 moved

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r252768 r252769  
     12019-11-22  Chris Dumez  <cdumez@apple.com>
     2
     3        [ iOS Release ]: Layout Test http/tests/navigation/page-cache-domcache-pending-promise.html is a Flaky Timeout
     4        https://bugs.webkit.org/show_bug.cgi?id=203373
     5        <rdar://problem/56590038>
     6
     7        Reviewed by Youenn Fablet.
     8
     9        I am not able to reproduce the flakiness so this includes speculative fixes and better error handling so
     10        that the test would hopefully fail with a message instead of timing out.
     11
     12        Speculative fixes:
     13        1. If the promise is resolved before we've navigated away, retry it asynchronously.
     14        2. If the promise is rejected before we've navigated away, retry it asynchronously instead of synchronously.
     15           I believe it is possible to prevent the navigation otherwise, in cases where the promise is rejected
     16           synchronously.
     17
     18        * http/tests/navigation/page-cache-domcache-pending-promise-expected.txt:
     19        * http/tests/navigation/page-cache-domcache-pending-promise.html:
     20
    1212019-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
    222

  • trunk/LayoutTests/TestExpectations

    r252701 r252769  
    474474imported/w3c/web-platform-tests/workers/SharedWorker_blobUrl.html [ Skip ]
    475475
    476 http/tests/navigation/page-cache-domcache-pending-promise.html [ DumpJSConsoleLogInStdErr ]
     476http/tests/cache-storage/page-cache-domcache-pending-promise.html [ DumpJSConsoleLogInStdErr ]
    477477
    478478imported/w3c/web-platform-tests/beacon/beacon-basic-blob.html [ DumpJSConsoleLogInStdErr ]

  • trunk/LayoutTests/http/tests/cache-storage/page-cache-domcache-pending-promise-expected.txt

    r252768 r252769  
    88pageshow - from cache
    99PASS Page was restored from Page Cache
    10 PASS Cache.add() succeeded
    11 PASS !!restoredFromPageCache is true
     10PASS Cache.add() succeeded after restoring from the cache
    1211PASS successfullyParsed is true
    1312

  • trunk/LayoutTests/http/tests/cache-storage/page-cache-domcachestorage-pending-promise.html

    r252768 r252769  
    4242}
    4343</script>
    44 <a id="testLink" href="resources/page-cache-helper.html" style="display: none">Link</a>
     44<a id="testLink" href="../navigation/resources/page-cache-helper.html" style="display: none">Link</a>
    4545</body>
    4646</html>

  • trunk/LayoutTests/platform/ios-wk1/TestExpectations

    r252397 r252769  
    1212http/wpt/cache-storage [ Skip ]
    1313http/tests/cache-storage [ Skip ]
    14 http/tests/navigation/page-cache-domcache-pending-promise.html [ Skip ]
    15 http/tests/navigation/page-cache-domcachestorage-pending-promise.html [ Skip ]
    1614imported/w3c/web-platform-tests/fetch/api/request/destination [ Skip ]
    1715imported/w3c/web-platform-tests/fetch/cross-origin-resource-policy [ Skip ]

  • trunk/LayoutTests/platform/mac-wk1/TestExpectations

    r252627 r252769  
    277277http/tests/appcache/main-resource-redirect-with-sw.html [ Skip ]
    278278http/tests/cache-storage [ Skip ]
    279 http/tests/navigation/page-cache-domcache-pending-promise.html [ Skip ]
    280 http/tests/navigation/page-cache-domcachestorage-pending-promise.html [ Skip ]
    281279http/tests/cookies/same-site/fetch-in-cross-origin-service-worker.html [ Skip ]
    282280http/tests/cookies/same-site/fetch-in-same-origin-service-worker.html [ Skip ]

  • trunk/LayoutTests/platform/win/TestExpectations

    r252768 r252769  
    38053805http/tests/appcache/main-resource-redirect-with-sw.html [ Skip ]
    38063806http/tests/cache-storage [ Skip ]
    3807 http/tests/navigation/page-cache-domcache-pending-promise.html [ Skip ]
    3808 http/tests/navigation/page-cache-domcachestorage-pending-promise.html [ Skip ]
    38093807http/tests/inspector/network/resource-response-service-worker.html [ Skip ]
    38103808http/tests/workers/service [ Skip ]
Note: See TracChangeset for help on using the changeset viewer.