Changeset 252782 in webkit


Ignore:
Timestamp:
Nov 22, 2019 10:41:33 AM (4 years ago)
Author:
Conrad Shultz
Message:

Remove -[_WKThumbnailView usesSnapshot/setUsesSnapshot:]
https://bugs.webkit.org/show_bug.cgi?id=150099

Reviewed by Tim Horton.

Remove some unused, no-op SPI. While we're here, remove a couple unneeded explicit
property syntheses.

  • UIProcess/API/Cocoa/_WKThumbnailView.h:
  • UIProcess/API/Cocoa/_WKThumbnailView.mm:

(-[_WKThumbnailView setUsesSnapshot:]): Deleted.
(-[_WKThumbnailView usesSnapshot]): Deleted.

Location:
trunk/Source/WebKit
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit/ChangeLog

    r252778 r252782  
     12019-11-22  Conrad Shultz  <conrad_shultz@apple.com>
     2
     3        Remove -[_WKThumbnailView usesSnapshot/setUsesSnapshot:]
     4        https://bugs.webkit.org/show_bug.cgi?id=150099
     5
     6        Reviewed by Tim Horton.
     7
     8        Remove some unused, no-op SPI. While we're here, remove a couple unneeded explicit
     9        property syntheses.
     10
     11        * UIProcess/API/Cocoa/_WKThumbnailView.h:
     12        * UIProcess/API/Cocoa/_WKThumbnailView.mm:
     13        (-[_WKThumbnailView setUsesSnapshot:]): Deleted.
     14        (-[_WKThumbnailView usesSnapshot]): Deleted.
     15
    1162019-11-22  Chris Dumez  <cdumez@apple.com>
    217
  • trunk/Source/WebKit/UIProcess/API/Cocoa/_WKThumbnailView.h

    r243376 r252782  
    5252@property (strong, nonatomic) NSColor *overrideBackgroundColor;
    5353
    54 // This should be removed when all clients go away; it is always YES now.
    55 @property (nonatomic) BOOL usesSnapshot;
    56 
    5754- (void)requestSnapshot;
    5855
  • trunk/Source/WebKit/UIProcess/API/Cocoa/_WKThumbnailView.mm

    r250595 r252782  
    6060}
    6161
    62 @synthesize snapshotSize=_snapshotSize;
    6362@synthesize _waitingForSnapshot=_waitingForSnapshot;
    64 @synthesize exclusivelyUsesSnapshot=_exclusivelyUsesSnapshot;
    65 @synthesize shouldKeepSnapshotWhenRemovedFromSuperview=_shouldKeepSnapshotWhenRemovedFromSuperview;
    6663
    6764- (instancetype)initWithFrame:(NSRect)frame
     
    267264}
    268265
    269 // This should be removed when all clients go away; it is always YES now.
    270 - (void)setUsesSnapshot:(BOOL)usesSnapshot
    271 {
    272 }
    273 
    274 - (BOOL)usesSnapshot
    275 {
    276     return YES;
    277 }
    278 
    279266- (void)_setThumbnailLayer:(CALayer *)layer
    280267{
Note: See TracChangeset for help on using the changeset viewer.