Changeset 252799 in webkit


Ignore:
Timestamp:
Nov 22, 2019 1:58:08 PM (4 years ago)
Author:
Devin Rousso
Message:

Web Inspector: REGRESSION(r251227): dashboard no longer shows page weight
​https://bugs.webkit.org/show_bug.cgi?id=204528

Reviewed by Brian Burg.

WI.contentLoaded adds the debuggable type as a class to the <body>. In r251227, the
"web" debuggable type was split into "page" and "web-page". Update the few selectors that
used the debuggable type to show/hide parts of the UI.

  • UserInterface/Views/DashboardContainerView.css:

(body:matches(.page, .web-page) .toolbar .dashboard-container): Added.
(body:not(.page, .web-page) .toolbar .dashboard-container): Added.
(body.web .toolbar .dashboard-container): Deleted.
(body:not(.web) .toolbar .dashboard-container): Deleted.

  • UserInterface/Views/DefaultDashboardView.css:

(body:matches(.page, .web-page) .toolbar.collapsed .dashboard.default > :matches(.resourcesSize, .time, .logs)): Added.
(body:not(.page, .web-page) .toolbar .dashboard.default > :matches(.resourcesCount, .resourcesSize, .time)): Added.
(body.web .toolbar.collapsed .dashboard.default > :matches(.resourcesSize, .time, .logs)): Deleted.
(body:not(.web) .toolbar .dashboard.default > :matches(.resourcesCount, .resourcesSize, .time)): Deleted.

Location:
trunk/Source/WebInspectorUI
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebInspectorUI/ChangeLog

    r252790 r252799  
     12019-11-22  Devin Rousso  <drousso@apple.com>
     2
     3        Web Inspector: REGRESSION(r251227): dashboard no longer shows page weight
     4        https://bugs.webkit.org/show_bug.cgi?id=204528
     5
     6        Reviewed by Brian Burg.
     7
     8        `WI.contentLoaded` adds the debuggable type as a class to the `<body>`. In r251227, the
     9        "web" debuggable type was split into "page" and "web-page". Update the few selectors that
     10        used the debuggable type to show/hide parts of the UI.
     11
     12        * UserInterface/Views/DashboardContainerView.css:
     13        (body:matches(.page, .web-page) .toolbar .dashboard-container): Added.
     14        (body:not(.page, .web-page) .toolbar .dashboard-container): Added.
     15        (body.web .toolbar .dashboard-container): Deleted.
     16        (body:not(.web) .toolbar .dashboard-container): Deleted.
     17        * UserInterface/Views/DefaultDashboardView.css:
     18        (body:matches(.page, .web-page) .toolbar.collapsed .dashboard.default > :matches(.resourcesSize, .time, .logs)): Added.
     19        (body:not(.page, .web-page) .toolbar .dashboard.default > :matches(.resourcesCount, .resourcesSize, .time)): Added.
     20        (body.web .toolbar.collapsed .dashboard.default > :matches(.resourcesSize, .time, .logs)): Deleted.
     21        (body:not(.web) .toolbar .dashboard.default > :matches(.resourcesCount, .resourcesSize, .time)): Deleted.
     22
    1232019-11-20  Brian Burg  <bburg@apple.com>
    224

  • trunk/Source/WebInspectorUI/UserInterface/Views/DashboardContainerView.css

    r242768 r252799  
    3333}
    3434
    35 body.web .toolbar .dashboard-container {
     35body:matches(.page, .web-page) .toolbar .dashboard-container {
    3636    width: 36vw;
    3737    min-width: 350px;
    3838}
    3939
    40 body:not(.web) .toolbar .dashboard-container {
     40body:not(.page, .web-page) .toolbar .dashboard-container {
    4141    width: 25vw;
    4242    min-width: 175px;

  • trunk/Source/WebInspectorUI/UserInterface/Views/DefaultDashboardView.css

    r246724 r252799  
    2424 */
    2525
    26 body.web .toolbar.collapsed .dashboard.default > :matches(.resourcesSize, .time, .logs) {
     26body:matches(.page, .web-page) .toolbar.collapsed .dashboard.default > :matches(.resourcesSize, .time, .logs) {
    2727    display: none;
    2828}
    2929
    30 body:not(.web) .toolbar .dashboard.default > :matches(.resourcesCount, .resourcesSize, .time) {
     30body:not(.page, .web-page) .toolbar .dashboard.default > :matches(.resourcesCount, .resourcesSize, .time) {
    3131    display: none;
    3232}
Note: See TracChangeset for help on using the changeset viewer.